From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 210ADC433B4 for ; Wed, 28 Apr 2021 09:30:16 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 6CA2C610F7 for ; Wed, 28 Apr 2021 09:30:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CA2C610F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 62B3A4014E; Wed, 28 Apr 2021 11:30:13 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 2B02840147 for ; Wed, 28 Apr 2021 11:30:10 +0200 (CEST) IronPort-SDR: EF74jjgliSKfq7FdPRelSQ30696Mc/7bO+YhlhJsX1cE7zRU/lc64zFGUDrOkg2b+j/zlgU5BP zOi5cIx12M+Q== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="196253783" X-IronPort-AV: E=Sophos;i="5.82,257,1613462400"; d="scan'208";a="196253783" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 02:30:10 -0700 IronPort-SDR: MvqI4u0TVsX/ZvHzew0ju676f1py14ahrZPjY7lPAAbG/z+SnAJCIWgBqIIC1bF1aJ1cubSelP cz1FhAeBS2eg== X-IronPort-AV: E=Sophos;i="5.82,257,1613462400"; d="scan'208";a="423444771" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.177]) ([10.213.241.177]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2021 02:30:09 -0700 To: Wenjun Wu , dev@dpdk.org, beilei.xing@intel.com References: <20210422053430.44883-1-wenjun1.wu@intel.com> <20210425020250.205597-1-wenjun1.wu@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <8977359b-c937-6660-c876-10cc7e3e3892@intel.com> Date: Wed, 28 Apr 2021 10:30:08 +0100 MIME-Version: 1.0 In-Reply-To: <20210425020250.205597-1-wenjun1.wu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: extend VF reset waiting time X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/25/2021 3:02 AM, Wenjun Wu wrote: > When resetting VF, VF will issue reset command to PF, wait a > fixed amount of time, and assume VF reset is done. However, > due to the change of dpdk related library content, the original > delay is not enough. When we use DPDK PF instead of kernel PF, > it may cause VF start error. > Hi Wenjun, Can you please give details of the "the change of dpdk related library content"? This can help to document the root cause of the problem. And you can also add fixes tag for that change if it is appropriate. > This patch extend VF reset waiting time from 200ms to 500ms so that > VF can start normally when using DPDK PF and DPDK VF in most cases. > > Signed-off-by: Wenjun Wu > --- > drivers/net/i40e/i40e_ethdev_vf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c > index 3c258ba7cf..aeb6816b9f 100644 > --- a/drivers/net/i40e/i40e_ethdev_vf.c > +++ b/drivers/net/i40e/i40e_ethdev_vf.c > @@ -1236,7 +1236,7 @@ i40evf_reset_vf(struct rte_eth_dev *dev) > * it to ACTIVE. In this duration, vf may not catch the moment that > * COMPLETE is set. So, for vf, we'll try to wait a long time. > */ > - rte_delay_ms(200); > + rte_delay_ms(500); > > ret = i40evf_check_vf_reset_done(dev); > if (ret) { >