All of lore.kernel.org
 help / color / mirror / Atom feed
From: "huangguangbin (A)" <huangguangbin2@huawei.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <mkubecek@suse.cz>, <andrew@lunn.ch>,
	<amitc@mellanox.com>, <idosch@idosch.org>, <danieller@nvidia.com>,
	<jesse.brandeburg@intel.com>, <anthony.l.nguyen@intel.com>,
	<jdike@addtoit.com>, <richard@nod.at>,
	<anton.ivanov@cambridgegreys.com>, <netanel@amazon.com>,
	<akiyano@amazon.com>, <gtzalik@amazon.com>, <saeedb@amazon.com>,
	<chris.snook@gmail.com>, <ulli.kroll@googlemail.com>,
	<linus.walleij@linaro.org>, <jeroendb@google.com>,
	<csully@google.com>, <awogbemila@google.com>, <jdmason@kudzu.us>,
	<rain.1986.08.12@gmail.com>, <zyjzyj2000@gmail.com>,
	<kys@microsoft.com>, <haiyangz@microsoft.com>, <mst@redhat.com>,
	<jasowang@redhat.com>, <doshir@vmware.com>,
	<pv-drivers@vmware.com>, <jwi@linux.ibm.com>,
	<kgraul@linux.ibm.com>, <hca@linux.ibm.com>, <gor@linux.ibm.com>,
	<johannes@sipsolutions.net>, <netdev@vger.kernel.org>,
	<lipeng321@huawei.com>, <chenhao288@hisilicon.com>,
	<linux-s390@vger.kernel.org>
Subject: Re: [PATCH V3 net-next 4/6] ethtool: extend ringparam setting uAPI with rx_buf_len
Date: Thu, 14 Oct 2021 14:35:46 +0800	[thread overview]
Message-ID: <897d5405-8b51-da39-4720-21bb315946e5@huawei.com> (raw)
In-Reply-To: <20211012112637.5489ac9d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>



On 2021/10/13 2:26, Jakub Kicinski wrote:
> On Tue, 12 Oct 2021 21:41:25 +0800 Guangbin Huang wrote:
>> @@ -80,7 +83,10 @@ static int rings_fill_reply(struct sk_buff *skb,
>>   	     (nla_put_u32(skb, ETHTOOL_A_RINGS_TX_MAX,
>>   			  ringparam->tx_max_pending) ||
>>   	      nla_put_u32(skb, ETHTOOL_A_RINGS_TX,
>> -			  ringparam->tx_pending))))
>> +			  ringparam->tx_pending)))  ||
>> +	    (ringparam_ext->rx_buf_len &&
>> +	     (nla_put_u32(skb, ETHTOOL_A_RINGS_RX_BUF_LEN,
>> +			  ringparam_ext->rx_buf_len))))
>>   		return -EMSGSIZE;
> 
> I think that this chunk belongs in the previous patch.
> .
> 
Ok, we will move them in next version.

  reply	other threads:[~2021-10-14  6:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-12 13:41 [PATCH V3 net-next 0/6] ethtool: add support to set/get tx copybreak buf size and rx buf len Guangbin Huang
2021-10-12 13:41 ` [PATCH V3 net-next 1/6] ethtool: add support to set/get tx copybreak buf size via ethtool Guangbin Huang
2021-10-12 13:41 ` [PATCH V3 net-next 2/6] net: hns3: add support to set/get tx copybreak buf size via ethtool for hns3 driver Guangbin Huang
2021-10-12 13:41 ` [PATCH V3 net-next 3/6] ethtool: add support to set/get rx buf len via ethtool Guangbin Huang
2021-10-12 18:26   ` Jakub Kicinski
2021-10-14  6:24     ` huangguangbin (A)
2021-10-12 13:41 ` [PATCH V3 net-next 4/6] ethtool: extend ringparam setting uAPI with rx_buf_len Guangbin Huang
2021-10-12 14:19   ` Haiyang Zhang
2021-10-12 16:28   ` Jakub Kicinski
2021-10-14  6:32     ` huangguangbin (A)
2021-10-12 18:26   ` Jakub Kicinski
2021-10-14  6:35     ` huangguangbin (A) [this message]
2021-10-13  0:46   ` kernel test robot
2021-10-13  6:18   ` kernel test robot
2021-10-12 13:41 ` [PATCH V3 net-next 5/6] net: hns3: add support to set/get rx buf len via ethtool for hns3 driver Guangbin Huang
2021-10-12 13:41 ` [PATCH V3 net-next 6/6] net: hns3: remove the way to set tx spare buf via module parameter Guangbin Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=897d5405-8b51-da39-4720-21bb315946e5@huawei.com \
    --to=huangguangbin2@huawei.com \
    --cc=akiyano@amazon.com \
    --cc=amitc@mellanox.com \
    --cc=andrew@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=awogbemila@google.com \
    --cc=chenhao288@hisilicon.com \
    --cc=chris.snook@gmail.com \
    --cc=csully@google.com \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=doshir@vmware.com \
    --cc=gor@linux.ibm.com \
    --cc=gtzalik@amazon.com \
    --cc=haiyangz@microsoft.com \
    --cc=hca@linux.ibm.com \
    --cc=idosch@idosch.org \
    --cc=jasowang@redhat.com \
    --cc=jdike@addtoit.com \
    --cc=jdmason@kudzu.us \
    --cc=jeroendb@google.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=jwi@linux.ibm.com \
    --cc=kgraul@linux.ibm.com \
    --cc=kuba@kernel.org \
    --cc=kys@microsoft.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=lipeng321@huawei.com \
    --cc=mkubecek@suse.cz \
    --cc=mst@redhat.com \
    --cc=netanel@amazon.com \
    --cc=netdev@vger.kernel.org \
    --cc=pv-drivers@vmware.com \
    --cc=rain.1986.08.12@gmail.com \
    --cc=richard@nod.at \
    --cc=saeedb@amazon.com \
    --cc=ulli.kroll@googlemail.com \
    --cc=zyjzyj2000@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.