From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F31C54EBC for ; Wed, 11 Jan 2023 19:47:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233792AbjAKTrB (ORCPT ); Wed, 11 Jan 2023 14:47:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235273AbjAKTqG (ORCPT ); Wed, 11 Jan 2023 14:46:06 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A38CCD2F2; Wed, 11 Jan 2023 11:45:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3DDAA61E06; Wed, 11 Jan 2023 19:45:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 97BF2C433D2; Wed, 11 Jan 2023 19:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673466301; bh=xRr7us8zBW0sk990QLjOp0ucsfIPeo81l4T24fBaPC4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=sKny68A3/QnJwl4Wk9++6MFNKMrAlPUELmesjETKeCB20k/As5eX4jlVVJy9UB+JG vkfnftDpWJ/G1xD56x9raf2Q0G/oFMdFJJtZfFUeYq9aTVHl6TkR2MB9tY4vDy+yQV S7tslv0IMokoh95dI43PC8ppZEl/h2WQGiilovuORceThkx1RWjp9dZNcK5tW5sf4B CL1lOZBwxuQEahlWvhuGS4jJn8LYOz2K38AZgV2bN6OJ+U94P5Ow+40NCdtH/oH7Mi ZWLOPjgTU92ubxpASPdAYCtAvPY3BjNnTddzXlxecSx3DWTj+7GcfCCicC5TmVvwrx gyEoZ//R/BlBw== Message-ID: <8980856c1138571976f00413b94cfeb8.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221226095745.19757-2-a-bhatia1@ti.com> References: <20221226095745.19757-1-a-bhatia1@ti.com> <20221226095745.19757-2-a-bhatia1@ti.com> Subject: Re: [PATCH 1/2] dt-bindings: clock: fixed-factor: Add TI AM62 SoC OLDI clock From: Stephen Boyd Cc: Tomi Valkeinen , Samuel Holland , Maxime Ripard , Linux Clock List , Devicetree List , Linux Kernel List , Nishanth Menon , Vignesh Raghavendra , Devarsh Thakkar , Jai Luthra , Aradhya Bhatia To: Aradhya Bhatia , Krzysztof Kozlowski , Michael Turquette , Rob Herring Date: Wed, 11 Jan 2023 11:44:59 -0800 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Aradhya Bhatia (2022-12-26 01:57:44) > Add "ti,k3-am62-oldi-clk-div" to the fixed factor clock compatible enum > list. >=20 > "ti,k3-am62-oldi-clk-div" is a fixed-factor clock that helps the TI > display subsystem request a pixel clock for itself and a corresponding > serial clock for its OLDI Transmitters. The serial clock is 7 times the > pixel clock. This clock needs the clock set rate request to be > propagated to the parent clock provider. >=20 > Signed-off-by: Aradhya Bhatia > --- > Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/Documentation/devicetree/bindings/clock/fixed-factor-clock.y= aml b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml > index 8f71ab300470..0696237530f7 100644 > --- a/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/fixed-factor-clock.yaml > @@ -14,6 +14,7 @@ properties: > compatible: > enum: > - fixed-factor-clock > + - ti,k3-am62-oldi-clk-div I don't see this compatible anywhere in the kernel tree. Is there a patch that adds a node using this? I wonder why the display subsystem can't add this fixed factor clk directly in the driver. Does the OLDI Transmitter send a clk to the display subsystem? I'm asking all these questions because we got rid of vendor compatibles here in hopes of simplifying the logic. Maybe the problem can be approached differently, but I don't know all the details.