From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 233E1C432C0 for ; Wed, 27 Nov 2019 18:54:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1C442080F for ; Wed, 27 Nov 2019 18:54:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727010AbfK0Syo (ORCPT ); Wed, 27 Nov 2019 13:54:44 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:39233 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726984AbfK0Syo (ORCPT ); Wed, 27 Nov 2019 13:54:44 -0500 Received: by mail-pg1-f194.google.com with SMTP id b137so9033371pga.6; Wed, 27 Nov 2019 10:54:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iNMKV6JKx16eJZPWeMfLiRiiW9bu99KddtEjmyG/dBw=; b=iRZSk9YZXucgxSGamn2ePuWOld1AtB7dlllIpqHr1CwQNJkz01jFxrBoWcRpQ+Ly4B TXd5D4yiPRTZYWKsGJc9VlBgXcaF3cRg1+uAFMtddC7OU+qvb78nKuQ8CulRt8gREFDl EScQrazXX0FAzfoyYVuxxP5f6v+e8ODqme2fPNke5ZuxpA93ydjYQRWUOD8wUOqvzqn0 KAh62up1efrIRhg5yQlhFWimnz/a7VvjPWdft3E8UbgD3G1KqV2+Jn+xS1AyE2rIKXFV LJCgm0ySmPREaaD1aUTrL3WEk9H21pZE8iExes1o/RHYaTq0uAFqp5qVqgHu1sLzgJN9 Syvw== X-Gm-Message-State: APjAAAXng/oZb8gaucRTcS69FEOE4cjz3ZTHYqS6or2opOAgGNk7f6aI +DtHBwWW0Bx7aCj8bMGGul8G6isQ4uA= X-Google-Smtp-Source: APXvYqwM60udEdRU61xo0iuYVsNDZqo6TRXXgKHNgiD1W7HWHYnqXvx+mPjwp9lBn9tcojds7pkzhw== X-Received: by 2002:a63:447:: with SMTP id 68mr6357827pge.364.1574880882964; Wed, 27 Nov 2019 10:54:42 -0800 (PST) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:202:4308:52a3:24b6:2c60]) by smtp.gmail.com with ESMTPSA id j7sm3831350pgn.0.2019.11.27.10.54.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2019 10:54:41 -0800 (PST) Subject: Re: [f2fs-dev] [PATCH v3] loop: avoid EAGAIN, if offset or block_size are changed To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jens Axboe , linux-block@vger.kernel.org, stable@vger.kernel.org References: <20190518004751.18962-1-jaegeuk@kernel.org> <20190518005304.GA19446@jaegeuk-macbookpro.roam.corp.google.com> <20191127181809.GA42245@jaegeuk-macbookpro.roam.corp.google.com> From: Bart Van Assche Message-ID: <898950e4-3759-c78e-dd5d-422af9f8c507@acm.org> Date: Wed, 27 Nov 2019 10:54:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191127181809.GA42245@jaegeuk-macbookpro.roam.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 11/27/19 10:18 AM, Jaegeuk Kim wrote: > Previously, there was a bug where user could see stale buffer cache (e.g, 512B) > attached in the 4KB-sized pager cache, when the block size was changed from > 512B to 4KB. That was fixed by: > commit 5db470e229e2 ("loop: drop caches if offset or block_size are changed") [ ... ] Reviewed-by: Bart Van Assche From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE91C432C0 for ; Wed, 27 Nov 2019 18:54:56 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EF9742080F; Wed, 27 Nov 2019 18:54:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="f3Y7b9Sm"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="ZfNpCY1f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF9742080F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=acm.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1ia2Sj-00048u-J7; Wed, 27 Nov 2019 18:54:53 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ia2Si-00048n-Nf for linux-f2fs-devel@lists.sourceforge.net; Wed, 27 Nov 2019 18:54:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=iNMKV6JKx16eJZPWeMfLiRiiW9bu99KddtEjmyG/dBw=; b=f3Y7b9SmcfKyzhqUQkc/r1r9Ue 5say+S3lUZuDFCjKv/Nxobf4qkJbBgIXpZ9gVyXACXfovfE+tk+YUZ8echy6jee1idXRSo5t55fwA 34svZmT3hbhRZNQfmF3tX79MiDrd43zK8ckwpaAvUp/TsBy+B7DrdCkwZlig9xgroWOs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=iNMKV6JKx16eJZPWeMfLiRiiW9bu99KddtEjmyG/dBw=; b=ZfNpCY1f+m+GTX8k0VwSzw4Tq0 GlbTthJi0XNwwr3hQoNmPf1uJhR+IL0D6jGL0/TMf1XKTF/mfaLm2v3qhBRdEAlli+OIvKuPiGc2O MRVjezdz14h9Q6fQ+0Ahci767kMUKy/xPIvJVG2rQHQM6d3DU7YjyykVh5yN8Af8C7e4=; Received: from mail-pg1-f196.google.com ([209.85.215.196]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1ia2Se-00FQ6l-TA for linux-f2fs-devel@lists.sourceforge.net; Wed, 27 Nov 2019 18:54:53 +0000 Received: by mail-pg1-f196.google.com with SMTP id k13so11363538pgh.3 for ; Wed, 27 Nov 2019 10:54:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iNMKV6JKx16eJZPWeMfLiRiiW9bu99KddtEjmyG/dBw=; b=FLfRC6Dmc50vuJMnZq4pe+rmPdxvPaeND0xJ5yEPHHVJn0+fnOTZcPmYY5LPfkeNEj 7txd2wZqrqM/tH9MgOwoh+P00qgfcviG0vicGk2pt7AEoH5sJo4DYFqM2RNaWrNR8cHQ 1F3BI6N/rzNHiwkG3ttR1WDyqIO13cDn0C6SE3LAs+OoMETbwM2k2WiSZRcW1JKp6RqU OCaiPc0/Wf8DFycCmgiq3XnoRKMsvqr7TSTDbin+dLDecs3Vb7ixJgGY09YT0J3nbM0s L6ikimNkJaco6rlIq0TBpyWFNfnhBONNZOZMhQ6I2e4k7R/q9ye1WtIBzFaMu7bNOOrO xyqw== X-Gm-Message-State: APjAAAV9MYgJLR01PF0EIgcS5ohvD4W19L3iU5a0PCH5i8tZt6LzeEfj k9ynfV7a3iSkKVcB39UYUz4= X-Google-Smtp-Source: APXvYqwM60udEdRU61xo0iuYVsNDZqo6TRXXgKHNgiD1W7HWHYnqXvx+mPjwp9lBn9tcojds7pkzhw== X-Received: by 2002:a63:447:: with SMTP id 68mr6357827pge.364.1574880882964; Wed, 27 Nov 2019 10:54:42 -0800 (PST) Received: from desktop-bart.svl.corp.google.com ([2620:15c:2cd:202:4308:52a3:24b6:2c60]) by smtp.gmail.com with ESMTPSA id j7sm3831350pgn.0.2019.11.27.10.54.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2019 10:54:41 -0800 (PST) To: Jaegeuk Kim , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20190518004751.18962-1-jaegeuk@kernel.org> <20190518005304.GA19446@jaegeuk-macbookpro.roam.corp.google.com> <20191127181809.GA42245@jaegeuk-macbookpro.roam.corp.google.com> From: Bart Van Assche Message-ID: <898950e4-3759-c78e-dd5d-422af9f8c507@acm.org> Date: Wed, 27 Nov 2019 10:54:40 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191127181809.GA42245@jaegeuk-macbookpro.roam.corp.google.com> Content-Language: en-US X-Headers-End: 1ia2Se-00FQ6l-TA Subject: Re: [f2fs-dev] [PATCH v3] loop: avoid EAGAIN, if offset or block_size are changed X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , linux-block@vger.kernel.org, stable@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 11/27/19 10:18 AM, Jaegeuk Kim wrote: > Previously, there was a bug where user could see stale buffer cache (e.g, 512B) > attached in the 4KB-sized pager cache, when the block size was changed from > 512B to 4KB. That was fixed by: > commit 5db470e229e2 ("loop: drop caches if offset or block_size are changed") [ ... ] Reviewed-by: Bart Van Assche _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel