From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751105AbcFITX5 (ORCPT ); Thu, 9 Jun 2016 15:23:57 -0400 Received: from us-smtp-delivery-194.mimecast.com ([216.205.24.194]:44655 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbcFITXz (ORCPT ); Thu, 9 Jun 2016 15:23:55 -0400 From: Trond Myklebust To: Deepa Dinamani , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Arnd Bergmann , Thomas Gleixner , "Al Viro" , Linus Torvalds , "y2038@lists.linaro.org" , Anna Schumaker , "linux-nfs@vger.kernel.org" Subject: Re: [PATCH 18/21] fs: nfs: Make nfs boot time y2038 safe Thread-Topic: [PATCH 18/21] fs: nfs: Make nfs boot time y2038 safe Thread-Index: AQHRwgyhy4gw6l+dB0u0MAW8csgWrZ/hQbyA Date: Thu, 9 Jun 2016 19:23:49 +0000 Message-ID: <89EF59F9-52D2-4F37-A7A8-52BD0FF7E98E@primarydata.com> References: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> <1465448705-25055-19-git-send-email-deepa.kernel@gmail.com> In-Reply-To: <1465448705-25055-19-git-send-email-deepa.kernel@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [68.49.162.121] x-ms-office365-filtering-correlation-id: 3feec2d7-a509-4a6c-90c3-08d3909b9593 x-microsoft-exchange-diagnostics: 1;BN3PR11MB0306;5:FlAJxOh2x4ccDXdJqHEAYWMdQqY+2kWdmzufz/ooU5tj5x7ah+S7W3sLdIz1dGTiUSVvkxseqiZ99JY9TyxjHwm8Zx0GqSzmDSzIvjGz/57kvPCFdgiz/obHXQE+hQku4bjH9RAi/BoVZm0PkxREQA==;24:Lu13QodbDcnxEVtftCFB4MoqbxNHgvR13Z3Znr3Uq8p0qcu8WsaqbsyaHBSXis4zorV06QpgEuynNn94nqkC8zjkpHpR3RC2HbVwcsyAL8k=;7:+VVd7ryk8kwbz8yJCAqvUJo9bQxuXXQl7wKwyJTwyMCoyrpQzFQjFnHQ0lpUKjcSlc/LyEcOmEKg5EqsumzwXlF72ipUSDPgqgKC6HurbqEgR7khGrnfrhqTfVc51RKGZz6KdNQQ1gcqeW2Soe8uF5sI8AyBW58t+kpXQIPpPE0zjjGq8R+fQv871CwKF9zKy+F/eCf1fsWGROTuXAR8dA==;20:SCXhdiWzKCAqZb59oYiHeBV1yJxHF3zJl26/woB3qA+1bNWdIgULsKdPSXwugoFCSNMjoMuKE+1lJxliUBsF7CjfhXuyDx6elvV4PRv/b8K/AnFiL8i9y9RIAFmpigX23ne6gSKfdzwt7ss/w9RSn/+oMmES5w+9rU65MFWHj3k= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR11MB0306; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(158342451672863); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041072)(6043046);SRVR:BN3PR11MB0306;BCL:0;PCL:0;RULEID:;SRVR:BN3PR11MB0306; x-forefront-prvs: 0968D37274 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(24454002)(199003)(33656002)(86362001)(68736007)(8676002)(6116002)(105586002)(10400500002)(8936002)(36756003)(5001770100001)(2501003)(81166006)(102836003)(97736004)(189998001)(5004730100002)(5002640100001)(586003)(81156014)(2900100001)(2950100001)(92566002)(106116001)(3280700002)(19580395003)(5008740100001)(66066001)(106356001)(3660700001)(77096005)(101416001)(50986999)(54356999)(76176999)(82746002)(11100500001)(2201001)(87936001)(99286002)(3846002)(122556002)(83716003)(2906002)(4326007)(19580405001)(104396002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN3PR11MB0306;H:BN3PR11MB0305.namprd11.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-ID: MIME-Version: 1.0 X-OriginatorOrg: primarydata.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2016 19:23:49.0834 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR11MB0306 X-MC-Unique: n1VVhW_WQHW4flezGNjM1Q-1 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u59JO4al019655 On 6/9/16, 01:05, "Deepa Dinamani" wrote: >boot_time is represented as a struct timespec. >struct timespec and CURRENT_TIME are not y2038 safe. >Overall, the plan is to use timespec64 for all internal >kernel representation of timestamps. >CURRENT_TIME will also be removed. >Use struct timespec64 to represent boot_time. >And, ktime_get_real_ts64() for the boot_time value. > >boot_time is used to construct the nfs client boot verifier. >This will now wrap in 2106 instead of 2038 on 32-bit systems. >The server only relies on the value being persistent until >reboot so the wrapping should be fine. We really do not give a damn about wraparound here, since the boot time is only ever compared for an exact match, and the odds of two reboots occurring exactly 2^32 * 10^9 nanoseconds apart are cosmically small... If struct timespec is going away, can we just convert this into a ktime_t? Trond From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-194.mimecast.com ([216.205.24.194]:44118 "EHLO us-smtp-delivery-194.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750792AbcFITXz (ORCPT ); Thu, 9 Jun 2016 15:23:55 -0400 From: Trond Myklebust To: Deepa Dinamani , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" CC: Arnd Bergmann , Thomas Gleixner , "Al Viro" , Linus Torvalds , "y2038@lists.linaro.org" , Anna Schumaker , "linux-nfs@vger.kernel.org" Subject: Re: [PATCH 18/21] fs: nfs: Make nfs boot time y2038 safe Date: Thu, 9 Jun 2016 19:23:49 +0000 Message-ID: <89EF59F9-52D2-4F37-A7A8-52BD0FF7E98E@primarydata.com> References: <1465448705-25055-1-git-send-email-deepa.kernel@gmail.com> <1465448705-25055-19-git-send-email-deepa.kernel@gmail.com> In-Reply-To: <1465448705-25055-19-git-send-email-deepa.kernel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-nfs-owner@vger.kernel.org List-ID: DQoNCk9uIDYvOS8xNiwgMDE6MDUsICJEZWVwYSBEaW5hbWFuaSIgPGRlZXBhLmtlcm5lbEBnbWFp bC5jb20+IHdyb3RlOg0KDQo+Ym9vdF90aW1lIGlzIHJlcHJlc2VudGVkIGFzIGEgc3RydWN0IHRp bWVzcGVjLg0KPnN0cnVjdCB0aW1lc3BlYyBhbmQgQ1VSUkVOVF9USU1FIGFyZSBub3QgeTIwMzgg c2FmZS4NCj5PdmVyYWxsLCB0aGUgcGxhbiBpcyB0byB1c2UgdGltZXNwZWM2NCBmb3IgYWxsIGlu dGVybmFsDQo+a2VybmVsIHJlcHJlc2VudGF0aW9uIG9mIHRpbWVzdGFtcHMuDQo+Q1VSUkVOVF9U SU1FIHdpbGwgYWxzbyBiZSByZW1vdmVkLg0KPlVzZSBzdHJ1Y3QgdGltZXNwZWM2NCB0byByZXBy ZXNlbnQgYm9vdF90aW1lLg0KPkFuZCwga3RpbWVfZ2V0X3JlYWxfdHM2NCgpIGZvciB0aGUgYm9v dF90aW1lIHZhbHVlLg0KPg0KPmJvb3RfdGltZSBpcyB1c2VkIHRvIGNvbnN0cnVjdCB0aGUgbmZz IGNsaWVudCBib290IHZlcmlmaWVyLg0KPlRoaXMgd2lsbCBub3cgd3JhcCBpbiAyMTA2IGluc3Rl YWQgb2YgMjAzOCBvbiAzMi1iaXQgc3lzdGVtcy4NCj5UaGUgc2VydmVyIG9ubHkgcmVsaWVzIG9u IHRoZSB2YWx1ZSBiZWluZyBwZXJzaXN0ZW50IHVudGlsDQo+cmVib290IHNvIHRoZSB3cmFwcGlu ZyBzaG91bGQgYmUgZmluZS4NCg0KV2UgcmVhbGx5IGRvIG5vdCBnaXZlIGEgZGFtbiBhYm91dCB3 cmFwYXJvdW5kIGhlcmUsIHNpbmNlIHRoZSBib290IHRpbWUgaXMgb25seSBldmVyIGNvbXBhcmVk IGZvciBhbiBleGFjdCBtYXRjaCwgYW5kIHRoZSBvZGRzIG9mIHR3byByZWJvb3RzIG9jY3Vycmlu ZyBleGFjdGx5IDJeMzIgKiAxMF45IG5hbm9zZWNvbmRzIGFwYXJ0IGFyZSBjb3NtaWNhbGx5IHNt YWxsLi4uDQoNCklmIHN0cnVjdCB0aW1lc3BlYyBpcyBnb2luZyBhd2F5LCBjYW4gd2UganVzdCBj b252ZXJ0IHRoaXMgaW50byBhIGt0aW1lX3Q/DQoNClRyb25kDQoNCg==