From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Guo <jia.guo@intel.com>
Subject: Re: [PATCH v1 4/5] pci: add req handler field to generic
 pci device
Date: Sat, 29 Sep 2018 14:15:49 +0800
Message-ID: <89a8c22b-b96a-4b93-f457-2d5a2db01b87@intel.com>
References: <1534503091-31910-1-git-send-email-jia.guo@intel.com>
 <1534503091-31910-5-git-send-email-jia.guo@intel.com>
 <abd389ce-fee5-d809-2261-f52b5f2f3f60@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org,
 helin.zhang@intel.com
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 stephen@networkplumber.org, bruce.richardson@intel.com,
 ferruh.yigit@intel.com, konstantin.ananyev@intel.com,
 gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net,
 motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com,
 qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com,
 arybchenko@solarflare.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id C8E74239
 for <dev@dpdk.org>; Sat, 29 Sep 2018 08:15:56 +0200 (CEST)
In-Reply-To: <abd389ce-fee5-d809-2261-f52b5f2f3f60@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 9/26/2018 8:22 PM, Burakov, Anatoly wrote:
> On 17-Aug-18 11:51 AM, Jeff Guo wrote:
>> There are some extended interrupt types in vfio pci device except 
>> from the
>> existing interrupts, such as err and req notifier, it could be useful 
>> for
>> device error monitoring. And these corresponding interrupt handler is
>> different from the other interrupt handler that register in PMDs, so 
>> a new
>> interrupt handler should be added. This patch will add specific req 
>> handler
>> in generic pci device.
>>
>> Signed-off-by: Jeff Guo <jia.guo@intel.com>
>> ---
>>   drivers/bus/pci/rte_bus_pci.h | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/bus/pci/rte_bus_pci.h 
>> b/drivers/bus/pci/rte_bus_pci.h
>> index 0d1955f..c45a820 100644
>> --- a/drivers/bus/pci/rte_bus_pci.h
>> +++ b/drivers/bus/pci/rte_bus_pci.h
>> @@ -66,6 +66,7 @@ struct rte_pci_device {
>>       uint16_t max_vfs;                   /**< sriov enable if not 
>> zero */
>>       enum rte_kernel_driver kdrv;        /**< Kernel driver 
>> passthrough */
>>       char name[PCI_PRI_STR_SIZE+1];      /**< PCI location (ASCII) */
>> +    struct rte_intr_handle req_notifier_handler;/**< Req notifier 
>> handle */
>>   };
>>     /**
>>
>
> Does this break ABI?
>

If add a variable in struct would break ABI, it does.