Re: [OE-core] Merge meta-rust to oe-core

["Randy MacLeod" <randy.macleod@windriver.com>]

On 2021-02-24 4:39 a.m., Richard Purdie wrote:
> On Tue, 2021-02-23 at 22:01 -0500, Randy MacLeod wrote:
>> Clean-up the merge of meta-rust to oe-core by squashing most of the
>> meta-rust history so we are left with:
>>
>>    35da4b252f rust: add a language demo image to test reproducibility
>>    088374371b cargo/rust/rustfmt: exclude from world
>>    7df10d2a22 meta-rust: merge commits
>>    4187796cd6 rust: mv README.md to recipes-devtools/rust/README-rust.md
>>    03b9c60ef4 meta-rust: move code to oe-core from meta-rust layer
>>    2c62874204 libgit2: pull in updates from meta-oe
>>    24cb3db88c libssh2: pull in additional commits from meta-oe
>>    e9a0a3bad2 Add libgit2, libssh2 from meta-oe for rust
>>
>> The full diffstat is below. (1)
>>
>> I didn't really notice the scripts shown below since they are mostly harmless.
>> I'll review them and remove them in v2 if they don't make sense for oe-core.
> 
> This is better, thanks. My feedback from a quick glance:

Thanks for the comments.

> 
> a) Need maintainer entries for the new recipes

Fixed by adding myself but making it clear that other maintainers
are welcome. Once libssh/libgit2 are in master, I'll do the same for
them since they are unassigned in master-next.

> b) The scripts in scripts/ look at the very least inappropriately named
>     for OE-Core, I suspect we don't want/need those.

Working on that next (after 2 more meetings...).

> c) Not entirely sure about the languages demo image, its not how we test
>     any other language

Removed.

> d) There aren't any tests in meta/lib/oeqa!

To come. Is:
   meta/lib/oeqa/selftest/cases/gotoolchain.py
a good first step as I mentioned earlier?

> e) The rust README starts "This OpenEmbedded layer provides" and has a few other
>     issues.

Fixed.



To Do List
==========

1) cargo-bitbake - the README suggest adding this using desktop
    cargo but once we get the SDK merged, it should be added there.
    Someone suggested using devtool for this rather than cargo-bitbake.

2) Fix the SDK libcrypto, libstdc++ glibc-2.33 problem. I'm running a
git bisect using poky, meta-oe/master, meta-rust+SDK patches.

N) Remaining bugs in:

---



Would it be worth adding this to master-next in the next few days
to confirm that rust-hello-world builds for all the supported machines?
I suspect that will work but I've mostly used Ubuntu so it'd be good
to get some coverage testing.


-- 
# Randy MacLeod
# Wind River Linux