From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=LmQJ=ZU=huawei.com=liudongdong3@kernel.org>
Return-Path: <SRS0=LmQJ=ZU=huawei.com=liudongdong3@kernel.org>
Subject: Re: [PATCH V3] PCI:hisi: Add DT almost ECAM support for HiSilicon
 Hip06/Hip07 host controllers
To: Bjorn Helgaas <helgaas@kernel.org>
References: <1486362304-56261-1-git-send-email-liudongdong3@huawei.com>
 <20170206224041.GB27899@bhelgaas-glaptop.roam.corp.google.com>
CC: <linux-pci@vger.kernel.org>, <wangzhou1@hisilicon.com>,
        <gabriele.paoloni@huawei.com>, <charles.chenxin@huawei.com>,
        <linuxarm@huawei.com>
From: Dongdong Liu <liudongdong3@huawei.com>
Message-ID: <89c7b769-f410-1526-b147-b3361b4fa9d7@huawei.com>
Date: Tue, 7 Feb 2017 09:34:43 +0800
MIME-Version: 1.0
In-Reply-To: <20170206224041.GB27899@bhelgaas-glaptop.roam.corp.google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
List-ID: <linux-pci.vger.kernel.org>

Hi Bjorn

在 2017/2/7 6:40, Bjorn Helgaas 写道:
> On Mon, Feb 06, 2017 at 02:25:04PM +0800, Dongdong Liu wrote:
>> The PCIe controller in Hip06/Hip07 SoCs is not completely
>> ECAM-compliant. It is non-ECAM only for the RC bus config space; for
>> any other bus underneath the root bus it does support ECAM access.
>> This is to add the almost ECAM support in DT way.
>>
>> Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
>> Reviewed-by: Gabriele Paoloni <gabriele.paoloni@huawei.com>
>> Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com>
>
> Applied to pci/host-hisi for v4.11, thanks!

Thanks for applying this patch.

>
>> -#if defined(CONFIG_ACPI) && defined(CONFIG_PCI_QUIRKS)
>> +#if defined(CONFIG_PCI_HISI) || (defined(CONFIG_ACPI) && defined(CONFIG_PCI_QUIRKS))
>>
>>  static int hisi_pcie_acpi_rd_conf(struct pci_bus *bus, u32 devfn, int where,
>>  				  int size, u32 *val)
>
> These "_acpi_" accessors are now used for both the ACPI and the DT
> model, and the accessors aren't ACPI-specific anyway.  So these are
> slight misnomers.

Yes, It is better to change hisi_pcie_acpi_rd_conf()/ hisi_pcie_acpi_wr_conf() to hisi_pcie_rd_conf()/hisi_pcie_wr_conf().

>
>> +static int hisi_pcie_platform_init(struct pci_config_window *cfg)
>> +{
>> +	struct device *dev = cfg->parent;
>> +	struct platform_device *pdev = to_platform_device(dev);
>> +	struct resource *res;
>> +	void __iomem *reg_base;
>> +
>> +	if (!dev->of_node)
>> +		return -EINVAL;
>
> What's the point of testing dev->of_node here?  There's no obvious
> dependency on of_node in this code.  Could we just drop this test?

Yes, only DT driver will call this function, we should drop this test.
Thanks for pointing this.

Thanks,
Dongdong
>
>> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
>> +	if (!res) {
>> +		dev_err(dev, "missing \"reg[1]\"property\n");
>> +		return -EINVAL;
>> +	}
>> +
>> +	reg_base = devm_ioremap(dev, res->start, resource_size(res));
>> +	if (!reg_base)
>> +		return -ENOMEM;
>> +
>> +	cfg->priv = reg_base;
>> +	return 0;
>> +}
>
> .
>