From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lakshmi Ramasubramanian Date: Wed, 23 Oct 2019 17:34:59 +0000 Subject: Re: [PATCH v1 5/6] KEYS: measure queued keys Message-Id: <89d778d1-1ac9-4a58-b159-7db68b7fa4ad@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit List-Id: References: <20191023001818.3684-1-nramas@linux.microsoft.com> <20191023001818.3684-6-nramas@linux.microsoft.com> <1571836990.5104.96.camel@linux.ibm.com> In-Reply-To: <1571836990.5104.96.camel@linux.ibm.com> To: Mimi Zohar , dhowells@redhat.com, casey@schaufler-ca.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org On 10/23/19 6:23 AM, Mimi Zohar wrote: > The ordering of this patch set is awkward.  It should first introduce > a generic method for measuring keys based on the keyring.  Then add > the additional support needed for the specific builtin_trusted_keys > keyring usecase. Would the following ordering of the patch set be acceptable: => PATCH 0/5: Cover letter => PATCH 1/5: Define the enum "hook(BUILTIN_TRUSTED_KEYS)" in ima.h => PATCH 2/5: Define ima hook This will initially do nothing if ima is not yet initialized. Call process_buffer_measurement() if ima is initialized. => PATCH 3/5: key_create_or_update change and the call to ima hook => PATCH 4/5: Queue\De-Queue of key measurement requests. Enable queuing of key in the ima hook if ima is not initialized. => PATCH 5/5: ima policy to enable measurement of keys which will enable end-to-end working of this feature. thanks, -lakshmi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E98F7CA9EB7 for ; Wed, 23 Oct 2019 17:35:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C2DC921906 for ; Wed, 23 Oct 2019 17:35:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="j6z1WeOb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730519AbfJWRfA (ORCPT ); Wed, 23 Oct 2019 13:35:00 -0400 Received: from linux.microsoft.com ([13.77.154.182]:39150 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730302AbfJWRfA (ORCPT ); Wed, 23 Oct 2019 13:35:00 -0400 Received: from [10.137.112.108] (unknown [131.107.174.108]) by linux.microsoft.com (Postfix) with ESMTPSA id 77F5220106BE; Wed, 23 Oct 2019 10:34:59 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 77F5220106BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1571852099; bh=vqQGCbajvg6tqXYaZDPRkvd/epy9EBlB+JVvTXS6jQA=; h=Subject:To:References:From:Date:In-Reply-To:From; b=j6z1WeObOALb27C7iDRzG4wPZqcwVGNUh1P4LtXHp+HGbkTypLgpORQIJ23yZaCQJ J7iqhkI5q75gg/uB+y/fKJBye0NhlgHGemY+oZRf0sL2UZSejk617HCbed5imFn7zr 95TU5QubcPetP850MWP2G5mo2BOsafnXV2fwsF6A= Subject: Re: [PATCH v1 5/6] KEYS: measure queued keys To: Mimi Zohar , dhowells@redhat.com, casey@schaufler-ca.com, sashal@kernel.org, jamorris@linux.microsoft.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, keyrings@vger.kernel.org References: <20191023001818.3684-1-nramas@linux.microsoft.com> <20191023001818.3684-6-nramas@linux.microsoft.com> <1571836990.5104.96.camel@linux.ibm.com> From: Lakshmi Ramasubramanian Message-ID: <89d778d1-1ac9-4a58-b159-7db68b7fa4ad@linux.microsoft.com> Date: Wed, 23 Oct 2019 10:34:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1571836990.5104.96.camel@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/23/19 6:23 AM, Mimi Zohar wrote: > The ordering of this patch set is awkward.  It should first introduce > a generic method for measuring keys based on the keyring.  Then add > the additional support needed for the specific builtin_trusted_keys > keyring usecase. Would the following ordering of the patch set be acceptable: => PATCH 0/5: Cover letter => PATCH 1/5: Define the enum "hook(BUILTIN_TRUSTED_KEYS)" in ima.h => PATCH 2/5: Define ima hook This will initially do nothing if ima is not yet initialized. Call process_buffer_measurement() if ima is initialized. => PATCH 3/5: key_create_or_update change and the call to ima hook => PATCH 4/5: Queue\De-Queue of key measurement requests. Enable queuing of key in the ima hook if ima is not initialized. => PATCH 5/5: ima policy to enable measurement of keys which will enable end-to-end working of this feature. thanks, -lakshmi