Re: [Buildroot] [PATCH 1/1] package/mesa3d: don't disable DRI3 for some Gallium drivers

[Michael Taubert <info@arachnodroid.de>]

Hi!

I've applied the patch to the latest origin/master. One hunk has been 
rejected:

--- package/mesa3d/Config.in
+++ package/mesa3d/Config.in
@@ -70,6 +75,8 @@  config BR2_PACKAGE_MESA3D_DRI_DRIVER
                 !BR2_PACKAGE_MESA3D_OPENGL_GLX && \
                 !BR2_PACKAGE_MESA3D_OPENGL_EGL && \
                 !BR2_PACKAGE_MESA3D_OSMESA_GALLIUM
+       select BR2_PACKAGE_MESA3D_DRI3 if \
+               (BR2_PACKAGE_XORG7 && BR2_TOOLCHAIN_HAS_SYNC_4)
         select BR2_PACKAGE_XLIB_LIBXSHMFENCE if \
                 (BR2_PACKAGE_XORG7 && BR2_TOOLCHAIN_HAS_SYNC_4)

But it looks good for me anyway. I've tried by using 
raspberrypi_64_defconfig and only enabled mesa3d with Gallium drivers 
for V3D and VC4.

According to the build log, it has been compiled with DRI3 support.

Regards,
Michael

Am 12/16/21 um 7:33 PM schrieb Arnout Vandecappelle:
> 
> 
> On 16/12/2021 19:12, Bernd Kuhls wrote:
>> Am Thu, 16 Dec 2021 18:28:56 +0100 schrieb Arnout Vandecappelle:
>>
>>>    Bernd, can you comment?
>>
>> Hi Arnout,
>>
>> no, because I do not use buildroot on rbpi hardware.
>>
>> But the topic was already discussed this summer, with no solution afaics:
>> https://patchwork.ozlabs.org/project/buildroot/list/?
>> series=248555&submitter=&state=*&q=&archive=&delegate=
> 
>   Good find, thanks!
> 
>   Michael, can you try that patch [1] and see if it works for you?
> 
>   Peter, I think I'm just going to apply []] except that I'll make 
> BR2_PACKAGE_MESA3D_DRI3 a blind option (i.e. not user visible, only 
> selected automatically by the drivers, much like BR2_PACKAGE_MESA3D_DRI).
> 
>   My other major comment about that patch was that I suspected that it 
> would need some 'select' statements, but I guess the autobuilders will 
> inform us of that, so we can go ahead and merge it.
> 
>   Does that sound OK to you?
> 
>   Regards,
>   Arnout
> 
> 
> [1] 
> https://patchwork.ozlabs.org/project/buildroot/patch/20210612223011.26118-1-ps.report@gmx.net/ 
> 
> 
> 
>>
>> Regards, Bernd
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
>>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot