All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Herbelot <thierry.herbelot@6wind.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org
Cc: akhil.goyal@nxp.com
Subject: Re: [dpdk-dev] [PATCH] test/crypto: fix compilation issue without security
Date: Fri, 18 Oct 2019 10:07:14 +0200	[thread overview]
Message-ID: <89e20661-e08c-09a6-4c84-971da2ea6b33@6wind.com> (raw)
In-Reply-To: <20191018075613.2784-1-hemant.agrawal@nxp.com>

On 10/18/19 9:56 AM, Hemant Agrawal wrote:
> This patch fixes the compilation issue in test_cryptodev.c
> when RTE_LIBRTE_SECURITY is disabled.
> Fixes: d883e6e7131b ("test/crypto: add PDCP C-Plane encap cases")
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>   app/test/test_cryptodev.c | 9 ++++++++-
>   1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index 65d80837a..c4d593f34 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -71,9 +71,13 @@ struct crypto_unittest_params {
>   
>   	union {
>   		struct rte_cryptodev_sym_session *sess;
> +#ifdef RTE_LIBRTE_SECURITY
>   		struct rte_security_session *sec_session;
> +#endif
>   	};
> +#ifdef RTE_LIBRTE_SECURITY
>   	enum rte_security_session_action_type type;
> +#endif
>   	struct rte_crypto_op *op;
>   
>   	struct rte_mbuf *obuf, *ibuf;
> @@ -573,6 +577,7 @@ ut_teardown(void)
>   	struct rte_cryptodev_stats stats;
>   
>   	/* free crypto session structure */
> +#ifdef RTE_LIBRTE_SECURITY
>   	if (ut_params->type == RTE_SECURITY_ACTION_TYPE_LOOKASIDE_PROTOCOL) {
>   		if (ut_params->sec_session) {
>   			rte_security_session_destroy(rte_cryptodev_get_sec_ctx
> @@ -580,7 +585,9 @@ ut_teardown(void)
>   						ut_params->sec_session);
>   			ut_params->sec_session = NULL;
>   		}
> -	} else {
> +	} else
> +#endif
> +	{
>   		if (ut_params->sess) {
>   			rte_cryptodev_sym_session_clear(
>   					ts_params->valid_devs[0],
> 

Acked-by: Thierry Herbelot <thierry.herbelot@6wind.com>

-- 
Thierry Herbelot
6WIND
Senior Software Engineer

  parent reply	other threads:[~2019-10-18  8:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18  7:56 [dpdk-dev] [PATCH] test/crypto: fix compilation issue without security Hemant Agrawal
2019-10-18  7:56 ` [dpdk-dev] [PATCH] app/proc-info: fix compilation with no security Hemant Agrawal
2019-10-18  8:09   ` Thierry Herbelot
2019-10-23 14:46     ` Akhil Goyal
2019-10-23 14:48     ` Akhil Goyal
2019-10-18  7:56 ` [dpdk-dev] [PATCH] crypto/dpaa_sec: enable compilation without security Hemant Agrawal
2019-10-18  8:11   ` Thierry Herbelot
2019-10-23 14:45   ` Akhil Goyal
2019-10-18  8:07 ` Thierry Herbelot [this message]
2019-10-23 14:48   ` [dpdk-dev] [PATCH] test/crypto: fix compilation issue " Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=89e20661-e08c-09a6-4c84-971da2ea6b33@6wind.com \
    --to=thierry.herbelot@6wind.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.