From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751656AbdKVDmK (ORCPT ); Tue, 21 Nov 2017 22:42:10 -0500 Received: from [134.134.136.24] ([134.134.136.24]:12485 "EHLO mga09.intel.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751605AbdKVDmI (ORCPT ); Tue, 21 Nov 2017 22:42:08 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,435,1505804400"; d="scan'208";a="4597339" Subject: Re: [PATCH v1 8/9] perf stat: Remove --per-thread pid/tid limitation To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1511189024-19908-1-git-send-email-yao.jin@linux.intel.com> <1511189024-19908-9-git-send-email-yao.jin@linux.intel.com> <20171121151814.GK20440@krava> From: "Jin, Yao" Message-ID: <89ea1f20-003e-59dc-1666-a2b74206c08e@linux.intel.com> Date: Wed, 22 Nov 2017 11:42:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171121151814.GK20440@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/21/2017 11:18 PM, Jiri Olsa wrote: > On Mon, Nov 20, 2017 at 10:43:43PM +0800, Jin Yao wrote: > > SNIP > >> - if ((stat_config.aggr_mode == AGGR_THREAD) && !target__has_task(&target)) { >> - fprintf(stderr, "The --per-thread option is only available " >> - "when monitoring via -p -t options.\n"); >> - parse_options_usage(NULL, stat_options, "p", 1); >> - parse_options_usage(NULL, stat_options, "t", 1); >> - goto out; >> + if ((stat_config.aggr_mode == AGGR_THREAD) && >> + !target__has_task(&target)) { >> + if (!target.system_wide || target.cpu_list) { >> + fprintf(stderr, "The --per-thread option is only " >> + "available when monitoring via -p -t " >> + "options.\n"); > > the message should be updated with '-a' option, that you just added, OK. Could I update the message like this? "The --per-thread option is only " "available when monitoring via -p -t -a" "options or only --per-thread without any other option" > also why dont we support target.cpu_list, it should work no? > Currently it doesn't support cpu_list. I just think this patch series is too big and I wish to add supporting for cpu_list, cgroup or others in follow up patches. Is that OK? Thanks Jin Yao > jirka >