From: Damien Le Moal <damien.lemoal@opensource.wdc.com>
To: Jens Axboe <axboe@kernel.dk>, Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the block tree
Date: Tue, 29 Nov 2022 11:50:51 +0900 [thread overview]
Message-ID: <89f5e3a2-1cf7-8b9e-f3b9-af0fe4f72c60@opensource.wdc.com> (raw)
In-Reply-To: <c03be0eb-1c4c-b8c9-8325-c7769b966ddf@kernel.dk>
On 11/29/22 11:30, Jens Axboe wrote:
> On 11/28/22 4:39?PM, Damien Le Moal wrote:
>> On 11/29/22 06:27, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> In commit
>>>
>>> 4b49197f9fbd ("block: mq-deadline: Rename deadline_is_seq_writes()")
>>>
>>> Fixes tag
>>>
>>> Fixes: 015d02f4853 ("block: mq-deadline: Do not break sequential write streams to zoned HDDs")
>>>
>>> has these problem(s):
>>>
>>> - SHA1 should be at least 12 digits long
>>> This can be fixed for the future by setting core.abbrev to 12 (or
>>> more) or (for git v2.11 or later) just making sure it is not set
>>> (or set to "auto").
>>
>> Oops. Sorry about that. It seems I cannot count up to 12 anymore :)
>> It should be:
>>
>> Fixes: 015d02f48537 ("block: mq-deadline: Do not break sequential write
>> streams to zoned HDDs")
>>
>> Jens, can you fix this ?
>
> Sure, it's not that important though as it's just missing one digit. For
> the record, this is what I have in my .gitconfig :
>
> [alias]
> fixes = log -1 --format=fixes
>
> [pretty]
> fixes = Fixes: %h (\"%s\")
>
> [core]
> abbrev = 12
>
> and then you just do 'git fixes <sha>' and it spits out the line for the
> commit without needing to count anything and eliminates this error.
Thanks for the info. Will try this !
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2022-11-29 2:51 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 21:27 linux-next: Fixes tag needs some work in the block tree Stephen Rothwell
2022-11-28 23:39 ` Damien Le Moal
2022-11-29 2:30 ` Jens Axboe
2022-11-29 2:50 ` Damien Le Moal [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-22 21:51 Stephen Rothwell
2023-08-14 23:19 Stephen Rothwell
2023-08-15 3:21 ` Yu Kuai
2023-08-15 15:08 ` Jens Axboe
2023-08-15 15:58 ` Song Liu
2023-08-15 16:07 ` Jens Axboe
2023-08-15 16:17 ` Song Liu
2023-08-15 16:20 ` Jens Axboe
2023-08-15 16:26 ` Song Liu
2023-08-15 16:31 ` Jens Axboe
2023-08-15 16:51 ` Song Liu
2023-08-15 16:59 ` Jens Axboe
2023-06-18 22:22 Stephen Rothwell
2023-06-20 5:41 ` Chaitanya Kulkarni
2023-06-13 22:33 Stephen Rothwell
2023-03-20 21:28 Stephen Rothwell
2023-03-20 21:30 ` Jens Axboe
2022-07-27 22:06 Stephen Rothwell
2022-06-22 23:21 Stephen Rothwell
2022-06-22 23:44 ` Jens Axboe
2022-06-23 8:11 ` Dylan Yudaken
2022-04-28 1:44 Stephen Rothwell
2022-03-28 21:02 Stephen Rothwell
2022-03-22 20:49 Stephen Rothwell
2022-03-23 1:45 ` Jens Axboe
2022-01-03 21:25 Stephen Rothwell
2021-10-19 21:46 Stephen Rothwell
2021-08-22 3:24 Stephen Rothwell
2021-05-18 22:01 Stephen Rothwell
2021-05-19 19:25 ` Sergey Shtylyov
2021-05-19 21:55 ` Jens Axboe
2021-05-05 22:23 Stephen Rothwell
2021-05-09 1:49 ` Minwoo Im
2021-03-04 23:52 Stephen Rothwell
2021-03-05 0:26 ` Jens Axboe
2021-03-05 7:46 ` Christoph Hellwig
2021-03-05 15:53 ` Jens Axboe
2021-02-22 21:01 Stephen Rothwell
2021-02-22 21:15 ` Chaitanya Kulkarni
2021-02-20 4:51 Stephen Rothwell
2021-02-20 4:57 ` Jens Axboe
2021-02-04 20:13 Stephen Rothwell
2021-01-25 9:40 Stephen Rothwell
2021-01-25 18:35 ` Paolo Valente
2021-01-25 18:39 ` Jens Axboe
2021-01-26 13:29 ` Jan Kara
2021-01-26 15:47 ` Jens Axboe
2021-01-26 16:01 ` Jan Kara
2021-01-26 16:05 ` Jens Axboe
2020-12-17 20:38 Stephen Rothwell
2020-12-17 20:42 ` Jens Axboe
2020-12-01 21:02 Stephen Rothwell
2020-12-01 21:09 ` Jens Axboe
2020-12-01 21:44 ` Stephen Rothwell
2020-12-01 21:52 ` Jens Axboe
2020-11-30 21:28 Stephen Rothwell
2020-09-24 22:38 Stephen Rothwell
2020-07-29 22:08 Stephen Rothwell
2020-07-29 22:12 ` Stephen Rothwell
2020-07-30 15:04 ` Jens Axboe
2020-06-28 22:05 Stephen Rothwell
2020-06-29 16:21 ` Pavel Begunkov
2020-06-29 16:25 ` Jens Axboe
2020-06-29 22:36 ` Stephen Rothwell
2020-06-29 22:45 ` Jens Axboe
2020-06-26 23:07 Stephen Rothwell
2020-06-27 1:32 ` Jens Axboe
2020-06-27 1:56 ` Konstantin Ryabitsev
2020-06-27 2:25 ` Jens Axboe
2020-06-27 5:12 ` Stephen Rothwell
2020-06-28 13:38 ` Jens Axboe
2020-06-27 5:01 ` Stephen Rothwell
2020-06-27 11:18 ` Pavel Begunkov
2020-05-28 21:10 Stephen Rothwell
2020-03-22 14:08 Stephen Rothwell
2019-10-24 6:16 Stephen Rothwell
2019-10-07 20:16 Stephen Rothwell
2019-10-10 17:36 ` Bart Van Assche
2019-10-11 0:42 ` Stephen Rothwell
2019-09-10 14:57 Stephen Rothwell
2019-07-11 21:35 Stephen Rothwell
2019-07-11 22:03 ` Jens Axboe
2019-07-12 8:47 ` Minwoo Im
2019-02-21 20:39 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89f5e3a2-1cf7-8b9e-f3b9-af0fe4f72c60@opensource.wdc.com \
--to=damien.lemoal@opensource.wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.