From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25782C433EF for ; Sat, 13 Nov 2021 11:13:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3951F61026 for ; Sat, 13 Nov 2021 11:13:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3951F61026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C403E83100; Sat, 13 Nov 2021 12:13:44 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=gmx.net header.i=@gmx.net header.b="K5cgE5sI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9B1858302B; Sat, 13 Nov 2021 12:13:43 +0100 (CET) Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 520758302B for ; Sat, 13 Nov 2021 12:13:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1636802019; bh=si8LmIuLFKDUh4KhYWV6b2+kycmgsIeOrBgMvyMruhE=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=K5cgE5sImx1dVgTvqCERz+rF7QLF7Eutuo+QrsQ8KqIg7O/lFAfNi/sp3Rjiy7GvU xbk2zUxeBk+tGZqOAGnqWAX71IIA1XAfbUlulMYt8anbdrBMVxdChRWDYXae7r/98D gPG6riznve7KIzq+xGtVZHhGx00qhhuWxitsv5EA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([88.152.144.157]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MxUrx-1mW5DW1qGn-00xu0x; Sat, 13 Nov 2021 12:13:39 +0100 Message-ID: <89fdf34f-5403-ac21-1c78-ed4d766d648e@gmx.de> Date: Sat, 13 Nov 2021 12:13:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v4 1/5] command: Use a constant pointer for the help Content-Language: en-US To: Simon Glass , U-Boot Mailing List Cc: Jagan Teki References: <20210919214937.3829422-1-sjg@chromium.org> <20210919214937.3829422-2-sjg@chromium.org> From: Heinrich Schuchardt In-Reply-To: <20210919214937.3829422-2-sjg@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:bDehR8A7Fv1BSEa2GBXH3ksjvoXWVLTOgPikC0oPmGgJ/j4YIMW 5MblRs/NT2JEfC/KEel5qifJtaPF5d5DI+z8bhO4MVZnATb8AMt9jh9AvNnoL78rnmRgVqY hyC0ZHfAxrq8H+jfu35CL44Eatk7U9n//7At34ViMTu4svCqJdPj4RYAA7vm70rROHY8UQu aUGTjz9+16ebV9RM0dZGA== X-UI-Out-Filterresults: notjunk:1;V03:K0:p5YcnYFO+vA=:vxIumjCNGVQs9t7HZzEUTz GVedvqAzY0Xa3OR0PKbyywn/RzLCBFxp2BsBJJth79dWD65oFxVhBtf7e72btqGhLSs93owFJ GUTjFKvpjBUFk3GHjOdwMJXylLYk1uH0mBwANPovPWWXaP5ciVRWPo9HaEDOC/Qrn0Lk/YnIB udMSUWRUC/DLnwQSexDH16N8H0/zT5d4lBIK+y19k9YKnkVomIbWSqfi+L/r1kK3N6Efo6ZFy 9UIvoAJchCZrKZojoc2qKfd+Gscvs7oIbjG4HFQTkQOO3WeD8Pn8eQOx6fH4bACz2pVQJQg1D 1NgvhuX2IQ2xJtt4JcliEN17wVcwE6SEFWb5e8D1iKMRwA/mvoU9rLMzlr6//fgU5VoVNRWkq Q6RD0FOMzFjbv4gY2PYVx1tIl+32C6bgwVjIXehLYloJZr3GVQzyk1ZIRp4OQnjvULEFwRNqT WJKd1fEcnPlBQCzuYCUr2omNR1cRNChiCeSEVA7xxgWMQA3CAAtTVL5ggcIYTx2+DqnbPuBPZ 4OA7tOTIqA67fOv+Gj/7edBtW1juOSIPEePlQOoUkIzUMqQ4G/DzP6WUisAttiX3BOHBtZViF rYtYkAL0Ng6LOBMrVxs5ob0a2oRFnMA+Ds8Ic6ffx6tPqWkF4bk5F57WLocNaao8NkFSSKdhl RgT6aSH1Ut9Fu7Frl6hgPJNBZtwJwGGFQ41L3H6v4FOciFoDdr5w33bwktgQFcYu82QT39BCO a+DYzWNblk+Zk42zMS4HH5gPQxxEx5dgB4PCrTZ6HPUmV1nP8CfTHmD91VCgIvfv1V+Rcs1Ng x/Vl8osVDBJg021NrT74ewheYiy9mW6cHmPMGyZFFM5SEf0f4xAEPvapdPUpWQgcR58YOEvfl SmvQ1ib0yYBhLgIevMd5OWhIMfA8LgOfm8dU/RYDiwPUeSB51o5cGdF8FYAUy3aC7nC186Gzl TWOsT6mWgFgasTlX/rDIwZfKugbb5Sd+L8i3Msy56kuYWoaDfRkz2TKAIz5wier0/IMNxqiZA tIjap3u5knRhZYBSUXZcvGaF4Hrj1bX3w0SaUPD3W8H7VVIkGMvIk+tWmTCkLg8XXO59QY22m GAk/6X5Z+CWC3I= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 9/19/21 23:49, Simon Glass wrote: > This text should never change during execution, so it makes sense to > use a const char * so that it can be declared as const in the code. > Update struct cmd_tbl with a const char * pointer for 'help'. > > We cannot make usage const because of the bmode command, used on mx53ppd > for example. > > Signed-off-by: Simon Glass Reviewed-by: Heinrich Schuchardt > --- > > (no changes since v2) > > Changes in v2: > - Explain why 'usage' cannot be const > > include/command.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/command.h b/include/command.h > index 137cfbc3231..f8e07a591c6 100644 > --- a/include/command.h > +++ b/include/command.h > @@ -45,7 +45,7 @@ struct cmd_tbl { > char *const argv[]); > char *usage; /* Usage message (short) */ > #ifdef CONFIG_SYS_LONGHELP > - char *help; /* Help message (long) */ > + const char *help; /* Help message (long) */ > #endif > #ifdef CONFIG_AUTO_COMPLETE > /* do auto completion on the arguments */ >