From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 1/2] drm/i915: Include a generation number in the device info Date: Wed, 11 Aug 2010 15:29:30 +0100 Message-ID: <89kc63$hng7pc@fmsmga002.fm.intel.com> References: <20100810143753.2c6f6f8e@virtuousgeek.org> <1281518747-5085-1-git-send-email-chris@chris-wilson.co.uk> <1281536084.17843.3056.camel@atropine> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 936969F036 for ; Wed, 11 Aug 2010 07:29:33 -0700 (PDT) In-Reply-To: <1281536084.17843.3056.camel@atropine> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Adam Jackson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, 11 Aug 2010 10:14:44 -0400, Adam Jackson wrote: > On Wed, 2010-08-11 at 10:25 +0100, Chris Wilson wrote: > > To simplify the IS_GEN[234] macros and to enable switching. > > I think your three cent titanium tax doesn't go too far enough. > > 830, 845g, 85x, and 865 all now have > > .gen = 2, > .is_i8xx = 1, > > and nothing later has .is_i8xx, so that field can just go. Yes. I was just worried about some subtle semantic difference between is_i8xx and is_i9xx and the generation number. I still look at IS_I965G() and shudder. So for the first patch, I wanted something obvious and simple that gave me the ability to switch(INTEL_INFO(dev)->gen). I'd like to replace some of the coarse is_i9xx with more fine-grained capability bits that are more self-descriptive and clear when they can be relied upon. -- Chris Wilson, Intel Open Source Technology Centre