From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yong Wang Subject: Re: [PATCH 3/3] vmxnet3: fix vlan_offload_set Date: Wed, 9 Dec 2015 20:38:19 +0000 Message-ID: <8A29F787-C54E-4275-B1E3-C634BE9F45BF@vmware.com> References: <1449191107-14222-1-git-send-email-stephen@networkplumber.org> <1449191107-14222-4-git-send-email-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "dev@dpdk.org" , Nachiketa Prachanda To: Stephen Hemminger Return-path: Received: from smtp-outbound-2.vmware.com (smtp-outbound-2.vmware.com [208.91.2.13]) by dpdk.org (Postfix) with ESMTP id C22E15A4D for ; Wed, 9 Dec 2015 21:38:22 +0100 (CET) In-Reply-To: <1449191107-14222-4-git-send-email-stephen@networkplumber.org> Content-Language: en-US Content-ID: <3140FDA5FCF36E429E0D2A2236E2EF16@pa-exch1.vmware.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" T24gMTIvMy8xNSwgNTowNSBQTSwgIlN0ZXBoZW4gSGVtbWluZ2VyIiA8c3RlcGhlbkBuZXR3b3Jr cGx1bWJlci5vcmc+IHdyb3RlOg0KDQoNCj5Gcm9tOiBOYWNoaWtldGEgUHJhY2hhbmRhIDxucHJh Y2hhbkBicm9jYWRlLmNvbT4NCj4NCj52bXhuZXQzX2Rldl92bGFuX29mZmxvYWRfc2V0KGRldiwg bWFzaykgd2FzIGluY29ycmVjdGx5IHRyZWF0aW5nIHRoZQ0KPm1hc2sgcGFyYW1ldGVyIGFzIHRo ZSBiaXRtYXNrIGZvciB2bGFuX3N0cmlwIGFuZCB2bGFuX2ZpbHRlciwgd2hlcmVhcw0KPnRoZSBt YXNrIGluZGljYXRlcyBvbmx5IHdoYXQgaGFzIGNoYW5nZWQgLSB0aGUgdmFsdWVzIGZvcg0KPnZs YW5fc3RyaXBwaW5nIGFuZCB2bGFuX2ZpbHRlciBuZWVkcyB0byBiZSB0YWtlbiBmcm9tIGRldl9j b25mLnJ4bW9kZS4NCj4NCj5TaWduZWQtb2ZmLWJ5OiBOYWNoaWtldGEgUHJhY2hhbmRhIDxucHJh Y2hhbkBicm9jYWRlLmNvbT4NCj5TaWduZWQtb2ZmLWJ5OiBTdGVwaGVuIEhlbW1pbmdlciA8c3Rl cGhlbkBuZXR3b3JrcGx1bWJlci5vcmc+DQo+LS0tDQo+IGRyaXZlcnMvbmV0L3ZteG5ldDMvdm14 bmV0M19ldGhkZXYuYyB8IDQ1ICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQ0K PiAxIGZpbGUgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pDQo+DQo+ ZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3ZteG5ldDMvdm14bmV0M19ldGhkZXYuYyBiL2RyaXZl cnMvbmV0L3ZteG5ldDMvdm14bmV0M19ldGhkZXYuYw0KPmluZGV4IDJkN2JmMTMuLjQwYzQ1Mzcg MTAwNjQ0DQo+LS0tIGEvZHJpdmVycy9uZXQvdm14bmV0My92bXhuZXQzX2V0aGRldi5jDQo+Kysr IGIvZHJpdmVycy9uZXQvdm14bmV0My92bXhuZXQzX2V0aGRldi5jDQo+QEAgLTkwLDcgKzkwLDcg QEAgc3RhdGljIGludCB2bXhuZXQzX2Rldl92bGFuX2ZpbHRlcl9zZXQoc3RydWN0IHJ0ZV9ldGhf ZGV2ICpkZXYsDQo+IAkJCQkgICAgICAgdWludDE2X3QgdmlkLCBpbnQgb24pOw0KPiBzdGF0aWMg dm9pZCB2bXhuZXQzX2Rldl92bGFuX29mZmxvYWRfc2V0KHN0cnVjdCBydGVfZXRoX2RldiAqZGV2 LCBpbnQgbWFzayk7DQo+IHN0YXRpYyB2b2lkIHZteG5ldDNfZGV2X3ZsYW5fb2ZmbG9hZF91cGRh dGUoc3RydWN0IHJ0ZV9ldGhfZGV2ICpkZXYsDQo+LQkJCQkJICAgIGludCBtYXNrKTsNCj4rCQkJ CQkgICAgaW50IG1hc2ssIGludCBjaGFuZ2VkKTsNCj4gDQo+ICNpZiBQUk9DRVNTX1NZU19FVkVO VFMgPT0gMQ0KPiBzdGF0aWMgdm9pZCB2bXhuZXQzX3Byb2Nlc3NfZXZlbnRzKHN0cnVjdCB2bXhu ZXQzX2h3ICopOw0KPkBAIC01MjEsNyArNTIxLDcgQEAgdm14bmV0M19zZXR1cF9kcml2ZXJfc2hh cmVkKHN0cnVjdCBydGVfZXRoX2RldiAqZGV2KQ0KPiAJaWYgKGRldi0+ZGF0YS0+ZGV2X2NvbmYu cnhtb2RlLmh3X3ZsYW5fZmlsdGVyKQ0KPiAJCW1hc2sgfD0gRVRIX1ZMQU5fRklMVEVSX01BU0s7 DQo+IA0KPi0Jdm14bmV0M19kZXZfdmxhbl9vZmZsb2FkX3VwZGF0ZShkZXYsIG1hc2spOw0KPisJ dm14bmV0M19kZXZfdmxhbl9vZmZsb2FkX3VwZGF0ZShkZXYsIG1hc2ssIG1hc2spOw0KPiANCj4g CVBNRF9JTklUX0xPRyhERUJVRywNCj4gCQkgICAgICJXcml0aW5nIE1BQyBBZGRyZXNzIDogJTAy eDolMDJ4OiUwMng6JTAyeDolMDJ4OiUwMngiLA0KPkBAIC04MzgsMzQgKzgzOCw0NSBAQCB2bXhu ZXQzX2Rldl92bGFuX2ZpbHRlcl9zZXQoc3RydWN0IHJ0ZV9ldGhfZGV2ICpkZXYsIHVpbnQxNl90 IHZpZCwgaW50IG9uKQ0KPiB9DQo+IA0KPiBzdGF0aWMgdm9pZA0KPi12bXhuZXQzX2Rldl92bGFu X29mZmxvYWRfdXBkYXRlKHN0cnVjdCBydGVfZXRoX2RldiAqZGV2LCBpbnQgbWFzaykNCj4rdm14 bmV0M19kZXZfdmxhbl9vZmZsb2FkX3VwZGF0ZShzdHJ1Y3QgcnRlX2V0aF9kZXYgKmRldiwgaW50 IG1hc2ssIGludCBjaGFuZ2VkKQ0KPiB7DQo+IAlzdHJ1Y3Qgdm14bmV0M19odyAqaHcgPSBkZXYt PmRhdGEtPmRldl9wcml2YXRlOw0KPiAJVm14bmV0M19EU0RldlJlYWQgKmRldlJlYWQgPSAmaHct PnNoYXJlZC0+ZGV2UmVhZDsNCj4gCXVpbnQzMl90ICp2Zl90YWJsZSA9IGRldlJlYWQtPnJ4Rmls dGVyQ29uZi52ZlRhYmxlOw0KPiANCj4tCWlmIChtYXNrICYgRVRIX1ZMQU5fU1RSSVBfTUFTSykN Cj4tCQlkZXZSZWFkLT5taXNjLnVwdEZlYXR1cmVzIHw9IFVQVDFfRl9SWFZMQU47DQo+LQllbHNl DQo+LQkJZGV2UmVhZC0+bWlzYy51cHRGZWF0dXJlcyAmPSB+VVBUMV9GX1JYVkxBTjsNCj4tDQo+ LQlWTVhORVQzX1dSSVRFX0JBUjFfUkVHKGh3LCBWTVhORVQzX1JFR19DTUQsDQo+LQkJCSAgICAg ICBWTVhORVQzX0NNRF9VUERBVEVfRkVBVFVSRSk7DQo+KwlpZiAoY2hhbmdlZCAmIEVUSF9WTEFO X1NUUklQX01BU0spIHsNCj4rCQlpZiAobWFzayAmIEVUSF9WTEFOX1NUUklQX01BU0spDQo+KwkJ CWRldlJlYWQtPm1pc2MudXB0RmVhdHVyZXMgfD0gVVBUMV9GX1JYVkxBTjsNCj4rCQllbHNlDQo+ KwkJCWRldlJlYWQtPm1pc2MudXB0RmVhdHVyZXMgJj0gflVQVDFfRl9SWFZMQU47DQo+IA0KPi0J aWYgKG1hc2sgJiBFVEhfVkxBTl9GSUxURVJfTUFTSykgew0KPi0JCW1lbWNweSh2Zl90YWJsZSwg aHctPnNoYWRvd192ZnRhLCBWTVhORVQzX1ZGVF9UQUJMRV9TSVpFKTsNCj4tCX0gZWxzZSB7DQo+ LQkJbWVtc2V0KHZmX3RhYmxlLCAweGZmLCBWTVhORVQzX1ZGVF9UQUJMRV9TSVpFKTsNCj4rCQlW TVhORVQzX1dSSVRFX0JBUjFfUkVHKGh3LCBWTVhORVQzX1JFR19DTUQsDQo+KwkJCQkgICAgICAg Vk1YTkVUM19DTURfVVBEQVRFX0ZFQVRVUkUpOw0KPiAJfQ0KPiANCj4tCVZNWE5FVDNfV1JJVEVf QkFSMV9SRUcoaHcsIFZNWE5FVDNfUkVHX0NNRCwNCj4tCQkJICAgICAgIFZNWE5FVDNfQ01EX1VQ REFURV9WTEFOX0ZJTFRFUlMpOw0KPisJaWYgKGNoYW5nZWQgJiBFVEhfVkxBTl9GSUxURVJfTUFT Sykgew0KPisJCWlmIChtYXNrICYgRVRIX1ZMQU5fRklMVEVSX01BU0spDQo+KwkJCW1lbWNweSh2 Zl90YWJsZSwgaHctPnNoYWRvd192ZnRhLCBWTVhORVQzX1ZGVF9UQUJMRV9TSVpFKTsNCj4rCQll bHNlDQo+KwkJCW1lbXNldCh2Zl90YWJsZSwgMHhmZiwgVk1YTkVUM19WRlRfVEFCTEVfU0laRSk7 DQo+Kw0KPisJCVZNWE5FVDNfV1JJVEVfQkFSMV9SRUcoaHcsIFZNWE5FVDNfUkVHX0NNRCwNCj4r CQkJCSAgICAgICBWTVhORVQzX0NNRF9VUERBVEVfVkxBTl9GSUxURVJTKTsNCj4rCX0NCj4gfQ0K PiANCj4gc3RhdGljIHZvaWQNCj4gdm14bmV0M19kZXZfdmxhbl9vZmZsb2FkX3NldChzdHJ1Y3Qg cnRlX2V0aF9kZXYgKmRldiwgaW50IG1hc2spDQo+IHsNCj4tCXZteG5ldDNfZGV2X3ZsYW5fb2Zm bG9hZF91cGRhdGUoZGV2LCBtYXNrKTsNCj4rCWludCBod19tYXNrID0gMDsNCj4rDQo+KwlpZiAo ZGV2LT5kYXRhLT5kZXZfY29uZi5yeG1vZGUuaHdfdmxhbl9zdHJpcCkNCj4rCQlod19tYXNrIHw9 IEVUSF9WTEFOX1NUUklQX01BU0s7DQo+Kw0KPisJaWYgKGRldi0+ZGF0YS0+ZGV2X2NvbmYucnht b2RlLmh3X3ZsYW5fZmlsdGVyKQ0KPisJCWh3X21hc2sgfD0gRVRIX1ZMQU5fRklMVEVSX01BU0s7 DQo+Kw0KPisJdm14bmV0M19kZXZfdmxhbl9vZmZsb2FkX3VwZGF0ZShkZXYsIGh3X21hc2ssIG1h c2spOw0KDQpJIGRvbuKAmXQgc2VlIGEgbmVlZCB0byBoYXZlIGEgc2VwYXJhdGUgZnVuY3Rpb24g Zm9yIF91cGRhdGUuIFlvdSBjYW4gc2luZ2x5IG1lcmdlIGl0cyBpbXBsZW1lbnRhdGlvbiB3aXRo IHZteG5ldDNfZGV2X3ZsYW5fb2ZmbG9hZF9zZXQsIHdoaWNoIHNlZW1zIHRvIGJlIGNsZWFyZXIg YW5kIGVhc2llciB0byBmb2xsb3cgSU1PLg0KDQo+IH0NCj4gDQo+ICNpZiBQUk9DRVNTX1NZU19F VkVOVFMgPT0gMQ0KPi0tIA0KPjIuMS40DQo+DQo=