All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ian Pratt" <m+Ian.Pratt@cl.cam.ac.uk>
To: "Graham, Simon" <Simon.Graham@stratus.com>,
	xen-devel@lists.xensource.com
Subject: RE: Reducing impact of save/restore/dump on Dom0
Date: Tue, 6 Feb 2007 23:00:17 -0000	[thread overview]
Message-ID: <8A87A9A84C201449A0C56B728ACF491E04F46D@liverpoolst.ad.cl.cam.ac.uk> (raw)
In-Reply-To: 342BAC0A5467384983B586A6B0B3767104A69BB9@EXNA.corp.stratus.com

 
> Solving this problem for save/restore is more tricky because the
> on-disk/wire save format does not force the page data to be page
aligned
> -- my proposal would be to page align each batch of pages written,
> leaving pad between the batch header and the pages themselves but I
> realize that a change in on-disk/wire format is a potential
> compatibility problem.

The on-disk format is due to change before 3.0.5 anyhow. Page aligning
the data pages is certainly something I'd like to see happen. The
easiest way of doing this is to add some padding to align things at the
start of the page write-out loop, then in the PV case, make sure that
the page-type batches are padded to page size. (I'd reduce the max batch
size slightly so that in the normal case the batch fits nicely in 1
page, or 2 for 64b).

As for making the IO bypass the buffer cache, I'm not sure what the best
way to do this is. There are some occasions where we want the restore
image to be in the buffer cache (e.g. as used by the fault injection
testing for fast domain restart) but I agree that its not helpful in the
normal case. My first inclination would be O_DIRECT, but there may be a
better way.

Ian 

  parent reply	other threads:[~2007-02-06 23:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06 15:43 Reducing impact of save/restore/dump on Dom0 Graham, Simon
2007-02-06 16:23 ` John Levon
2007-02-06 17:36 ` Iustin Pop
2007-02-06 17:46   ` Graham, Simon
2007-02-06 18:35     ` Iustin Pop
2007-02-06 23:00 ` Ian Pratt [this message]
2007-02-06 23:20   ` Jeremy Fitzhardinge
2007-02-07  6:40     ` Rusty Russell
2007-02-07  7:41       ` Jeremy Fitzhardinge
2007-02-07 12:11 ` Andi Kleen
2007-02-07 12:52   ` Ian Pratt
2007-02-07 12:58     ` Andi Kleen
2007-02-06 17:25 Graham, Simon
2007-02-06 19:21 Graham, Simon
2007-02-07 12:56 Graham, Simon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8A87A9A84C201449A0C56B728ACF491E04F46D@liverpoolst.ad.cl.cam.ac.uk \
    --to=m+ian.pratt@cl.cam.ac.uk \
    --cc=Simon.Graham@stratus.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.