Re: [PATCH Altp2m cleanup v4 2/4] altp2m cleanup work

From: "Lai, Paul C" <paul.c.lai@intel.com>
To: Tamas K Lengyel <tamas.k.lengyel@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
	"Sahita, Ravi" <ravi.sahita@intel.com>,
	"george.dunlap@citrix.com" <george.dunlap@citrix.com>,
	Jan Beulich <JBeulich@suse.com>
Subject: Re: [PATCH Altp2m cleanup v4 2/4] altp2m cleanup work
Date: Thu, 8 Sep 2016 16:45:13 +0000	[thread overview]
Message-ID: <8CA46881B83C354B99AD61C20C93EB1BE45078@ORSMSX109.amr.corp.intel.com> (raw)
In-Reply-To: <CABfawh=w83+UDMe-F=vprqY_bc1T-Ym8CyHdXtmwvhu+xRiUaw@mail.gmail.com>

[Paul2] in-line

-----Original Message-----
From: Tamas K Lengyel [mailto:tamas.k.lengyel@gmail.com] 
Sent: Thursday, September 8, 2016 9:07 AM
To: Lai, Paul C <paul.c.lai@intel.com>
Cc: Jan Beulich <JBeulich@suse.com>; xen-devel <xen-devel@lists.xenproject.org>; Sahita, Ravi <ravi.sahita@intel.com>; george.dunlap@citrix.com
Subject: Re: [Xen-devel] [PATCH Altp2m cleanup v4 2/4] altp2m cleanup work

On Thu, Sep 8, 2016 at 9:50 AM, Lai, Paul C <paul.c.lai@intel.com> wrote:
> [Paul] in-line
>
> -----Original Message-----
> From: Jan Beulich [mailto:JBeulich@suse.com]
> Sent: Thursday, September 8, 2016 7:47 AM
> To: Lai, Paul C <paul.c.lai@intel.com>
> Cc: george.dunlap@citrix.com; Sahita, Ravi <ravi.sahita@intel.com>; 
> xen-devel <xen-devel@lists.xenproject.org>
> Subject: Re: [PATCH Altp2m cleanup v4 2/4] altp2m cleanup work
>
>>>> On 08.09.16 at 00:04, <paul.c.lai@intel.com> wrote:
>> Indent goto labels by one space
>> Inline (header) altp2m functions
>> Define default behavior in switch
>> Define max and min for range of altp2m macroed values
>>
>> Signed-off-by: Paul Lai <paul.c.lai@intel.com>
>> ---
>
> Missing a brief summary of changes from previous version here.
>
>> @@ -5413,6 +5426,8 @@ static int do_altp2m_op(
>>              rc = p2m_change_altp2m_gfn(d, a.u.change_gfn.view,
>>                      _gfn(a.u.change_gfn.old_gfn),
>>                      _gfn(a.u.change_gfn.new_gfn));
>> +    default:
>> +        ASSERT_UNREACHABLE();
>>      }
>
> Did you test anything using HVMOP_altp2m_change_gfn with this change, on a debug build? There's obviously an unintended fall- through right now.
>
> [Paul] - Yes, this patch series was tested with Tamas's HVMOP_altp2m_change_gfn in a debug build.

Not sure what you used here, the xen-access tool right now in Xen doesn't (yet) exercise the gfn remapping, only the mem-access parts.
Sergej has a patch for this in the arm-altp2m series though.

Tamas

[Paul2] All I was testing was if xen-access behaved as before the gfn remapping patch was introduced.  After the gfn remapping patch was introduced, 'xen-acess -m 1 altp2m_write' hanged the system.  Now, with your fix, it doesn't and the output of xen-access appears as before.   Thanks, -Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel