All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikita Ermakov <sh1r4s3@mail.si-head.nl>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2] mm/msync: exit early when the flags is an MS_ASYNC and start < vm_start
Date: Sun, 25 Oct 2020 12:38:14 +0300	[thread overview]
Message-ID: <8CEEE660-0F22-4222-87D9-8DCA9D866029@mail.si-head.nl> (raw)
In-Reply-To: <bb6e370a-8901-5db0-1057-90414ea085e2@suse.cz>



> On 23 Oct 2020, at 14:12, Vlastimil Babka <vbabka@suse.cz> wrote:
> 
> On 10/20/20 10:56 PM, Nikita Ermakov wrote:
>> If an unmapped region was found and the flag is MS_ASYNC (without
>> MS_INVALIDATE) there is nothing to do and the result would be always
>> -ENOMEM, so return immediately.
>> Signed-off-by: Nikita Ermakov <sh1r4s3@mail.si-head.nl>
>> ---
>>  mm/msync.c | 2 ++
>>  1 file changed, 2 insertions(+)
>> diff --git a/mm/msync.c b/mm/msync.c
>> index 69c6d2029531..ed20c3621d4c 100644
>> --- a/mm/msync.c
>> +++ b/mm/msync.c
>> @@ -69,6 +69,8 @@ SYSCALL_DEFINE3(msync, unsigned long, start, size_t, len, int, flags)
>>  			goto out_unlock;
>>  		/* Here start < vma->vm_end. */
>>  		if (start < vma->vm_start) {
> 
> I hoped it would become a code comment.
> 

Ops, I'm sorry. I've implemented this suggestion in the v3.

>> +			if (flags == MS_ASYNC)
>> +				goto out_unlock;
>>  			start = vma->vm_start;
>>  			if (start >= end)
>>  				goto out_unlock;
>> base-commit: 6824a8a9b4861d7df7ee132a952bdf6f84a99cb8

--
Thanks,
Nikita
B8 00 4C CD 21



      parent reply	other threads:[~2020-10-25  9:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12 16:09 [PATCH] " Nikita Ermakov
2020-10-20 10:19 ` Vlastimil Babka
2020-10-20 14:38   ` Nikita
2020-10-20 15:03     ` Vlastimil Babka
2020-10-20 16:19       ` Nikita
2020-10-20 20:56         ` [PATCH v2] " Nikita Ermakov
2020-10-23 11:12           ` Vlastimil Babka
2020-10-25  9:29             ` [PATCH v3] " Nikita Ermakov
2020-10-25  9:38             ` Nikita Ermakov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CEEE660-0F22-4222-87D9-8DCA9D866029@mail.si-head.nl \
    --to=sh1r4s3@mail.si-head.nl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=vbabka@suse.cz \
    --subject='Re: [PATCH v2] mm/msync: exit early when the flags is an MS_ASYNC and start < vm_start' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.