From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Iremonger, Bernard" Subject: Re: [PATCH 1/2 v4] fm10k: Free queues when close port Date: Fri, 26 Jun 2015 11:02:36 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C204A422AD@IRSMSX108.ger.corp.intel.com> References: <1434702717-11877-1-git-send-email-michael.qiu@intel.com> <1435307390-20140-1-git-send-email-michael.qiu@intel.com> <1435307390-20140-2-git-send-email-michael.qiu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "He, Shaopeng" To: "Qiu, Michael" , "dev@dpdk.org" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3339AC89C for ; Fri, 26 Jun 2015 13:02:40 +0200 (CEST) In-Reply-To: <1435307390-20140-2-git-send-email-michael.qiu@intel.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Qiu, Michael > Sent: Friday, June 26, 2015 9:30 AM > To: dev@dpdk.org > Cc: Chen, Jing D; He, Shaopeng; Iremonger, Bernard; Qiu, Michael > Subject: [PATCH 1/2 v4] fm10k: Free queues when close port >=20 > When close a port, lots of memory should be released, such as software > rings, queues, etc. >=20 > Signed-off-by: Michael Qiu > --- Hi Michael, There are 2 comments inline=20 > drivers/net/fm10k/fm10k_ethdev.c | 37 > +++++++++++++++++++++++++++++++++---- > 1 file changed, 33 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/net/fm10k/fm10k_ethdev.c > b/drivers/net/fm10k/fm10k_ethdev.c > index 406c350..eba7228 100644 > --- a/drivers/net/fm10k/fm10k_ethdev.c > +++ b/drivers/net/fm10k/fm10k_ethdev.c > @@ -65,6 +65,8 @@ static void > fm10k_MAC_filter_set(struct rte_eth_dev *dev, const u8 *mac, bool add); > static void fm10k_MACVLAN_remove_all(struct rte_eth_dev *dev); > +static void fm10k_tx_queue_release(void *queue); static void > +fm10k_rx_queue_release(void *queue); >=20 > static void > fm10k_mbx_initlock(struct fm10k_hw *hw) @@ -809,11 +811,37 @@ > fm10k_dev_stop(struct rte_eth_dev *dev) >=20 > PMD_INIT_FUNC_TRACE(); >=20 > - for (i =3D 0; i < dev->data->nb_tx_queues; i++) > - fm10k_dev_tx_queue_stop(dev, i); > + if (dev->data->tx_queues) > + for (i =3D 0; i < dev->data->nb_tx_queues; i++) > + fm10k_dev_tx_queue_stop(dev, i); >=20 > - for (i =3D 0; i < dev->data->nb_rx_queues; i++) > - fm10k_dev_rx_queue_stop(dev, i); > + if (dev->data->rx_queues) > + for (i =3D 0; i < dev->data->nb_rx_queues; i++) > + fm10k_dev_rx_queue_stop(dev, i); > +} > + > +static void > +fm10k_dev_queue_release(struct rte_eth_dev *dev) { > + int i; > + > + PMD_INIT_FUNC_TRACE(); > + > + if (dev->data->tx_queues) { > + for (i =3D 0; i < dev->data->nb_tx_queues; i++) > + fm10k_tx_queue_release(dev->data- > >tx_queues[i]); > + rte_free(dev->data->tx_queues); > + dev->data->tx_queues =3D NULL; The memory for dev->data->tx_queues is not allocated in the fm10k PMD, so it should probably not be released here. I have submitted a patch today for rte_eth_dev.c to do this. =20 /dev/patchwork/patch/5829/ > + dev->data->nb_tx_queues =3D 0; > + } > + > + if (dev->data->rx_queues) { > + for (i =3D 0; i < dev->data->nb_rx_queues; i++) > + fm10k_rx_queue_release(dev->data- > >rx_queues[i]); > + rte_free(dev->data->rx_queues); > + dev->data->rx_queues =3D NULL; The memory for dev->data->rx_queues is not allocated in the fm10k PMD, so it should probably not be released here. I have submitted a patch today for rte_eth_dev.c to do this. =20 /dev/patchwork/patch/5829/ Regards, Bernard. > + dev->data->nb_rx_queues =3D 0; > + } > } >=20 > static void > @@ -828,6 +856,7 @@ fm10k_dev_close(struct rte_eth_dev *dev) > /* Stop mailbox service first */ > fm10k_close_mbx_service(hw); > fm10k_dev_stop(dev); > + fm10k_dev_queue_release(dev); > fm10k_stop_hw(hw); > } >=20 > -- > 1.9.3