From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Iremonger, Bernard" Subject: Re: [PATCH 1/2 v4] fm10k: Free queues when close port Date: Mon, 29 Jun 2015 08:57:07 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C204A42BB8@IRSMSX108.ger.corp.intel.com> References: <1434702717-11877-1-git-send-email-michael.qiu@intel.com> <1435307390-20140-1-git-send-email-michael.qiu@intel.com> <1435307390-20140-2-git-send-email-michael.qiu@intel.com> <8CEF83825BEC744B83065625E567D7C204A422AD@IRSMSX108.ger.corp.intel.com> <533710CFB86FA344BFBF2D6802E60286046A5FD7@SHSMSX101.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "He, Shaopeng" To: "Qiu, Michael" , "dev@dpdk.org" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id DA690C438 for ; Mon, 29 Jun 2015 10:57:19 +0200 (CEST) In-Reply-To: <533710CFB86FA344BFBF2D6802E60286046A5FD7@SHSMSX101.ccr.corp.intel.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Qiu, Michael > Sent: Monday, June 29, 2015 9:17 AM > To: Iremonger, Bernard; dev@dpdk.org > Cc: Chen, Jing D; He, Shaopeng > Subject: Re: [PATCH 1/2 v4] fm10k: Free queues when close port >=20 > On 6/26/2015 7:02 PM, Iremonger, Bernard wrote: > >> -----Original Message----- > >> From: Qiu, Michael > >> Sent: Friday, June 26, 2015 9:30 AM > >> To: dev@dpdk.org > >> Cc: Chen, Jing D; He, Shaopeng; Iremonger, Bernard; Qiu, Michael > >> Subject: [PATCH 1/2 v4] fm10k: Free queues when close port > >> > >> When close a port, lots of memory should be released, such as > >> software rings, queues, etc. > >> > >> Signed-off-by: Michael Qiu > >> --- > > Hi Michael, > > > > There are 2 comments inline > > > >> drivers/net/fm10k/fm10k_ethdev.c | 37 > >> +++++++++++++++++++++++++++++++++---- > >> 1 file changed, 33 insertions(+), 4 deletions(-) > >> > >> diff --git a/drivers/net/fm10k/fm10k_ethdev.c > >> b/drivers/net/fm10k/fm10k_ethdev.c > >> index 406c350..eba7228 100644 > >> --- a/drivers/net/fm10k/fm10k_ethdev.c > >> +++ b/drivers/net/fm10k/fm10k_ethdev.c > >> @@ -65,6 +65,8 @@ static void > >> fm10k_MAC_filter_set(struct rte_eth_dev *dev, const u8 *mac, bool > >> add); static void fm10k_MACVLAN_remove_all(struct rte_eth_dev > *dev); > >> +static void fm10k_tx_queue_release(void *queue); static void > >> +fm10k_rx_queue_release(void *queue); > >> > >> static void > >> fm10k_mbx_initlock(struct fm10k_hw *hw) @@ -809,11 +811,37 @@ > >> fm10k_dev_stop(struct rte_eth_dev *dev) > >> > >> PMD_INIT_FUNC_TRACE(); > >> > >> - for (i =3D 0; i < dev->data->nb_tx_queues; i++) > >> - fm10k_dev_tx_queue_stop(dev, i); > >> + if (dev->data->tx_queues) > >> + for (i =3D 0; i < dev->data->nb_tx_queues; i++) > >> + fm10k_dev_tx_queue_stop(dev, i); > >> > >> - for (i =3D 0; i < dev->data->nb_rx_queues; i++) > >> - fm10k_dev_rx_queue_stop(dev, i); > >> + if (dev->data->rx_queues) > >> + for (i =3D 0; i < dev->data->nb_rx_queues; i++) > >> + fm10k_dev_rx_queue_stop(dev, i); > >> +} > >> + > >> +static void > >> +fm10k_dev_queue_release(struct rte_eth_dev *dev) { > >> + int i; > >> + > >> + PMD_INIT_FUNC_TRACE(); > >> + > >> + if (dev->data->tx_queues) { > >> + for (i =3D 0; i < dev->data->nb_tx_queues; i++) > >> + fm10k_tx_queue_release(dev->data- > >>> tx_queues[i]); > >> + rte_free(dev->data->tx_queues); > >> + dev->data->tx_queues =3D NULL; > > The memory for dev->data->tx_queues is not allocated in the fm10k > > PMD, so it should probably not be released here. > > I have submitted a patch today for rte_eth_dev.c to do this. > > /dev/patchwork/patch/5829/ > > > >> + dev->data->nb_tx_queues =3D 0; > >> + } > >> + > >> + if (dev->data->rx_queues) { > >> + for (i =3D 0; i < dev->data->nb_rx_queues; i++) > >> + fm10k_rx_queue_release(dev->data- > >>> rx_queues[i]); > >> + rte_free(dev->data->rx_queues); > >> + dev->data->rx_queues =3D NULL; > > The memory for dev->data->rx_queues is not allocated in the fm10k > > PMD, so it should probably not be released here. > > I have submitted a patch today for rte_eth_dev.c to do this. > > /dev/patchwork/patch/5829/ >=20 > Is it a good idea? What about to close the port for twice at a time? > I think it is better to do it in rte_eth_dev_close(), I will give the com= ments to > you. >=20 > Thanks, > Michael Hi Michael, Could you take a look at the comments on http://dpdk.org/dev/patchwork/patc= h/5829/ The consensus is that memory should be freed in the component that allocate= d it. In my pmd hotplug patches I have used a flag to ensure that dev_close is no= t called twice. In the e1000 patch I have added a stopped flag to struct e1000_adapter. =20 http://dpdk.org/dev/patchwork/patch/5655/ Regards, Bernard.