From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [PATCH v5 1/3] librte_ether: add API for VF
 management
Date: Thu, 29 Sep 2016 15:16:48 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C21A08E0CA@IRSMSX108.ger.corp.intel.com>
References: <1474453204-31516-1-git-send-email-bernard.iremonger@intel.com>
 <1475158591-2243-2-git-send-email-bernard.iremonger@intel.com>
 <3631809.sFy4WKcCTS@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Shah, Rahul R" <rahul.r.shah@intel.com>,
 "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "az5157@att.com" <az5157@att.com>,
 azelezniak <alexz@att.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id EF3E12B88
 for <dev@dpdk.org>; Thu, 29 Sep 2016 17:16:51 +0200 (CEST)
In-Reply-To: <3631809.sFy4WKcCTS@xps13>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas,

<snip>

> Subject: Re: [dpdk-dev] [PATCH v5 1/3] librte_ether: add API for VF
> management
>=20
> 2016-09-29 15:16, Bernard Iremonger:
> > Add new API function to configure and manage VF's on a NIC.
> >
> > add rte_eth_dev_set_vf_vlan_stripq function.
> >
> > Signed-off-by: azelezniak <alexz@att.com>
>=20
> We need the full name of azelezniak.

It is Alex Zelezniak, I will update the commit messages.

> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> [...]
> > +int
> > +rte_eth_dev_set_vf_vlan_stripq(uint8_t port, uint16_t vf, int on);
>=20
> Why keeping this function in ethdev?

This function is using an existing API in the eth_dev_ops structure.

dev->dev_ops->vlan_strip_queue_set

The vlan_strip_queue_set API is used by  the i40e, ixgbe and mlx5 PMD's.

> I think it would be more consistent to have also existing VF functions mo=
ving
> from ethdev to rte_pmd_ixgbe.h.
> You cannot remove them, but you can create their ixgbe-specific version a=
nd
> announce that the ethdev ones are deprecated.

There are 5 existing VF functions which are only used by ixgbe PMD at prese=
nt.
It would make sense to create ixgbe-specific versions, however I think this=
 should be done in a separate patchset.

Regards,

Bernard

=20