From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [PATCH v7 2/2] app/test_pmd: add tests for new API's
Date: Wed, 12 Oct 2016 15:00:05 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C21A091FBB@IRSMSX108.ger.corp.intel.com>
References: <1475231418-30717-2-git-send-email-bernard.iremonger@intel.com>
 <2850526.ogb5UjoHqb@xps13>
 <8CEF83825BEC744B83065625E567D7C21A090A8A@IRSMSX108.ger.corp.intel.com>
 <1615821.fhDo4YvI1t@xps13>
 <8CEF83825BEC744B83065625E567D7C21A090B2D@IRSMSX108.ger.corp.intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8973CA07CA1@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Shah, Rahul R" <rahul.r.shah@intel.com>, "Lu, Wenzhuo"
 <wenzhuo.lu@intel.com>, "az5157@att.com" <az5157@att.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>, Thomas Monjalon
 <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id AB7C82BB5
 for <dev@dpdk.org>; Wed, 12 Oct 2016 17:00:08 +0200 (CEST)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973CA07CA1@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Pablo,

<snip>

> > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests for new
> > API's
> >
> > Hi Thomas,
> >
> > <snip>
> >
> > > > > Subject: Re: [dpdk-dev] [PATCH v7 2/2] app/test_pmd: add tests
> > > > > for new API's
> > > > >
> > > > > 2016-10-11 16:09, Ferruh Yigit:
> > > > > > This will cause a compilation error for shared libraries.
> > > > > > Because PMDs not linked against application when compiled as
> > > > > > shared library but used as plugins.
> > > > > >
> > > > > > Since it has been decided to have NIC specific APIs, we need
> > > > > > to re-work that approach to fix shared library compilation.
> > > > >
> > > > > If testpmd uses the ixgbe API, it must be linked with the PMD.
> > > > > Is there any issue adapting the testpmd makefile?
> > > > > Hope that dlopen an already linked PMD is nicely managed.
> > > >
> > > > The ixgbe API will  be used by other apps, for example Virtual
> > > > Function Daemon (VFD) Moving the following line in rte.app.mak
> > > > solves the problem
> > > >
> > > > Line 117: _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD)      +=3D -
> > > lrte_pmd_ixgbe
> > > >
> > > > To Line 103.
> > > >
> > > > Will this be acceptable?
> > >
> > > I think we must not link PMD in the general case but let this
> > > responsibility to the application in case it uses some specific funct=
ions.
> > > Does it make sense?
> >
> > Yes, ok, will just modify the testpmd makefile  for this case.
>=20
> A couple of things:
> You would need to use #ifdef RTE_LIBRTE_IXGBE_PMD in testpmd, right?
> In case IXGBE is not available (maybe just modifying the makefile solves =
the
> problem).
>=20
> Could you also add these new functions in the testpmd help?
> Just add them in cmd_help_long_parsed.
>=20
> Thanks,
> Pablo

I have added #ifdef RTE_LIBRTE_IXGBE_PMD in testpmd.
The make file is modified to handle ixgbe PMD present and not present in sh=
ared library mode and default mode.
I have added the new functions to the testpmd help.

Thanks for reviewing.

Regards,

Bernard.