From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [PATCH v2 17/32] net/i40e: set VF broadcast mode
 from PF
Date: Tue, 13 Dec 2016 14:35:05 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C224D06F26@IRSMSX108.ger.corp.intel.com>
References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com>
 <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com>
 <1481081535-37448-18-git-send-email-wenzhuo.lu@intel.com>
 <10f85acc-17d4-4ac3-29d2-6b27430b2240@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Lu, Wenzhuo"
 <wenzhuo.lu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id DA566282
 for <dev@dpdk.org>; Tue, 13 Dec 2016 15:35:07 +0100 (CET)
In-Reply-To: <10f85acc-17d4-4ac3-29d2-6b27430b2240@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday, December 7, 2016 2:33 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; dev@dpdk.org
> Cc: Iremonger, Bernard <bernard.iremonger@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 17/32] net/i40e: set VF broadcast mode
> from PF
>=20
> On 12/7/2016 3:32 AM, Wenzhuo Lu wrote:
> > Support enabling/disabling VF broadcast mode from PF.
> > User can call the API on PF to enable/disable a specific VF's
> > broadcast mode.
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
>=20
> <...>
>=20
> > +int rte_pmd_i40e_set_vf_broadcast(uint8_t port, uint16_t vf_id,
> > +uint8_t on) {
> > +	struct rte_eth_dev *dev;
> > +	struct rte_eth_dev_info dev_info;
> > +	struct i40e_pf *pf;
> > +	struct i40e_pf_vf *vf;
> > +	struct i40e_hw *hw;
> > +	int ret;
> > +
> > +	RTE_ETH_VALID_PORTID_OR_ERR_RET(port, -ENODEV);
> > +
> > +	dev =3D &rte_eth_devices[port];
> > +	rte_eth_dev_info_get(port, &dev_info);
> > +
> > +	if (vf_id >=3D dev_info.max_vfs)
> > +		return -EINVAL;
> > +
> > +	if (on > 1)
> > +		return -EINVAL;
> > +
> > +	pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
> > +	hw =3D I40E_PF_TO_HW(pf);
> > +
> > +	if (vf_id > pf->vf_num)
>=20
> if (vf_id > pf->vf_num - 1 || !pf->vfs)

if (vf_id >=3D pf->vf_num  || !pf->vfs)

might be better.

>=20
> > +		return -EINVAL;
> > +
>=20
> <...>

Regards,

Bernard.