From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [PATCH] net/i40e: fix eth pattern parsing
Date: Tue, 4 Apr 2017 12:52:23 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C224D4F2B7@IRSMSX108.ger.corp.intel.com>
References: <1491236049-6747-1-git-send-email-bernard.iremonger@intel.com>
 <ac41bc09-c7bd-47ce-f198-e5cecdc2a626@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "Xing, Beilei" <beilei.xing@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id E117C326C
 for <dev@dpdk.org>; Tue,  4 Apr 2017 14:52:25 +0200 (CEST)
In-Reply-To: <ac41bc09-c7bd-47ce-f198-e5cecdc2a626@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,

> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, April 4, 2017 1:40 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org;
> Xing, Beilei <beilei.xing@intel.com>
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix eth pattern parsing
>=20
> On 4/3/2017 5:14 PM, Bernard Iremonger wrote:
> > Handle the following eth patterns:
> > eth dst spec aa:bb:cc:dd:ee:ff
> > eth dst mask ff:ff:ff:ff:ff:ff
> > eth src spec aa:bb:cc:dd:ee:ff
> > eth src mask ff:ff:ff:ff:ff:ff
> >
> > Fixes: d46e85af6b5c ("net/i40e: parse QinQ pattern")
> >
> > Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
> > ---
> >  drivers/net/i40e/i40e_flow.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_flow.c
> > b/drivers/net/i40e/i40e_flow.c index 9f541eaff..3fcd31036 100644
> > --- a/drivers/net/i40e/i40e_flow.c
> > +++ b/drivers/net/i40e/i40e_flow.c
> > @@ -1772,7 +1772,8 @@ i40e_flow_parse_qinq_pattern(__rte_unused
> struct rte_eth_dev *dev,
> >  		case RTE_FLOW_ITEM_TYPE_ETH:
> >  			eth_spec =3D (const struct rte_flow_item_eth *)item-
> >spec;
> >  			eth_mask =3D (const struct rte_flow_item_eth *)item-
> >mask;
> > -			if (eth_spec && eth_mask) {
> > +			if ((eth_spec && eth_mask) ||
> > +			    (eth_spec || eth_mask)) {
>=20
> Is this check requires both spec and mask to be all zeros? If this is the=
 real
> intention, can you please add a comment above check to clarify it.

Yes , the intention is to only except the "eth" key word, I will send a v2.

>=20
> Also other i40e_flow_parse_xxx_pattern() functions has function comment
> to describe expected/valid pattern for the flow rule.
> i40e_flow_parse_qinq_pattern() is missing that function comment. Would
> you mind adding it, which helps to validate implementation against intent=
ion.

Yes , I will describe valid patterns for the flow rule in a separate patch.=
=20
=20
> Thanks,
> ferruh
>=20
> >  				rte_flow_error_set(error, EINVAL,
> >
> RTE_FLOW_ERROR_TYPE_ITEM,
> >  						   item,
> >
Regards,

Bernard.