From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Iremonger, Bernard" Subject: Re: [PATCH V21 4/4] app/testpmd: show example to handle hot unplug Date: Wed, 16 May 2018 14:30:46 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CD454@IRSMSX108.ger.corp.intel.com> References: <1498711073-42917-1-git-send-email-jia.guo@intel.com> <1525337829-3893-1-git-send-email-jia.guo@intel.com> <1525337829-3893-5-git-send-email-jia.guo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "jblunck@infradead.org" , "shreyansh.jain@nxp.com" , "dev@dpdk.org" , "Guo, Jia" , "Zhang, Helin" To: "Guo, Jia" , "stephen@networkplumber.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "gaetan.rivet@6wind.com" , "Wu, Jingjing" , "thomas@monjalon.net" , "motih@mellanox.com" , "matan@mellanox.com" , "Van Haaren, Harry" , "Tan, Jianfeng" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 620DFAAEE for ; Wed, 16 May 2018 16:30:52 +0200 (CEST) In-Reply-To: <1525337829-3893-5-git-send-email-jia.guo@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jeff > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Jeff Guo > Sent: Thursday, May 3, 2018 9:57 AM > To: stephen@networkplumber.org; Richardson, Bruce > ; Yigit, Ferruh ; > Ananyev, Konstantin ; > gaetan.rivet@6wind.com; Wu, Jingjing ; > thomas@monjalon.net; motih@mellanox.com; matan@mellanox.com; Van > Haaren, Harry ; Tan, Jianfeng > > Cc: jblunck@infradead.org; shreyansh.jain@nxp.com; dev@dpdk.org; Guo, > Jia ; Zhang, Helin > Subject: [dpdk-dev] [PATCH V21 4/4] app/testpmd: show example to handle > hot unplug >=20 > Use testpmd for example, to show how an application smoothly handle > failure when device being hot unplug. Once app detect the removal event, > the callback would be called, it first stop the packet forwarding, then s= top the > port, close the port and finally detach the port. >=20 > Signed-off-by: Jeff Guo > --- > v21->v20: > fix attach port issue, let it work for multiple device case. > --- > app/test-pmd/testpmd.c | 28 +++++++++++++++++++++++----- > 1 file changed, 23 insertions(+), 5 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > db23f23..81f41e3 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -1908,9 +1908,10 @@ eth_dev_event_callback_unregister(void) > void > attach_port(char *identifier) > { > - portid_t pi =3D 0; > unsigned int socket_id; >=20 > + portid_t pi =3D rte_eth_dev_count_avail(); > + > printf("Attaching a new port...\n"); >=20 > if (identifier =3D=3D NULL) { > @@ -2079,6 +2080,26 @@ rmv_event_callback(void *arg) > dev->device->name); > } >=20 > +static void > +rmv_dev_event_callback(char *dev_name) > +{ > + uint16_t port_id; > + int ret; > + > + ret =3D rte_eth_dev_get_port_by_name(dev_name, &port_id); > + if (ret) { > + printf("can not get port by device %s!\n", dev_name); > + return; > + } > + > + RTE_ETH_VALID_PORTID_OR_RET(port_id); > + printf("removing port id:%u\n", port_id); > + stop_packet_forwarding(); > + stop_port(port_id); > + close_port(port_id); > + detach_port(port_id); > +} > + > /* This function is used by the interrupt thread */ static int > eth_event_callback(portid_t port_id, enum rte_eth_event_type type, void > *param, @@ -2141,9 +2162,7 @@ eth_dev_event_callback(char > *device_name, enum rte_dev_event_type type, > case RTE_DEV_EVENT_REMOVE: > RTE_LOG(ERR, EAL, "The device: %s has been removed!\n", > device_name); > - /* TODO: After finish failure handle, begin to stop > - * packet forward, stop port, close port, detach port. > - */ > + rmv_dev_event_callback(device_name); > break; > case RTE_DEV_EVENT_ADD: > RTE_LOG(ERR, EAL, "The device: %s has been added!\n", > @@ -2666,7 +2685,6 @@ main(int argc, char** argv) > return -1; > } > eth_dev_event_callback_register(); > - > } >=20 > if (start_port(RTE_PORT_ALL) !=3D 0) > -- > 2.7.4 This patch does not apply to dpdk_18_05_R4C master branch and needs to be r= ebased. Regards, Bernard.