From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [PATCH] maintainers: fix responsibility of flow API
	bits
Date: Thu, 17 May 2018 11:26:17 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CD93C@IRSMSX108.ger.corp.intel.com>
References: <1525944544-13513-1-git-send-email-bernard.iremonger@intel.com>
 <20180515162211.7030-1-adrien.mazarguil@6wind.com>
 <8CEF83825BEC744B83065625E567D7C24E0CD20F@IRSMSX108.ger.corp.intel.com>
 <20180516143517.GA6497@6wind.com>
 <8CEF83825BEC744B83065625E567D7C24E0CD818@IRSMSX108.ger.corp.intel.com>
 <20180517112045.GE6497@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
To: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180517112045.GE6497@6wind.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Adrien,

<snip>


> > > > > Subject: [PATCH] maintainers: fix responsibility of flow API
> > > > > bits
> > > > >
> > > > > The following commits lack MAINTAINERS entries for this mess.
> > > > >
> > > > > Fixes: 4d73b6fb9907 ("doc: add generic flow API guide")
> > > > > Fixes: 19c90af6285c ("app/testpmd: add flow command")
> > > > > Cc: stable@dpdk.org
> > > > >
> > > > > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > > > > Cc: Bernard Iremonger <bernard.iremonger@intel.com>
> > > > > ---
> > > > >  MAINTAINERS | 2 ++
> > > > >  1 file changed, 2 insertions(+)
> > > > >
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS index
> > > > > bd08d4292..187817fff
> > > > > 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -303,6 +303,8 @@ F: devtools/test-null.sh  Flow API
> > > > >  M: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> > > > >  T: git://dpdk.org/next/dpdk-next-net
> > > > > +F: app/test-pmd/cmdline_flow.c
> > > > > +F: doc/guides/prog_guide/rte_flow.rst
> > > >
> > > > doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > > > Should be added to the list of flow related files.
> > >
> > > I did not add it because there is no way to split responsibility on
> > > a documentation section basis AFAIK, and only a fraction of this
> > > file contains information about rte_flow-related stuff.
> > >
> > > --
> > > Adrien Mazarguil
> > > 6WIND
> >
> > There are already several maintainers for testpmd, adding another maint=
ainer
> for the flow parts of this file should be ok (I think).
>=20
> True, however providing an exact file name instead of a directory or wild=
card
> makes me the main maintainer/contact for that specific file (e.g. "app/te=
st-
> pmd/cmdline_flow.c" vs. "app/test-pmd"), basically I do not want to be
> responsible for the entirety of testpmd's documentation.
>=20
> How about the following instead: another patch that extracts the flow
> command documentation in its own file (testpmd_flow.rst?) using the inclu=
de
> directive (somewhat like cmdline_flow.c). This patch will update MAINTAIN=
ERS
> accordingly.
>=20
> --
> Adrien Mazarguil
> 6WIND

Sounds good to me.

Regards,

Bernard.