From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [PATCH v2] app/testpmd: fix pmd_test_exit function
	for vdevs
Date: Fri, 18 May 2018 10:18:47 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C24E0CDF86@IRSMSX108.ger.corp.intel.com>
References: <20180518095937.28710-1-zhiyong.yang@intel.com>
 <2DBBFF226F7CF64BAFCA79B681719D953A44B1E4@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "Yigit, Ferruh"
 <ferruh.yigit@intel.com>, "Bie, Tiwei" <tiwei.bie@intel.com>,
 "stable@dpdk.org" <stable@dpdk.org>
To: "Yao, Lei A" <lei.a.yao@intel.com>, "Yang, Zhiyong"
 <zhiyong.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A44B1E4@SHSMSX101.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh, Zhiyong,

<snip>=20

> > Subject: [PATCH v2] app/testpmd: fix pmd_test_exit function for vdevs
> >
> > For vdev, just calling rte_eth_dev_close() isn't enough to free all
> > the resources allocated during device probe, e.g. for virtio-user,
> > virtio_user_pmd_remove(), i.e. the remove() method of a vdev driver,
> > needs to be called to unlink the socket file created during device
> > probe. So this patch calls the rte_eth_dev_detach() for vdev when
> > quitting testpmd.
> >
> > Cc: maxime.coquelin@redhat.com
> > Cc: ferruh.yigit@intel.com
> > Cc: tiwei.bie@intel.com
> > Cc: lei.a.yao@intel.com
> > Cc: bernard.iremonger@intel.com
> > Cc: stable@dpdk.org
> >
> > Fixes: af75078fece3 ("first public release")
> > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode")
> >
> > Signed-off-by: Zhiyong Yang <zhiyong.yang@intel.com>
> Tested-by: Lei Yao<lei.a.yao@intel.com>
> This patch pass the test for virtio-user server mode. The socket file can=
 be
> deleted after quit testpmd.

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

Hi Ferruh,

Check-git-log is showing some errors:

./devtools/check-git-log.sh -1
Wrong headline format:
        app/testpmd: fix pmd_test_exit function for vdevs
Wrong tag:
        Tested-by: Lei Yao<lei.a.yao@intel.com>

Can you fix these while merging or is a v3 needed?

Regards,

Bernard.