From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [RFC] testpmd: use RFC2544 reserved IP addresses
Date: Thu, 7 Jun 2018 12:52:59 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C260CAF443@IRSMSX108.ger.corp.intel.com>
References: <20180321034436.4089-1-stephen@networkplumber.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 97CC41200A
 for <dev@dpdk.org>; Thu,  7 Jun 2018 14:53:02 +0200 (CEST)
In-Reply-To: <20180321034436.4089-1-stephen@networkplumber.org>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Stephen,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
> Sent: Wednesday, March 21, 2018 3:45 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>
> Subject: [dpdk-dev] [RFC] testpmd: use RFC2544 reserved IP addresses
>=20
> Change the transmit only side of testpmd to use the IP addresses that are
> marked as reserved for benchmarking by RFC2544 192.18.0.0/27; rather than

RFC2544 seems to use 198.18.0.0 and 198.19.0.0 ?

> the commonly used subnet 192.168.0.0/24 which is likely to used for
> administrative interface.

Typo in the commit message "to used" should be "to be used"

>=20
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  app/test-pmd/txonly.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index
> 1f08b6ed37a2..22785bdcbe44 100644
> --- a/app/test-pmd/txonly.c
> +++ b/app/test-pmd/txonly.c
> @@ -43,8 +43,9 @@
>  #define UDP_SRC_PORT 1024
>  #define UDP_DST_PORT 1024
>=20
> -#define IP_SRC_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 1) -#define
> IP_DST_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 2)
> +/* RFC 2544 reserved IP addresses for benchmarking */ #define
> +IP_SRC_ADDR ((192U << 24) | (18 << 16) | (0 << 8) | 1) #define
> +IP_DST_ADDR ((192U << 24) | (18 << 16) | (0 << 8) | 2)
>=20
>  #define IP_DEFTTL  64   /* from RFC 1340. */
>  #define IP_VERSION 0x40
> --
> 2.16.2

>>From RFC 2544:
"The single filter case should permit traffic from IP address  198.18.1.2 t=
o IP address 198.19.65.2 and deny all other traffic."

Should the macros be as follows?
#define IP_SRC_ADDR ((198U << 24) | (18 << 16) | (0 << 8) | 1)
#define IP_DST_ADDR ((198U << 24) | (19 << 16) | (0 << 8) | 2)

Regards,

Bernard