From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [PATCH] app/testpmd: fix dcb config failure
Date: Tue, 24 Jul 2018 16:16:15 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C260CCF024@IRSMSX107.ger.corp.intel.com>
References: <1532431954-123708-1-git-send-email-xiaoyun.li@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Li, Xiaoyun" <xiaoyun.li@intel.com>,
 "stable@dpdk.org" <stable@dpdk.org>
To: "Li, Xiaoyun" <xiaoyun.li@intel.com>, "Lu, Wenzhuo"
 <wenzhuo.lu@intel.com>, "Wu, Jingjing" <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1532431954-123708-1-git-send-email-xiaoyun.li@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Xiaoyun Li
> Sent: Tuesday, July 24, 2018 12:33 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Li, Xiaoyun <xiaoyun.li@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix dcb config failure
>=20
> After adding RSS hash offload check, default rss_hf will fail on devices =
that do
> not support all bits. This will lead to dcb config failure. The patch fix=
es this
> issue by taking rss_hf as a suggested value and only setting bits that th=
e
> device supports based on rte_eth_dev_get_info.
>=20
> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> Fixes: 1a572499beb6 ("app/testpmd: setup DCB forwarding based on traffic
> class")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>