From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
Subject: Re: [PATCH v13 7/7] app/testpmd: use hotplug failure
	handler
Date: Thu, 4 Oct 2018 10:31:17 +0000
Message-ID: <8CEF83825BEC744B83065625E567D7C260D0C830@IRSMSX107.ger.corp.intel.com>
References: <1498711073-42917-1-git-send-email-jia.guo@intel.com>
 <1538634659-91335-1-git-send-email-jia.guo@intel.com>
 <1538634659-91335-8-git-send-email-jia.guo@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Cc: "jblunck@infradead.org" <jblunck@infradead.org>, "shreyansh.jain@nxp.com"
 <shreyansh.jain@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Helin"
 <helin.zhang@intel.com>
To: "Guo, Jia" <jia.guo@intel.com>, "stephen@networkplumber.org"
 <stephen@networkplumber.org>, "Richardson, Bruce"
 <bruce.richardson@intel.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
 "motih@mellanox.com" <motih@mellanox.com>, "matan@mellanox.com"
 <matan@mellanox.com>, "Van Haaren, Harry" <harry.van.haaren@intel.com>,
 "Zhang, Qi Z" <qi.z.zhang@intel.com>, "He, Shaopeng" <shaopeng.he@intel.com>,
 "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "Lu, Wenzhuo"
 <wenzhuo.lu@intel.com>, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 41FED1B1A0
 for <dev@dpdk.org>; Thu,  4 Oct 2018 12:31:22 +0200 (CEST)
In-Reply-To: <1538634659-91335-8-git-send-email-jia.guo@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

SGkgSmVmZiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBHdW8sIEpp
YQ0KPiBTZW50OiBUaHVyc2RheSwgT2N0b2JlciA0LCAyMDE4IDc6MzEgQU0NCj4gVG86IHN0ZXBo
ZW5AbmV0d29ya3BsdW1iZXIub3JnOyBSaWNoYXJkc29uLCBCcnVjZQ0KPiA8YnJ1Y2UucmljaGFy
ZHNvbkBpbnRlbC5jb20+OyBZaWdpdCwgRmVycnVoIDxmZXJydWgueWlnaXRAaW50ZWwuY29tPjsg
QW5hbnlldiwNCj4gS29uc3RhbnRpbiA8a29uc3RhbnRpbi5hbmFueWV2QGludGVsLmNvbT47IGdh
ZXRhbi5yaXZldEA2d2luZC5jb207IFd1LA0KPiBKaW5namluZyA8amluZ2ppbmcud3VAaW50ZWwu
Y29tPjsgdGhvbWFzQG1vbmphbG9uLm5ldDsNCj4gbW90aWhAbWVsbGFub3guY29tOyBtYXRhbkBt
ZWxsYW5veC5jb207IFZhbiBIYWFyZW4sIEhhcnJ5DQo+IDxoYXJyeS52YW4uaGFhcmVuQGludGVs
LmNvbT47IFpoYW5nLCBRaSBaIDxxaS56LnpoYW5nQGludGVsLmNvbT47IEhlLA0KPiBTaGFvcGVu
ZyA8c2hhb3BlbmcuaGVAaW50ZWwuY29tPjsgSXJlbW9uZ2VyLCBCZXJuYXJkDQo+IDxiZXJuYXJk
LmlyZW1vbmdlckBpbnRlbC5jb20+OyBhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tOyBMdSwgV2Vu
emh1bw0KPiA8d2Vuemh1by5sdUBpbnRlbC5jb20+OyBCdXJha292LCBBbmF0b2x5IDxhbmF0b2x5
LmJ1cmFrb3ZAaW50ZWwuY29tPjsNCj4gamVyaW4uamFjb2JAY2F2aXVtbmV0d29ya3MuY29tDQo+
IENjOiBqYmx1bmNrQGluZnJhZGVhZC5vcmc7IHNocmV5YW5zaC5qYWluQG54cC5jb207IGRldkBk
cGRrLm9yZzsgR3VvLCBKaWENCj4gPGppYS5ndW9AaW50ZWwuY29tPjsgWmhhbmcsIEhlbGluIDxo
ZWxpbi56aGFuZ0BpbnRlbC5jb20+DQo+IFN1YmplY3Q6IFtQQVRDSCB2MTMgNy83XSBhcHAvdGVz
dHBtZDogdXNlIGhvdHBsdWcgZmFpbHVyZSBoYW5kbGVyDQo+IA0KPiBUaGlzIHBhdGNoIHVzZSB0
ZXN0cG1kIGZvciBleGFtcGxlLCB0byBzaG93IGhvdyBhbiBhcHAgc21vb3RobHkgaGFuZGxlDQo+
IGZhaWx1cmUgd2hlbiBkZXZpY2UgYmUgaG90LXVucGx1Zy4gRXhjZXB0IHRoYXQgYXBwIHNob3Vs
ZCBlbmFibGVkIHRoZSBkZXZpY2UNCj4gZXZlbnQgbW9uaXRvciBhbmQgcmVnaXN0ZXIgdGhlIGhv
dHBsdWcgZXZlbnTigJlzIGNhbGxiYWNrLCBpdCBhbHNvIG5lZWQgZW5hYmxlDQo+IGhvdHBsdWcg
aGFuZGxlIG1lY2hhbmlzbSBiZWZvcmUgcnVubmluZy4gT25jZSBhcHAgZGV0ZWN0IHRoZSByZW1v
dmFsIGV2ZW50LA0KPiB0aGUgaG90LXVucGx1ZyBjYWxsYmFjayB3b3VsZCBiZSBjYWxsZWQuIEl0
IHdpbGwgZmlyc3Qgc3RvcCB0aGUgcGFja2V0IGZvcndhcmRpbmcsDQo+IHRoZW4gc3RvcCB0aGUg
cG9ydCwgY2xvc2UgdGhlIHBvcnQsIGFuZCBmaW5hbGx5IGRldGFjaCB0aGUgcG9ydCB0byBjbGVh
biB0aGUgZGV2aWNlDQo+IGFuZCByZWxlYXNlIHRoZSByZXNvdXJjZXMuDQo+IA0KPiBTaWduZWQt
b2ZmLWJ5OiBKZWZmIEd1byA8amlhLmd1b0BpbnRlbC5jb20+DQo+IC0tLQ0KPiB2MTMtPnYxMjoN
Cj4gZGVsZXRlIG5lZWRsZXNzIGhlbHBlciBpbiBhcHAuDQo+IC0tLQ0KPiAgYXBwL3Rlc3QtcG1k
L3Rlc3RwbWQuYyB8IDg2ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0NCj4gLQ0KPiAgMSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDQ2IGRl
bGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2FwcC90ZXN0LXBtZC90ZXN0cG1kLmMgYi9h
cHAvdGVzdC1wbWQvdGVzdHBtZC5jIGluZGV4DQo+IDAwMWYwZTUuLmYzZjhlNDQgMTAwNjQ0DQo+
IC0tLSBhL2FwcC90ZXN0LXBtZC90ZXN0cG1kLmMNCj4gKysrIGIvYXBwL3Rlc3QtcG1kL3Rlc3Rw
bWQuYw0KPiBAQCAtNDM0LDkgKzQzNCw2IEBAIHN0YXRpYyBpbnQgZXRoX2V2ZW50X2NhbGxiYWNr
KHBvcnRpZF90IHBvcnRfaWQsICBzdGF0aWMNCj4gdm9pZCBldGhfZGV2X2V2ZW50X2NhbGxiYWNr
KGNoYXIgKmRldmljZV9uYW1lLA0KPiAgCQkJCWVudW0gcnRlX2Rldl9ldmVudF90eXBlIHR5cGUs
DQo+ICAJCQkJdm9pZCAqcGFyYW0pOw0KPiAtc3RhdGljIGludCBldGhfZGV2X2V2ZW50X2NhbGxi
YWNrX3JlZ2lzdGVyKHZvaWQpOw0KPiAtc3RhdGljIGludCBldGhfZGV2X2V2ZW50X2NhbGxiYWNr
X3VucmVnaXN0ZXIodm9pZCk7DQo+IC0NCj4gDQo+ICAvKg0KPiAgICogQ2hlY2sgaWYgYWxsIHRo
ZSBwb3J0cyBhcmUgc3RhcnRlZC4NCj4gQEAgLTE5NTQsMzkgKzE5NTEsNiBAQCByZXNldF9wb3J0
KHBvcnRpZF90IHBpZCkNCj4gIAlwcmludGYoIkRvbmVcbiIpOw0KPiAgfQ0KPiANCj4gLXN0YXRp
YyBpbnQNCj4gLWV0aF9kZXZfZXZlbnRfY2FsbGJhY2tfcmVnaXN0ZXIodm9pZCkNCj4gLXsNCj4g
LQlpbnQgcmV0Ow0KPiAtDQo+IC0JLyogcmVnaXN0ZXIgdGhlIGRldmljZSBldmVudCBjYWxsYmFj
ayAqLw0KPiAtCXJldCA9IHJ0ZV9kZXZfZXZlbnRfY2FsbGJhY2tfcmVnaXN0ZXIoTlVMTCwNCj4g
LQkJZXRoX2Rldl9ldmVudF9jYWxsYmFjaywgTlVMTCk7DQo+IC0JaWYgKHJldCkgew0KPiAtCQlw
cmludGYoIkZhaWxlZCB0byByZWdpc3RlciBkZXZpY2UgZXZlbnQgY2FsbGJhY2tcbiIpOw0KPiAt
CQlyZXR1cm4gLTE7DQo+IC0JfQ0KPiAtDQo+IC0JcmV0dXJuIDA7DQo+IC19DQo+IC0NCj4gLQ0K
PiAtc3RhdGljIGludA0KPiAtZXRoX2Rldl9ldmVudF9jYWxsYmFja191bnJlZ2lzdGVyKHZvaWQp
DQo+IC17DQo+IC0JaW50IHJldDsNCj4gLQ0KPiAtCS8qIHVucmVnaXN0ZXIgdGhlIGRldmljZSBl
dmVudCBjYWxsYmFjayAqLw0KPiAtCXJldCA9IHJ0ZV9kZXZfZXZlbnRfY2FsbGJhY2tfdW5yZWdp
c3RlcihOVUxMLA0KPiAtCQlldGhfZGV2X2V2ZW50X2NhbGxiYWNrLCBOVUxMKTsNCj4gLQlpZiAo
cmV0IDwgMCkgew0KPiAtCQlwcmludGYoIkZhaWxlZCB0byB1bnJlZ2lzdGVyIGRldmljZSBldmVu
dCBjYWxsYmFja1xuIik7DQo+IC0JCXJldHVybiAtMTsNCj4gLQl9DQo+IC0NCj4gLQlyZXR1cm4g
MDsNCj4gLX0NCj4gLQ0KPiAgdm9pZA0KPiAgYXR0YWNoX3BvcnQoY2hhciAqaWRlbnRpZmllcikN
Cj4gIHsNCj4gQEAgLTIwOTMsMTQgKzIwNTcsMjUgQEAgcG1kX3Rlc3RfZXhpdCh2b2lkKQ0KPiAN
Cj4gIAlpZiAoaG90X3BsdWcpIHsNCj4gIAkJcmV0ID0gcnRlX2Rldl9ldmVudF9tb25pdG9yX3N0
b3AoKTsNCj4gLQkJaWYgKHJldCkNCj4gKwkJaWYgKHJldCkgew0KPiAgCQkJUlRFX0xPRyhFUlIs
IEVBTCwNCj4gIAkJCQkiZmFpbCB0byBzdG9wIGRldmljZSBldmVudCBtb25pdG9yLiIpOw0KPiAr
CQkJcmV0dXJuOw0KPiArCQl9DQo+IA0KPiAtCQlyZXQgPSBldGhfZGV2X2V2ZW50X2NhbGxiYWNr
X3VucmVnaXN0ZXIoKTsNCj4gLQkJaWYgKHJldCkNCj4gKwkJcmV0ID0gcnRlX2Rldl9ldmVudF9j
YWxsYmFja191bnJlZ2lzdGVyKE5VTEwsDQo+ICsJCQlldGhfZGV2X2V2ZW50X2NhbGxiYWNrLCBO
VUxMKTsNCj4gKwkJaWYgKHJldCA8IDApIHsNCj4gKwkJCXByaW50ZigiZmFpbCB0byB1bnJlZ2lz
dGVyIGRldmljZSBldmVudCBjYWxsYmFjay5cbiIpOw0KDQpCZXR0ZXIgdG8gdXNlIFJURV9MT0co
KSAgaW5zdGVhZCBvZiBwcmludGYoKS4NCg0KPiArCQkJcmV0dXJuOw0KPiArCQl9DQo+ICsNCj4g
KwkJcmV0ID0gcnRlX2Rldl9ob3RwbHVnX2hhbmRsZV9kaXNhYmxlKCk7DQo+ICsJCWlmIChyZXQp
IHsNCj4gIAkJCVJURV9MT0coRVJSLCBFQUwsDQo+IC0JCQkJImZhaWwgdG8gdW5yZWdpc3RlciBh
bGwgZXZlbnQgY2FsbGJhY2tzLiIpOw0KPiArCQkJCSJmYWlsIHRvIGRpc2FibGUgaG90cGx1ZyBo
YW5kbGluZy5cbiIpOw0KPiArCQkJcmV0dXJuOw0KPiArCQl9DQo+ICAJfQ0KPiANCj4gIAlwcmlu
dGYoIlxuQnllLi4uXG4iKTsNCj4gQEAgLTIyNDQsNiArMjIxOSw5IEBAIHN0YXRpYyB2b2lkDQo+
ICBldGhfZGV2X2V2ZW50X2NhbGxiYWNrKGNoYXIgKmRldmljZV9uYW1lLCBlbnVtIHJ0ZV9kZXZf
ZXZlbnRfdHlwZSB0eXBlLA0KPiAgCQkJICAgICBfX3J0ZV91bnVzZWQgdm9pZCAqYXJnKQ0KPiAg
ew0KPiArCXVpbnQxNl90IHBvcnRfaWQ7DQo+ICsJaW50IHJldDsNCj4gKw0KPiAgCWlmICh0eXBl
ID49IFJURV9ERVZfRVZFTlRfTUFYKSB7DQo+ICAJCWZwcmludGYoc3RkZXJyLCAiJXMgY2FsbGVk
IHVwb24gaW52YWxpZCBldmVudCAlZFxuIiwNCj4gIAkJCV9fZnVuY19fLCB0eXBlKTsNCj4gQEAg
LTIyNTQsOSArMjIzMiwxMyBAQCBldGhfZGV2X2V2ZW50X2NhbGxiYWNrKGNoYXIgKmRldmljZV9u
YW1lLCBlbnVtDQo+IHJ0ZV9kZXZfZXZlbnRfdHlwZSB0eXBlLA0KPiAgCWNhc2UgUlRFX0RFVl9F
VkVOVF9SRU1PVkU6DQo+ICAJCVJURV9MT0coRVJSLCBFQUwsICJUaGUgZGV2aWNlOiAlcyBoYXMg
YmVlbiByZW1vdmVkIVxuIiwNCj4gIAkJCWRldmljZV9uYW1lKTsNCj4gLQkJLyogVE9ETzogQWZ0
ZXIgZmluaXNoIGZhaWx1cmUgaGFuZGxlLCBiZWdpbiB0byBzdG9wDQo+IC0JCSAqIHBhY2tldCBm
b3J3YXJkLCBzdG9wIHBvcnQsIGNsb3NlIHBvcnQsIGRldGFjaCBwb3J0Lg0KPiAtCQkgKi8NCj4g
KwkJcmV0ID0gcnRlX2V0aF9kZXZfZ2V0X3BvcnRfYnlfbmFtZShkZXZpY2VfbmFtZSwgJnBvcnRf
aWQpOw0KPiArCQlpZiAocmV0KSB7DQo+ICsJCQlSVEVfTE9HKEVSUiwgRUFMLCAiY2FuIG5vdCBn
ZXQgcG9ydCBieSBkZXZpY2UgJXMhXG4iLA0KPiArCQkJCWRldmljZV9uYW1lKTsNCj4gKwkJCXJl
dHVybjsNCj4gKwkJfQ0KPiArCQlybXZfZXZlbnRfY2FsbGJhY2soKHZvaWQgKikoaW50cHRyX3Qp
cG9ydF9pZCk7DQo+ICAJCWJyZWFrOw0KPiAgCWNhc2UgUlRFX0RFVl9FVkVOVF9BREQ6DQo+ICAJ
CVJURV9MT0coRVJSLCBFQUwsICJUaGUgZGV2aWNlOiAlcyBoYXMgYmVlbiBhZGRlZCFcbiIsIEBA
IC0NCj4gMjc3OSwxNCArMjc2MSwyNiBAQCBtYWluKGludCBhcmdjLCBjaGFyKiogYXJndikNCj4g
IAlpbml0X2NvbmZpZygpOw0KPiANCj4gIAlpZiAoaG90X3BsdWcpIHsNCj4gLQkJLyogZW5hYmxl
IGhvdCBwbHVnIG1vbml0b3JpbmcgKi8NCj4gKwkJcmV0ID0gcnRlX2Rldl9ob3RwbHVnX2hhbmRs
ZV9lbmFibGUoKTsNCj4gKwkJaWYgKHJldCkgew0KPiArCQkJUlRFX0xPRyhFUlIsIEVBTCwNCj4g
KwkJCQkiZmFpbCB0byBlbmFibGUgaG90cGx1ZyBoYW5kbGluZy4iKTsNCj4gKwkJCXJldHVybiAt
MTsNCj4gKwkJfQ0KPiArDQo+ICAJCXJldCA9IHJ0ZV9kZXZfZXZlbnRfbW9uaXRvcl9zdGFydCgp
Ow0KPiAgCQlpZiAocmV0KSB7DQo+IC0JCQlydGVfZXJybm8gPSBFSU5WQUw7DQo+ICsJCQlSVEVf
TE9HKEVSUiwgRUFMLA0KPiArCQkJCSJmYWlsIHRvIHN0YXJ0IGRldmljZSBldmVudCBtb25pdG9y
aW5nLiIpOw0KPiAgCQkJcmV0dXJuIC0xOw0KPiAgCQl9DQo+IC0JCWV0aF9kZXZfZXZlbnRfY2Fs
bGJhY2tfcmVnaXN0ZXIoKTsNCj4gDQo+ICsJCXJldCA9IHJ0ZV9kZXZfZXZlbnRfY2FsbGJhY2tf
cmVnaXN0ZXIoTlVMTCwNCj4gKwkJCWV0aF9kZXZfZXZlbnRfY2FsbGJhY2ssIE5VTEwpOw0KPiAr
CQlpZiAocmV0KSB7DQo+ICsJCQlwcmludGYoImZhaWxlIHRvIHJlZ2lzdGVyIGRldmljZSBldmVu
dCBjYWxsYmFja1xuIik7DQoNCkJldHRlciB0byB1c2UgUlRFX0xPRygpIGluc3RlYWQgb2YgcGVp
bnRmKCkuIE5vdGUgdHlwZSBpbiBtZXNzYWdlLCAiZmFpbGUiIHNob3VsZCBiZSAiZmFpbGVkIg0K
DQo+ICsJCQlyZXR1cm4gLTE7DQo+ICsJCX0NCj4gIAl9DQo+IA0KPiAgCWlmIChzdGFydF9wb3J0
KFJURV9QT1JUX0FMTCkgIT0gMCkNCj4gLS0NCj4gMi43LjQNCg0K