From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Iremonger, Bernard" Subject: Re: [PATCH 2/6] examples/ipsec-secgw: fix 1st packet dropped patch two Date: Thu, 7 Mar 2019 09:54:38 +0000 Message-ID: <8CEF83825BEC744B83065625E567D7C260D6AA6F@IRSMSX108.ger.corp.intel.com> References: <1551888011-27692-1-git-send-email-bernard.iremonger@intel.com> <1551888011-27692-3-git-send-email-bernard.iremonger@intel.com> <2601191342CEEE43887BDE71AB9772580124140E49@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "stable@dpdk.org" To: "Ananyev, Konstantin" , "dev@dpdk.org" , "akhil.goyal@nxp.com" Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB9772580124140E49@irsmsx105.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, > Subject: RE: [PATCH 2/6] examples/ipsec-secgw: fix 1st packet dropped pat= ch > two >=20 >=20 > Hi Bernard, >=20 > > > > Call create_inline_session() at initialisition in sa.c Call > > rte_ipsec_session_prepare() in fill_ipsec_session() for inline. >=20 > Here and in other places - it probably worth to explain what is the purpo= se for > these changes. I will improve explanation. > As a side notice, as these series fixes that problem, it probably worse t= o add a > patch into series that removes the following: >=20 > # to overcome problem with ipsec-secgw for inline mode, > # when first packet(s) will be always dropped. > # note that ping will fail here > ssh ${REMOTE_HOST} ping -c 1 ${LOCAL_IPV4} >=20 > from examples/ipsec-secgw/test/(tun|trs)_aesgcm_defs.sh > Konstantin I will add a patch to fix the test scripts. Regards, Bernard.