All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Ayush Garg <ayush.garg@samsung.com>
Cc: linux-bluetooth@vger.kernel.org, anupam.r@samsung.com,
	nitin.j@samsung.com
Subject: Re: [PATCH BlueZ 1/7] doc/adapter-api: Add SupportedPhyConfiguration property
Date: Thu, 22 Jul 2021 16:46:09 +0200	[thread overview]
Message-ID: <8D60ECE9-A8DA-46D7-A505-C841AB6330A2@holtmann.org> (raw)
In-Reply-To: <20210722052640.5863-2-ayush.garg@samsung.com>

Hi Aysush,

> This change add a new property to retrieve the PHYs
> supported by the controller.
> 
> Reviewed-by: Anupam Roy <anupam.r@samsung.com>
> ---
> doc/adapter-api.txt | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
> 
> diff --git a/doc/adapter-api.txt b/doc/adapter-api.txt
> index 464434a81..25e370d75 100644
> --- a/doc/adapter-api.txt
> +++ b/doc/adapter-api.txt
> @@ -335,3 +335,24 @@ Properties	string Address [readonly]
> 				"peripheral": Supports the peripheral role.
> 				"central-peripheral": Supports both roles
> 						      concurrently.
> +
> +		array{string} SupportedPhyConfiguration [readonly]
> +
> +			List of PHYs supported by the controller.
> +
> +			Possible values:
> +				"BR1M1SLOT"
> +				"BR1M3SLOT"
> +				"BR1M5SLOT"
> +				"EDR2M1SLOT"
> +				"EDR2M3SLOT"
> +				"EDR2M5SLOT"
> +				"EDR3M1SLOT"
> +				"EDR3M3SLOT"
> +				"EDR3M5SLOT"
> +				"LE1MTX"
> +				"LE1MRX"
> +				"LE2MTX"
> +				"LE2MRX"
> +				"LECODEDTX"
> +				"LECODEDRX"

we don’t do string constants like this in D-Bus API. They are lowercase and verbose “br-1m-1slot” etc. at least.

Regards

Marcel


  parent reply	other threads:[~2021-07-22 14:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210722052737epcas5p1682a7f66d42470c3cdb8dd04160912ab@epcas5p1.samsung.com>
2021-07-22  5:26 ` [PATCH BlueZ 0/7] Support for Adapter's Default PHY Configuration Ayush Garg
     [not found]   ` <CGME20210722052738epcas5p3b6074e49f088159e8282bba3457d56ba@epcas5p3.samsung.com>
2021-07-22  5:26     ` [PATCH BlueZ 1/7] doc/adapter-api: Add SupportedPhyConfiguration property Ayush Garg
2021-07-22  6:45       ` Support for Adapter's Default PHY Configuration bluez.test.bot
2021-07-22 14:46       ` Marcel Holtmann [this message]
     [not found]   ` <CGME20210722052739epcas5p4412d38b394f51ab195c77c887f0a0aaf@epcas5p4.samsung.com>
2021-07-22  5:26     ` [PATCH BlueZ 2/7] doc/adapter-api: Add PhyConfiguration property Ayush Garg
2021-07-22 17:20       ` Luiz Augusto von Dentz
     [not found]   ` <CGME20210722052740epcas5p1fce869a24434f376d111e9e5d4b208eb@epcas5p1.samsung.com>
2021-07-22  5:26     ` [PATCH BlueZ 3/7] adapter: Add support for get/set phy configuration property Ayush Garg
     [not found]   ` <CGME20210722052741epcas5p2cb3cbad65a301b0ec0cf1780c0920103@epcas5p2.samsung.com>
2021-07-22  5:26     ` [PATCH BlueZ 4/7] adapter: Add support for the get supported phy property Ayush Garg
     [not found]   ` <CGME20210722052742epcas5p1b53db2cd68028170a86f291bd052bf14@epcas5p1.samsung.com>
2021-07-22  5:26     ` [PATCH BlueZ 5/7] adapter: Add support for PHY Configuration Changed event Ayush Garg
     [not found]   ` <CGME20210722052743epcas5p34af6f55c11db2e8909c2730fae7e1cac@epcas5p3.samsung.com>
2021-07-22  5:26     ` [PATCH BlueZ 6/7] client: Add support for get/set PHY configuration in bluetoothctl Ayush Garg
     [not found]   ` <CGME20210722052744epcas5p46996d48d12500c39b4b63dfcecd30d37@epcas5p4.samsung.com>
2021-07-22  5:26     ` [PATCH BlueZ 7/7] adapter: Save PHY Configuration in storage and read it at init Ayush Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8D60ECE9-A8DA-46D7-A505-C841AB6330A2@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=anupam.r@samsung.com \
    --cc=ayush.garg@samsung.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=nitin.j@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.