From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752483AbdLUOwU (ORCPT ); Thu, 21 Dec 2017 09:52:20 -0500 Received: from mxout2.idt.com ([157.165.5.26]:36789 "EHLO mxout2.idt.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbdLUOwS (ORCPT ); Thu, 21 Dec 2017 09:52:18 -0500 From: "Bounine, Alexandre" To: SF Markus Elfring , "kernel-janitors@vger.kernel.org" , "Matt Porter" , Andrew Morton CC: LKML Subject: RE: [PATCH 0/7] RapidIO: Adjustments for some function implementations Thread-Topic: [PATCH 0/7] RapidIO: Adjustments for some function implementations Thread-Index: AQHTdY86ezzGt9MZekqXlkCeBSmGE6NN2iCA Date: Thu, 21 Dec 2017 13:51:05 +0000 Message-ID: <8D983423E7EDF846BB3056827B8CC5D161B3BCB2@corpmail1> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.165.140.50] x-tm-as-matchedid: 150567-701625-704425-700685-139006-700486-711995-703523-7 00648-106660-863828-708797-702143-706290-704496-701604-847575-700476-702737 -700324-700264-700151-709859-121336-148004-148133-42000-42003-63 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id vBLEqPT0021340 Acked-by: Alexandre Bounine -----Original Message----- From: SF Markus Elfring [mailto:elfring@users.sourceforge.net] Sent: Friday, December 15, 2017 5:27 AM To: kernel-janitors@vger.kernel.org; Bounine, Alexandre ; Matt Porter Cc: LKML Subject: [PATCH 0/7] RapidIO: Adjustments for some function implementations From: Markus Elfring Date: Fri, 15 Dec 2017 11:20:33 +0100 Some update suggestions were taken into account from static source code analysis. Markus Elfring (7): Delete an error message for a failed memory allocation in rio_init_mports() Adjust 12 checks for null pointers Adjust five function calls together with a variable assignment Improve a size determination in five functions Delete an unnecessary variable initialisation in three functions Return an error code only as a constant in two functions Move 12 EXPORT_SYMBOL_GPL() calls to function implementations drivers/rapidio/rio.c | 110 ++++++++++++++++++++++---------------------------- 1 file changed, 48 insertions(+), 62 deletions(-) -- 2.15.1 From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bounine, Alexandre" Date: Thu, 21 Dec 2017 13:51:05 +0000 Subject: RE: [PATCH 0/7] RapidIO: Adjustments for some function implementations Message-Id: <8D983423E7EDF846BB3056827B8CC5D161B3BCB2@corpmail1> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , "kernel-janitors@vger.kernel.org" , Matt Porter , Andrew Morton Cc: LKML QWNrZWQtYnk6IEFsZXhhbmRyZSBCb3VuaW5lIDxhbGV4YW5kcmUuYm91bmluZUBpZHQuY29tPg0K DQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogU0YgTWFya3VzIEVsZnJpbmcgW21h aWx0bzplbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdlLm5ldF0gDQpTZW50OiBGcmlkYXksIERlY2Vt YmVyIDE1LCAyMDE3IDU6MjcgQU0NClRvOiBrZXJuZWwtamFuaXRvcnNAdmdlci5rZXJuZWwub3Jn OyBCb3VuaW5lLCBBbGV4YW5kcmUgPEFsZXhhbmRyZS5Cb3VuaW5lQGlkdC5jb20+OyBNYXR0IFBv cnRlciA8bXBvcnRlckBrZXJuZWwuY3Jhc2hpbmcub3JnPg0KQ2M6IExLTUwgPGxpbnV4LWtlcm5l bEB2Z2VyLmtlcm5lbC5vcmc+DQpTdWJqZWN0OiBbUEFUQ0ggMC83XSBSYXBpZElPOiBBZGp1c3Rt ZW50cyBmb3Igc29tZSBmdW5jdGlvbiBpbXBsZW1lbnRhdGlvbnMNCg0KRnJvbTogTWFya3VzIEVs ZnJpbmcgPGVsZnJpbmdAdXNlcnMuc291cmNlZm9yZ2UubmV0Pg0KRGF0ZTogRnJpLCAxNSBEZWMg MjAxNyAxMToyMDozMyArMDEwMA0KDQpTb21lIHVwZGF0ZSBzdWdnZXN0aW9ucyB3ZXJlIHRha2Vu IGludG8gYWNjb3VudA0KZnJvbSBzdGF0aWMgc291cmNlIGNvZGUgYW5hbHlzaXMuDQoNCk1hcmt1 cyBFbGZyaW5nICg3KToNCiAgRGVsZXRlIGFuIGVycm9yIG1lc3NhZ2UgZm9yIGEgZmFpbGVkIG1l bW9yeSBhbGxvY2F0aW9uIGluIHJpb19pbml0X21wb3J0cygpDQogIEFkanVzdCAxMiBjaGVja3Mg Zm9yIG51bGwgcG9pbnRlcnMNCiAgQWRqdXN0IGZpdmUgZnVuY3Rpb24gY2FsbHMgdG9nZXRoZXIg d2l0aCBhIHZhcmlhYmxlIGFzc2lnbm1lbnQNCiAgSW1wcm92ZSBhIHNpemUgZGV0ZXJtaW5hdGlv biBpbiBmaXZlIGZ1bmN0aW9ucw0KICBEZWxldGUgYW4gdW5uZWNlc3NhcnkgdmFyaWFibGUgaW5p dGlhbGlzYXRpb24gaW4gdGhyZWUgZnVuY3Rpb25zDQogIFJldHVybiBhbiBlcnJvciBjb2RlIG9u bHkgYXMgYSBjb25zdGFudCBpbiB0d28gZnVuY3Rpb25zDQogIE1vdmUgMTIgRVhQT1JUX1NZTUJP TF9HUEwoKSBjYWxscyB0byBmdW5jdGlvbiBpbXBsZW1lbnRhdGlvbnMNCg0KIGRyaXZlcnMvcmFw aWRpby9yaW8uYyB8IDExMCArKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQ0KIDEgZmlsZSBjaGFuZ2VkLCA0OCBpbnNlcnRpb25zKCspLCA2MiBkZWxldGlv bnMoLSkNCg0KLS0gDQoyLjE1LjENCg0K