From: Marcel Holtmann <marcel@holtmann.org>
To: tjiang@codeaurora.org
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
Balakrishna Godavarthi <bgodavar@codeaurora.org>,
c-hbandi@codeaurora.org, Hemantg <hemantg@codeaurora.org>,
Matthias Kaehlcke <mka@chromium.org>,
Rocky Liao <rjliao@codeaurora.org>,
zijuhu@codeaurora.org
Subject: Re: [PATCH v3] Bluetooth: btusb: re-definition for board_id in struct qca_version
Date: Tue, 9 Nov 2021 10:37:31 +0100 [thread overview]
Message-ID: <8E687716-E810-4A46-B010-A08BB261D2FF@holtmann.org> (raw)
In-Reply-To: <305e41a55a4c117da86f786c374a57dc@codeaurora.org>
Hi Tim,
> As qc btsoc will using big-endian for boardID, so align host with it.
>
> Signed-off-by: Tim Jiang <tjiang@codeaurora.org>
> ---
> drivers/bluetooth/btusb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 46d892bbde62..a51b1d641043 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2883,7 +2883,7 @@ struct qca_version {
> __le32 rom_version;
> __le32 patch_version;
> __le32 ram_version;
> - __le16 board_id;
> + __u8 board_id[2];
> __le16 flag;
> __u8 reserved[4];
> } __packed;
> @@ -3072,7 +3072,7 @@ static void btusb_generate_qca_nvm_name(char *fwname, size_t max_size,
> u16 flag = le16_to_cpu(ver->flag);
>
> if (((flag >> 8) & 0xff) == QCA_FLAG_MULTI_NVM) {
> - u16 board_id = le16_to_cpu(ver->board_id);
> + u16 board_id = (ver->board_id[0] << 8) + ver->board_id[1];
> const char *variant;
>
> switch (le32_to_cpu(ver->ram_version)) {
explain to me why I would merge this. The commit message is sparse even after I asked to explain things.
I am also not merging this handwaving endian handling. Define it is be16 or le16 and clearly state what it is. If Qualcomm screwed up the memory layout of their NVM, then say that.
Regards
Marcel
next prev parent reply other threads:[~2021-11-09 9:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 7:01 [PATCH v3] Bluetooth: btusb: re-definition for board_id in struct qca_version tjiang
2021-11-09 9:37 ` Marcel Holtmann [this message]
2021-11-15 10:04 ` tjiang
2021-11-15 17:30 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8E687716-E810-4A46-B010-A08BB261D2FF@holtmann.org \
--to=marcel@holtmann.org \
--cc=bgodavar@codeaurora.org \
--cc=c-hbandi@codeaurora.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=mka@chromium.org \
--cc=rjliao@codeaurora.org \
--cc=tjiang@codeaurora.org \
--cc=zijuhu@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.