From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA494C4363D for ; Wed, 7 Oct 2020 13:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 853722087D for ; Wed, 7 Oct 2020 13:46:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ycvMfbZv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728428AbgJGNqM (ORCPT ); Wed, 7 Oct 2020 09:46:12 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:34142 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728177AbgJGNqL (ORCPT ); Wed, 7 Oct 2020 09:46:11 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 097DZf7n182013; Wed, 7 Oct 2020 13:45:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=olvT5p6ERpG8BK2fT6Llv2Cod2X9X+lOuiPuLCGCzA0=; b=ycvMfbZvIk2wMkCfN9WXAPvCLoI8hklXeo8XfHAagsHw1Z7ZTTzChg8ybfeshfqqmFfQ KhP0VdRz9hse2FSJJLCYQc9eCgXlXyK3LniWYlvwMylYM+T+rd4N4A8V+PPUebXcZn1i ZjctOubnfPzCGl9BFAHr+SCQ2nEZY9S8UzYZ++tw0dCeU3YzRvepdGaAKZxqO/3T976V qIfGtiRZNrm/mtDgiJUDAIHg8IhePOZ3HC27+Ep6RPFCdbAAuzQsEEeUEbCGyCRJRw+D BBnfnFXBHRUGx3k8mUenOYRapLzaBEmIldSO/yIA0Ox4p0KlQ7xmaWV/g37cnWC+FqSL 1Q== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 33xhxn1rmc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 07 Oct 2020 13:45:55 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 097DaRvM132654; Wed, 7 Oct 2020 13:45:55 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 33y37yk901-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 07 Oct 2020 13:45:55 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 097DjrxA032509; Wed, 7 Oct 2020 13:45:53 GMT Received: from anon-dhcp-152.1015granger.net (/68.61.232.219) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 07 Oct 2020 06:45:53 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: unsharing tcp connections from different NFS mounts From: Chuck Lever In-Reply-To: <5B5CF80C-494A-42D3-8D3F-51C0277D9E1B@redhat.com> Date: Wed, 7 Oct 2020 09:45:50 -0400 Cc: Bruce Fields , Olga Kornievskaia , Linux NFS Mailing List Content-Transfer-Encoding: quoted-printable Message-Id: <8ED5511E-25DE-4C06-9E26-A1947383C86A@oracle.com> References: <20201006151335.GB28306@fieldses.org> <95542179-0C20-4A1F-A835-77E73AD70DB8@redhat.com> <20201007001814.GA5138@fieldses.org> <57E3293C-5C49-4A80-957B-E490E6A9B32E@redhat.com> <5B5CF80C-494A-42D3-8D3F-51C0277D9E1B@redhat.com> To: Benjamin Coddington X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9766 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 malwarescore=0 suspectscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010070089 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9766 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 bulkscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 phishscore=0 mlxlogscore=999 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2010070089 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org > On Oct 7, 2020, at 8:55 AM, Benjamin Coddington = wrote: >=20 > On 7 Oct 2020, at 7:27, Benjamin Coddington wrote: >=20 >> On 6 Oct 2020, at 20:18, J. Bruce Fields wrote: >>=20 >>> On Tue, Oct 06, 2020 at 05:46:11PM -0400, Olga Kornievskaia wrote: >>>> On Tue, Oct 6, 2020 at 3:38 PM Benjamin Coddington = wrote: >>>>>=20 >>>>> On 6 Oct 2020, at 11:13, J. Bruce Fields wrote: >=20 >>> Looks like nfs4_init_{non}uniform_client_string() stores it in >>> cl_owner_id, and I was thinking that meant cl_owner_id would be used >>> from then on.... >>>=20 >>> But actually, I think it may run that again on recovery, yes, so I = bet >>> changing the nfs4_unique_id parameter midway like this could cause = bugs >>> on recovery. >>=20 >> Ah, that's what I thought as well. Thanks for looking closer Olga! >=20 > Well, no -- it does indeed continue to use the original cl_owner_id. = We > only jump through nfs4_init_uniquifier_client_string() if cl_owner_id = is > NULL: >=20 > 6087 static int > 6088 nfs4_init_uniform_client_string(struct nfs_client *clp) > 6089 { > 6090 size_t len; > 6091 char *str; > 6092 > 6093 if (clp->cl_owner_id !=3D NULL) > 6094 return 0; > 6095 > 6096 if (nfs4_client_id_uniquifier[0] !=3D '\0') > 6097 return nfs4_init_uniquifier_client_string(clp); > 6098 >=20 >=20 > Testing proves this out as well for both EXCHANGE_ID and SETCLIENTID. >=20 > Is there any precedent for stabilizing module parameters as part of a > supported interface? Maybe this ought to be a mount option, so client = can > set a uniquifier per-mount. The protocol is designed as one client-ID per client. FreeBSD is the only client I know of that uses one client-ID per mount, fwiw. You are suggesting each mount point would have its own lease. There would likely be deeper implementation changes needed than just specifying a unique client-ID for each mount point. -- Chuck Lever