From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bear.ext.ti.com (bear.ext.ti.com [192.94.94.41]) by arago-project.org (Postfix) with ESMTPS id EE7AE529B0 for ; Fri, 30 Aug 2013 15:44:26 +0000 (UTC) Received: from dlelxv90.itg.ti.com ([172.17.2.17]) by bear.ext.ti.com (8.13.7/8.13.7) with ESMTP id r7UFiQXV000310 for ; Fri, 30 Aug 2013 10:44:26 -0500 Received: from DFLE72.ent.ti.com (dfle72.ent.ti.com [128.247.5.109]) by dlelxv90.itg.ti.com (8.14.3/8.13.8) with ESMTP id r7UFiQvx015707 for ; Fri, 30 Aug 2013 10:44:26 -0500 Received: from DFLE08.ent.ti.com ([fe80::187f:8c86:2b7:ef9f]) by DFLE72.ent.ti.com ([fe80::e5e2:bab6:34dc:a483%28]) with mapi id 14.02.0342.003; Fri, 30 Aug 2013 10:44:26 -0500 From: "Cooper Jr., Franklin" To: "Maupin, Chase" , "meta-arago@arago-project.org" Thread-Topic: [meta-arago] [PATCH 1/6 v2] gst-plugins-bad: Use new PACKAGECONFIG feature Thread-Index: AQHOpZIfcSVLPP6Dv0u6laupTE6oQJmt4Pig Date: Fri, 30 Aug 2013 15:44:26 +0000 Message-ID: <8F29D6B095ED194EA1980491A5E029710C53FD63@DFLE08.ent.ti.com> References: <1377633092-29917-1-git-send-email-fcooper@ti.com> <7D46E86EC0A8354091174257B2FED101596F8113@DLEE11.ent.ti.com> In-Reply-To: <7D46E86EC0A8354091174257B2FED101596F8113@DLEE11.ent.ti.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.170.170.90] MIME-Version: 1.0 Subject: Re: [PATCH 1/6 v2] gst-plugins-bad: Use new PACKAGECONFIG feature X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Aug 2013 15:44:27 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Maupin, Chase > Sent: Friday, August 30, 2013 10:04 AM > To: Cooper Jr., Franklin; meta-arago@arago-project.org > Subject: RE: [meta-arago] [PATCH 1/6 v2] gst-plugins-bad: Use new > PACKAGECONFIG feature >=20 > >-----Original Message----- > >From: meta-arago-bounces@arago-project.org [mailto:meta-arago- > >bounces@arago-project.org] On Behalf Of Cooper Jr., Franklin > >Sent: Tuesday, August 27, 2013 2:51 PM > >To: meta-arago@arago-project.org > >Cc: Cooper Jr., Franklin > >Subject: [meta-arago] [PATCH 1/6 v2] gst-plugins-bad: Use new > >PACKAGECONFIG feature > > > >* Recent patch in oe-core allows certain features to be enabled or > >disabled > > based on the PACKAGECONFIG variable. > >* Use this variable which will obsolete alot of the code in this > >bbappend while > > achieving the same result. > > > >Signed-off-by: Franklin S. Cooper Jr > >--- > >Version 2 changes: > >Update patch tailored to recent change to base recipe in oe-core. > > > > > > .../gstreamer/gst-plugins-bad_0.10.23.bbappend | 14 ++----- > >------- > > 1 files changed, 2 insertions(+), 12 deletions(-) > > > >diff --git a/meta-arago-distro/recipes-multimedia/gstreamer/gst- > >plugins-bad_0.10.23.bbappend b/meta-arago-distro/recipes- > >multimedia/gstreamer/gst-plugins-bad_0.10.23.bbappend > >index 8ae8050..8cee785 100644 > >--- a/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins- > >bad_0.10.23.bbappend > >+++ b/meta-arago-distro/recipes-multimedia/gstreamer/gst-plugins- > >bad_0.10.23.bbappend > >@@ -1,21 +1,11 @@ > >-PR_append =3D "-arago3" > >+PR_append =3D "-arago4" > > > > # look for files in this layer first > > FILESEXTRAPATHS_prepend :=3D "${THISDIR}/${PN}:" > > > >-# Disable rsvg which caused gtk+ to be pulled in -DEPENDS :=3D > >"${@oe_filter_out('librsvg','${DEPENDS}', d)}" > >-EXTRA_OECONF +=3D "--disable-rsvg" > >- > >-# Remove the restriction of which plugins are built. Previously > >fbdevsink -# was not built which is needed by the gstreamer demos > >included in the SDK. > >-EXTRA_OECONF :=3D "${@oe_filter_out('--with- > >plugins=3Dmusicbrainz,wavpack,ivorbis,mpegvideoparse','${EXTRA_OECON > >F}', d)}" >=20 > I'm assuming that these are removed because of the COMMERCIAL filter sett= ing > (I don't remember the full variable off the top of my head) >=20 > Should this be called out in the commit message? [Franklin] So this oe_filter_out wasn't due to COMMERCIAL filter it was due= to with-plugins will only build plugins in the list. So by filtering out t= hat string gst-plugins-bad will attempt to build all plugins. Further down in the recipe you can see where certain plugins are explicitly= removed because of license reasoning. There is even a comment about it add= ressing that. >=20 > >- > > SRC_URI +=3D "file://0001-gstfbdevsink-Fix-depth-value-for- > >GST_VIDEO_CAPS_RGB_.patch" > > > >-# Add faad has a dependency to insure gst-plugins-bad-faad is built. > >-DEPENDS +=3D "faad2" > >-RDEPENDS_${PN}-faad +=3D "libfaad" > >+PACKAGECONFIG =3D "bzip curl faad" >=20 > I have some question here. You changed the DEPENDS to faad instead of fa= ad2. > I see in base.bbclass the DEPENDS magic based on PACKAGECONFIG, but the > RDEPENDS setting there didn't look like it would add libfaad. Maybe I am= just > not reading it right but did you check that? [Franklin] Ah your right. Comment from base.bbclass PACKAGECONFIG[foo] =3D "--enable-foo,--disable-foo,foo_depends,foo_runtime_= depends" Snippet from gst-plugins-bad PACKAGECONFIG[faad] =3D "--enable-faad,--disable-faad,faad2" So I probably need to change the override the above line with PACKAGECONFIG[faad] =3D "--enable-faad,--disable-faad,faad2,libfaad" Let me double check this. >=20 > Also, why add curl and bzip too? If needed should that be a separate pat= ch or at > least updated in the commit message? [Franklin] In the base recipe PACKAGECONFIG is set to "bzip curl". Since I = am adding faad I needed to override that variable but I didn't want to lose= the default. Probably a better approach is PACKAGECONFIG =3D "${PACKAGECONFIG} faad" Although I don't know what ??=3D means so I will have to see if that works. > > > > # Disable features that have potential commercial licensing > >restrictions > > EXTRA_OECONF +=3D "\ > >-- > >1.7.0.4 > > > >_______________________________________________ > >meta-arago mailing list > >meta-arago@arago-project.org > >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago