From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wang, Zhihong" Subject: Re: [PATCH v5 2/6] vhost: rewrite enqueue Date: Mon, 19 Sep 2016 03:29:58 +0000 Message-ID: <8F6C2BD409508844A0EFC19955BE09414E7ABA3A@SHSMSX103.ccr.corp.intel.com> References: <1473392368-84903-1-git-send-email-zhihong.wang@intel.com> <1473392368-84903-3-git-send-email-zhihong.wang@intel.com> <20160918141914.GI23158@yliu-dev.sh.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "thomas.monjalon@6wind.com" To: Yuanhan Liu Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8545F2BB4 for ; Mon, 19 Sep 2016 05:30:03 +0200 (CEST) In-Reply-To: <20160918141914.GI23158@yliu-dev.sh.intel.com> Content-Language: en-US List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > Sent: Sunday, September 18, 2016 10:19 PM > To: Wang, Zhihong > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; > thomas.monjalon@6wind.com > Subject: Re: [PATCH v5 2/6] vhost: rewrite enqueue >=20 > On Thu, Sep 08, 2016 at 11:39:24PM -0400, Zhihong Wang wrote: > > This patch implements the vhost logic from scratch into a single functi= on > > designed for high performance and better maintainability. >=20 > As always, your commit log just states what have been done, but doesn't > tell why such changes have been made. For example, you said "it's designe= d > for high performance", then you'd better explain why your version would > introduce high performance. You need a reason, as well as some numbers > (percent change) to prove it: it's not that right to keep the numbers > inside: I'm sure people outside intel are also willing and happy to know > those numbers. >=20 > For this patch, I think it's more about the maintainability improvement > but not performance: the performance tunning patches are done later > after all. >=20 > Another example is, in patch 6, you said "It reduces CPU pipeline stall > cycles significantly", but you didn't say why there is pipeline stall > before and why your patch reduces it. >=20 > All those are important things that deserves some explanation. So, I'd > ask you to re-visit all your patches in this set, to think what you > could add to make the commit better and more informative. Okay. I'll add more detailed commit log. >=20 > Besides that, I think this patchset looks fine to me. I may just need > another time to look it more carefully, then I think I can merge (v6). >=20 > BTW, thanks for the great work! >=20 > --yliu >=20 > > This is the baseline version of the new code, more optimization will be > > added in the following patches in this patch set. > > > > Signed-off-by: Zhihong Wang > > ---