Re: [PATCH net-next v2] net: ipmr/ip6mr: add support for keeping an entry age

From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	roopa@cumulusnetworks.com, shm@cumulusnetworks.com,
	sashok@cumulusnetworks.com, sharpd@cumulusnetworks.com,
	kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
	kaber@trash.net
Subject: Re: [PATCH net-next v2] net: ipmr/ip6mr: add support for keeping an entry age
Date: Fri, 15 Jul 2016 23:11:15 -0700	[thread overview]
Message-ID: <8FE06EF5-DBAA-4915-938B-A7B7736E5E35@cumulusnetworks.com> (raw)
In-Reply-To: <20160715.225608.440125257853766623.davem@davemloft.net>

> On Jul 15, 2016, at 10:56 PM, David Miller <davem@davemloft.net> wrote:
> 
> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> Date: Thu, 14 Jul 2016 19:28:27 +0300
> 
>> In preparation for hardware offloading of ipmr/ip6mr we need an
>> interface that allows to check (and later update) the age of entries.
>> Relying on stats alone can show activity but not actual age of the entry,
>> furthermore when there're tens of thousands of entries a lot of the
>> hardware implementations only support "hit" bits which are cleared on
>> read to denote that the entry was active and shouldn't be aged out,
>> these can then be naturally translated into age timestamp and will be
>> compatible with the software forwarding age. Using a lastuse entry doesn't
>> affect performance because the members in that cache line are written to
>> along with the age.
>> Since all new users are encouraged to use ipmr via netlink, this is
>> exported via the RTA_EXPIRES attribute.
>> Also do a minor local variable declaration style adjustment - arrange them
>> longest to shortest.
>> 
>> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>> CC: Roopa Prabhu <roopa@cumulusnetworks.com>
>> CC: Shrijeet Mukherjee <shm@cumulusnetworks.com>
>> CC: Satish Ashok <sashok@cumulusnetworks.com>
>> CC: Donald Sharp <sharpd@cumulusnetworks.com>
>> CC: David S. Miller <davem@davemloft.net>
>> CC: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
>> CC: James Morris <jmorris@namei.org>
>> CC: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
>> CC: Patrick McHardy <kaber@trash.net>
>> ---
>> v2: Just reuse RTA_EXPIRES instead to minimize the attr size and simplify,
>> others will be added when needed
> 
> Why are your dates on these changes in the past?
> 
> Having them in the past messes up the ordering on patchwork because
> patchwork orders incoming patches by date, and therefore I can't just
> look at the first page to see "newer" submissions.
> 
> So please don't do whatever propagates commit dates into your emails,
> or whatever is causing this problem.  It's best always to use the
> current time.

Hmm, it seems my VM has its time zone messed up and since I’m in California right now the dates
come out wrong. Sorry about that, would you like me to resubmit the patch ?

Thanks,
 Nik