From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752411AbcAFILg (ORCPT ); Wed, 6 Jan 2016 03:11:36 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.161]:27996 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751999AbcAFIL3 convert rfc822-to-8bit (ORCPT ); Wed, 6 Jan 2016 03:11:29 -0500 X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcKdUCnXG6JabOfSXKWrat+gtPqzo0= X-RZG-CLASS-ID: mo00 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH 1/3] ARM: dts: omap5-board-common: enable rtc and charging of backup battery From: "H. Nikolaus Schaller" In-Reply-To: <20160106010011.GG12777@atomide.com> Date: Wed, 6 Jan 2016 09:11:21 +0100 Cc: Nishanth Menon , =?iso-8859-1?Q?Beno=EEt_Cousson?= , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , linux-omap , devicetree@vger.kernel.org, LKML , Marek Belisko Content-Transfer-Encoding: 8BIT Message-Id: <8FE6954B-6411-4593-9CE5-717A469A6AA8@goldelico.com> References: <568C5451.8070709@ti.com> <20160106010011.GG12777@atomide.com> To: Tony Lindgren , Laxman Dewangan X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tony, Am 06.01.2016 um 02:00 schrieb Tony Lindgren : > * Nishanth Menon [160105 15:40]: >> On 01/05/2016 06:01 AM, H. Nikolaus Schaller wrote: >>> tested on OMP5432 EVM >>> >>> Signed-off-by: H. Nikolaus Schaller >>> --- >>> arch/arm/boot/dts/omap5-board-common.dtsi | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi >>> index 5cf76a1..30c0d3b 100644 >>> --- a/arch/arm/boot/dts/omap5-board-common.dtsi >>> +++ b/arch/arm/boot/dts/omap5-board-common.dtsi >>> @@ -358,6 +358,14 @@ >>> #clock-cells = <0>; >>> }; >>> >>> + rtc { >>> + compatible = "ti,palmas-rtc"; >>> + interrupt-parent = <&palmas>; >>> + interrupts = <8 IRQ_TYPE_NONE>; >> >> IRQ_TYPE_NONE is not correct here -> it should have some polarity - if >> it had none, there'd be no interrupt, right? > > Also I'm not seeing just zeroes coming from RTC after typing hwclock > on omap5-uevm. It's working on x15 though. > > Nikolaus, is hwclock command working for you on omap5-uevm? Well, yes and no. It appears it *was* working when tested last time (we sometimes have months of delay for submitting patches upstream). I have found an SD image with 4.3-rc6 with this patch in the dtb and there it works. With 4.4-rc8 it does not work. hwclock command hangs for 10 seconds (I guess some timeout). I have checked the dtb and in both cases it is interrupts = <8 0>; xxd /sys/firmware/devicetree/base/ocp/i2c@48070000/palmas@48/rtc/interrupts 0000000: 0000 0008 0000 0000 So I think something has changed in the rtc driver or somewhere else. BR, Nikolaus