From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B6C0C32771 for ; Wed, 21 Sep 2022 09:25:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231513AbiIUJZm (ORCPT ); Wed, 21 Sep 2022 05:25:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231458AbiIUJZi (ORCPT ); Wed, 21 Sep 2022 05:25:38 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A95D574E1A; Wed, 21 Sep 2022 02:25:36 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id l14so12195255eja.7; Wed, 21 Sep 2022 02:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:message-id:cc:to:subject:from :date:from:to:cc:subject:date; bh=IE/lUB9GeFJ3cgcWCczdBLBsp8zcC8CA4nMsFXJExts=; b=o1HmafZL8GjyvYOix7SJfx4WJKUR1Bc7OAqttjJ9T0N/Yj/KoCu+7CIoTFiNKbmSRl GO0O9hT6LMnktP8nnM6SrQl4A4F5EzaFjoovPZeVJiVfKsmcFeu4oLmMC0ZR01q5wQqX 9lVBRxxeTKxqXZUHu9XOp+D4p+wdTaqhH2F4wU3KbjMjMlqIEAfpaH+iynNW9GCZ7xDX jE31ceI38vQe8l90z6zWIFTXMkTCGGzfSfcprfmByYV+SOclJHxiRa88je+R/VF2OE/r jm5a75DhyMjEevwPb8xnQSSOogPe+GjqvLNVzzr1+NYuWUoBpTOE8cuesEXbByZ1ddT1 9cZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:in-reply-to:message-id:cc:to:subject:from :date:x-gm-message-state:from:to:cc:subject:date; bh=IE/lUB9GeFJ3cgcWCczdBLBsp8zcC8CA4nMsFXJExts=; b=IPWfPr07qHEqQMppmtaQwJeBrm22Xh6VB1BVHH3iCydWIflrtjNI7V4a5uuSsTWFLf M3FMHmxpG3IlK/TXFwXpeGuwNPQ4HgxpdNgxuN9pg8TsFGPLqnJkNb5cxpgh8zWR+ySv qslGGG/GTxjCq9ZvQbyZiR85xAkU2p+OKJPvkYpQmOdKwHXWwojIlgoEUrUuWLymwC36 XsFcXR7GDveQwo08JBqV7SdBNgP04Yeu6LM9kUxsh5oz9UGchhCSzK4gPb5MCorpS9PC U4yKwqR3Wso1c1MYgmjcAiE2r0dLjrPWQVW8O7LIVDQn7ohRhcm7U9MunBJoEuhTBnql 35fA== X-Gm-Message-State: ACrzQf35WiOH2KmxAAI7gTkwrd387ko/p3jn1EnKaCmKuhiHLVqFNMQG yCyADXFQmODzhVmuWltsj6A= X-Google-Smtp-Source: AMsMyM5aVGhWkOnNJmsBsfyVgjUfb2jYAdOqzt7epbBXN3MqtxhZqf/7Xfo/k1tguHf3FwqbXbSahQ== X-Received: by 2002:a17:907:a044:b0:770:da0d:171d with SMTP id gz4-20020a170907a04400b00770da0d171dmr19485416ejc.742.1663752335121; Wed, 21 Sep 2022 02:25:35 -0700 (PDT) Received: from [10.31.3.208] ([95.183.227.98]) by smtp.gmail.com with ESMTPSA id g2-20020a17090604c200b0072b3406e9c2sm1053996eja.95.2022.09.21.02.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 02:25:34 -0700 (PDT) Date: Wed, 21 Sep 2022 12:25:20 +0300 From: yassine.oudjana@gmail.com Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: Combine MediaTek MT67xx pinctrl binding docs To: Krzysztof Kozlowski Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Andy Teng , AngeloGioacchino Del Regno , Yassine Oudjana , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-Id: <8IZJIR.7AG9DG7U1XLJ@gmail.com> In-Reply-To: References: <20220919170115.94873-1-y.oudjana@protonmail.com> <20220919170115.94873-2-y.oudjana@protonmail.com> X-Mailer: geary/40.0 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Sep 21 2022 at 09:20:43 AM +0200, Krzysztof Kozlowski wrote: > On 19/09/2022 19:01, Yassine Oudjana wrote: >> From: Yassine Oudjana >> >> Documents for MT6779, MT6795 and MT6797 that currently exist share >> most properties, and each one has slightly differently worded >> descriptions for those properties. Combine all three documents into >> one common document for all MT67xx SoC pin controllers, picking a >> few >> parts from each and accounting for differences such as items in reg >> and reg-names properties. Also document the MT6765 pin controller >> which currently has a driver but no DT binding documentation. It >> should >> be possible to also include bindings for MT8183 and MT8188, but >> these >> have some additional properties that might complicate things a bit, >> so they are left alone for now. >> > >> properties: >> compatible: >> - const: mediatek,mt6795-pinctrl >> + oneOf: >> + - enum: >> + - mediatek,mt6765-pinctrl >> + - mediatek,mt6795-pinctrl >> + - mediatek,mt6797-pinctrl >> + - items: >> + - const: mediatek,mt6779-pinctrl >> + - const: syscon > > No, this is not like old bindings at all. It's not merging, it's a > change sneaked inside huge diff. Also - probably totally untested on > DTS > (or old bindings were broken). Actually this change was made specifically so that it remains (probably becomes?) compatible with existing DTS and passes checks. mt6779.dtsi currently has the syscon compatible string but it wasn't listed along with mediatek,mt6779-pinctrl in the old document, but instead there was something in the description about putting the pinctrl node under a syscon node, which isn't the case in the existing DTS. This patch passed both dt_binding_check and dtbs_check. Anyway, I see how I failed to describe this change, so I'll go through the patch again and try to find any other small changes I might've made and forgotten about, and either put them in separate patches or describe them in the commit message, whichever one you think is better. Also, do I make those changes in the original documents then combine or combine first then make them in the new one? Thanks, Yassine (Sorry for the spam, my client was misconfigured so it previously sent HTML instead of plain text.) > > That's a no-go. > > Best regards, > Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA521ECAAD8 for ; Wed, 21 Sep 2022 09:33:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3qLEo0rPoYl6goKGTzbmHtRL7n16iwHktd7s0j32zMs=; b=dyTupv5Athxhrcd4IerNPKaf5j iM+GsUWDhudhq47EiYmefSkSU3AQewKx7zwplI4plJFXom2Ucpvjb1Yd8kSCDVz/C72TrZPt/U7I4 8jto2nHfP1ARfYJ3kBwuFMGuvSVIRsaFDc4ztW53SQkpJAlpgeHztijYpvJQtg1qqIl920RkT1ZmN Gdv7pCyXmw/ZD2vnV8jqFFm02FtE9kwUu6Rfp6SkBqyZ9ONxBiFV8kxresS0AHXIaP0R4HgGAf8L3 L5S65BzSnno4WnE2J1oTCdlpnaxKdlqxcTF/ZbPDYVsRzEgKtFxWXToSKGI055OLukAoDzdzbMr6Q 4JysQhRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaw5G-00AQgB-8Y; Wed, 21 Sep 2022 09:32:01 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oavz9-00ANgu-2f; Wed, 21 Sep 2022 09:25:43 +0000 Received: by mail-ej1-x62d.google.com with SMTP id y17so12216157ejo.6; Wed, 21 Sep 2022 02:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:message-id:cc:to:subject:from :date:from:to:cc:subject:date; bh=IE/lUB9GeFJ3cgcWCczdBLBsp8zcC8CA4nMsFXJExts=; b=o1HmafZL8GjyvYOix7SJfx4WJKUR1Bc7OAqttjJ9T0N/Yj/KoCu+7CIoTFiNKbmSRl GO0O9hT6LMnktP8nnM6SrQl4A4F5EzaFjoovPZeVJiVfKsmcFeu4oLmMC0ZR01q5wQqX 9lVBRxxeTKxqXZUHu9XOp+D4p+wdTaqhH2F4wU3KbjMjMlqIEAfpaH+iynNW9GCZ7xDX jE31ceI38vQe8l90z6zWIFTXMkTCGGzfSfcprfmByYV+SOclJHxiRa88je+R/VF2OE/r jm5a75DhyMjEevwPb8xnQSSOogPe+GjqvLNVzzr1+NYuWUoBpTOE8cuesEXbByZ1ddT1 9cZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:in-reply-to:message-id:cc:to:subject:from :date:x-gm-message-state:from:to:cc:subject:date; bh=IE/lUB9GeFJ3cgcWCczdBLBsp8zcC8CA4nMsFXJExts=; b=52ucS/Yk/M/NownqgJ5N1+jgfiCknRpnTC7CMjWfoF17ZDXUZ78cL8eyWxT6LC5Ov7 U0G2Wvpqf2SIbQF+Qn9dthW4V5M9qPiPQ95vVoz+MRnq3PJY8Dz/ynr/KgSXPOFdxGeT h87ETiBcSRVVS9uFCCu9DkRdU/hlhlYb5pOSTLMcfJy/LfoNOuCYpOGo+dj/BvkS/IS3 MCPvOXJh3cICz191KiVq0fmx0c4Ucq7T59hVbGqATo3l0Px6A1AZCMkhFuyOMcF8XVf1 tJFR9/pZ4YfjUsWTKSFjkBwcDy2g9JImBiDOMZk0oKlB6oVavdQjH5PtXRkZaGps47lJ Vypg== X-Gm-Message-State: ACrzQf0CyS/lyjLQdVH2/P9jZbWC6vobiBLs9kmu/1ucaTwmwRIzds39 Pkwfzw9S41FlCzGv/s15R+k= X-Google-Smtp-Source: AMsMyM5aVGhWkOnNJmsBsfyVgjUfb2jYAdOqzt7epbBXN3MqtxhZqf/7Xfo/k1tguHf3FwqbXbSahQ== X-Received: by 2002:a17:907:a044:b0:770:da0d:171d with SMTP id gz4-20020a170907a04400b00770da0d171dmr19485416ejc.742.1663752335121; Wed, 21 Sep 2022 02:25:35 -0700 (PDT) Received: from [10.31.3.208] ([95.183.227.98]) by smtp.gmail.com with ESMTPSA id g2-20020a17090604c200b0072b3406e9c2sm1053996eja.95.2022.09.21.02.25.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 02:25:34 -0700 (PDT) Date: Wed, 21 Sep 2022 12:25:20 +0300 From: yassine.oudjana@gmail.com Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: Combine MediaTek MT67xx pinctrl binding docs To: Krzysztof Kozlowski Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Andy Teng , AngeloGioacchino Del Regno , Yassine Oudjana , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-Id: <8IZJIR.7AG9DG7U1XLJ@gmail.com> In-Reply-To: References: <20220919170115.94873-1-y.oudjana@protonmail.com> <20220919170115.94873-2-y.oudjana@protonmail.com> X-Mailer: geary/40.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220921_022539_177173_2C4CE335 X-CRM114-Status: GOOD ( 21.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 21 2022 at 09:20:43 AM +0200, Krzysztof Kozlowski wrote: > On 19/09/2022 19:01, Yassine Oudjana wrote: >> From: Yassine Oudjana >> >> Documents for MT6779, MT6795 and MT6797 that currently exist share >> most properties, and each one has slightly differently worded >> descriptions for those properties. Combine all three documents into >> one common document for all MT67xx SoC pin controllers, picking a >> few >> parts from each and accounting for differences such as items in reg >> and reg-names properties. Also document the MT6765 pin controller >> which currently has a driver but no DT binding documentation. It >> should >> be possible to also include bindings for MT8183 and MT8188, but >> these >> have some additional properties that might complicate things a bit, >> so they are left alone for now. >> > >> properties: >> compatible: >> - const: mediatek,mt6795-pinctrl >> + oneOf: >> + - enum: >> + - mediatek,mt6765-pinctrl >> + - mediatek,mt6795-pinctrl >> + - mediatek,mt6797-pinctrl >> + - items: >> + - const: mediatek,mt6779-pinctrl >> + - const: syscon > > No, this is not like old bindings at all. It's not merging, it's a > change sneaked inside huge diff. Also - probably totally untested on > DTS > (or old bindings were broken). Actually this change was made specifically so that it remains (probably becomes?) compatible with existing DTS and passes checks. mt6779.dtsi currently has the syscon compatible string but it wasn't listed along with mediatek,mt6779-pinctrl in the old document, but instead there was something in the description about putting the pinctrl node under a syscon node, which isn't the case in the existing DTS. This patch passed both dt_binding_check and dtbs_check. Anyway, I see how I failed to describe this change, so I'll go through the patch again and try to find any other small changes I might've made and forgotten about, and either put them in separate patches or describe them in the commit message, whichever one you think is better. Also, do I make those changes in the original documents then combine or combine first then make them in the new one? Thanks, Yassine (Sorry for the spam, my client was misconfigured so it previously sent HTML instead of plain text.) > > That's a no-go. > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel