From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42FDDC43334 for ; Mon, 13 Jun 2022 11:32:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2903810E2A9; Mon, 13 Jun 2022 11:32:18 +0000 (UTC) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8975A10E48C for ; Mon, 13 Jun 2022 11:32:16 +0000 (UTC) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20220613113214euoutp02b5a503c5b5d485d58f9adf3fb0982231~4Ks_3J6tw2705027050euoutp02h for ; Mon, 13 Jun 2022 11:32:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20220613113214euoutp02b5a503c5b5d485d58f9adf3fb0982231~4Ks_3J6tw2705027050euoutp02h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1655119934; bh=F5jBUvtl3CxTm1UPj5cWd9sRDQMPJ296wnn2EC83cxE=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=iF6Zislin36tLFopjTin7RuUFz+GpDrDhaD1fYEVSAERqb+t6XwaImpId+UUt+Ifw 7qYMWgSLi3J952BoxjZV2uUEH1roVrWwR/myOYc04l9Hl/sItdYxeAO4QIH1CdwEfy SITIAOto4dGN7zihOP9RR+t91CPcpLpy08/Mnnu0= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20220613113214eucas1p12e92435cc0509577dc436bac9415bb19~4Ks_WMW9E1737517375eucas1p1K; Mon, 13 Jun 2022 11:32:14 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id A3.7D.10067.D3027A26; Mon, 13 Jun 2022 12:32:14 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20220613113213eucas1p12e42117505931c416771ae10346d1b58~4Ks92fYjs2250222502eucas1p1Q; Mon, 13 Jun 2022 11:32:13 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220613113213eusmtrp14416e390ede435abde4d163a7eadfa7f~4Ks91Vi-12006220062eusmtrp1U; Mon, 13 Jun 2022 11:32:13 +0000 (GMT) X-AuditID: cbfec7f4-dd7ff70000002753-34-62a7203d19a6 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 45.B3.09095.D3027A26; Mon, 13 Jun 2022 12:32:13 +0100 (BST) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220613113212eusmtip2c92cca070719582ae2a11968de3d3f1b~4Ks8peGQ50221102211eusmtip2G; Mon, 13 Jun 2022 11:32:12 +0000 (GMT) Message-ID: <8a0727e2-134f-c34e-aa32-cf828255ce8c@samsung.com> Date: Mon, 13 Jun 2022 13:32:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 08/12] drm: bridge: samsung-dsim: Add atomic_check Content-Language: en-US To: Jagan Teki , Andrzej Hajda From: Marek Szyprowski In-Reply-To: Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnk+LIzCtJLcpLzFFi42LZduznOV07heVJBlN/MVncuX2a2eL+4s8s Fq9vr2CzuPL1PZtF79JzrBaT7k9gsfiyaQKbxYt7F1kszja9YbfonLiE3WL5hH1sFpseX2O1 6Pq1ktlixvl9TBanH61ntjjV2Mpicagv2uLTrIdA8ckv2SwunvjEbPH991lmB1GPtR/vs3q8 v9HK7jHlxBFWj3M9d9k8ds66y+4xu2Mmq8fiPS+ZPI5cXczqcefaHjaP+93HmTw2L6n32Phu B5NH35ZVjB6fN8kF8EVx2aSk5mSWpRbp2yVwZRxcsZip4LJgxdNVB5kaGP/ydjFycEgImEgs OeDbxcjJISSwglFi10zzLkYuIPsLo8S3cydYIZzPjBIrn0xlBqkCaWhZ9ZQRomM5o8T1HdUQ RR8ZJdZe3cgCkuAVsJP4tbOFDcRmEVCVeHPqEyNEXFDi5MwnYDWiAkkS87e1soLYwgKeEu+O HWAHsZkFxCVuPZnPBHKdiECYxPYD4SDzmQXWskncfHQQbCabgKFE19suNpAaToFAiSXXcyFa 5SW2v50DdWcTl8TflXoQT7pIPD5YBhEWlnh1fAs7hC0jcXpyDwtESb7E3xnGEOEKiWuv10BN sZa4c+4X2CJmAU2J9bv0IcKOEuefboPq5JO48VYQYj+fxKRt05khwrwSHW1CENVqErOOr4Pb efDCJeYJjEqzkAJkFpLHZyH5ZBbC3gWMLKsYxVNLi3PTU4uN8lLL9YoTc4tL89L1kvNzNzEC 0+rpf8e/7GBc/uqj3iFGJg7GQ4wSHMxKIryTLy5LEuJNSaysSi3Kjy8qzUktPsQozcGiJM6b nLkhUUggPbEkNTs1tSC1CCbLxMEp1cCU76D7+KSbz+tkp40x6+/77HqzLsDFY1a7b6W5YIpj w3GVFYI2Meyq2roLXtnezjKbH5UXzl2UOVnoc0ZxfNMZJjHlwxsCOOYdb3f96HpGdlaTjuLz sJS2M7vqN8+5ciVfoCAh/Un6piC2pqxfJSuiJI+srmRZziKouFq3r3bi0m+ZEx/e4XLfIKoR yBfXk9v5b4vZ4j/VMVe0Y4uilhWYh91d9+dHpv3TXf8Sp55i8hf6W7K2hW2Td+yiCze+rzj1 8ktijHZj0toZVxT2Mojdr5yc47FCc+Z/y3wurtmfpXbHV0bGLA87f5TVekHLw5myK9pr/bbt 9fR+Lf5Vvrh403cuga0X1IL3vd+TGqzEUpyRaKjFXFScCACId+c5GgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEKsWRmVeSWpSXmKPExsVy+t/xe7q2CsuTDC63yVncuX2a2eL+4s8s Fq9vr2CzuPL1PZtF79JzrBaT7k9gsfiyaQKbxYt7F1kszja9YbfonLiE3WL5hH1sFpseX2O1 6Pq1ktlixvl9TBanH61ntjjV2Mpicagv2uLTrIdA8ckv2SwunvjEbPH991lmB1GPtR/vs3q8 v9HK7jHlxBFWj3M9d9k8ds66y+4xu2Mmq8fiPS+ZPI5cXczqcefaHjaP+93HmTw2L6n32Phu B5NH35ZVjB6fN8kF8EXp2RTll5akKmTkF5fYKkUbWhjpGVpa6BmZWOoZGpvHWhmZKunb2aSk 5mSWpRbp2yXoZRxcsZip4LJgxdNVB5kaGP/ydjFyckgImEi0rHrK2MXIxSEksJRRYuq8KYwQ CRmJk9MaWCFsYYk/17rYIIreM0q8PLueDSTBK2An8WtnC5jNIqAq8ebUJ0aIuKDEyZlPWEBs UYEkiXl7V4PFhQU8Jd4dO8AOYjMLiEvcejKfCcQWEQiT6F3xhB1kAbPARjaJHTcmQJ10mEni xKOrYB1sAoYSXW9BzuDg4BQIlFhyPRdikJlE19YuRghbXmL72znMExiFZiG5YxaSfbOQtMxC 0rKAkWUVo0hqaXFuem6xoV5xYm5xaV66XnJ+7iZGYGLZduzn5h2M81591DvEyMTBeIhRgoNZ SYR38sVlSUK8KYmVValF+fFFpTmpxYcYTYGBMZFZSjQ5H5ja8kriDc0MTA1NzCwNTC3NjJXE eT0LOhKFBNITS1KzU1MLUotg+pg4OKUamDjSxb3V5Lptgve+1L16vuVOt7TCi/JAp4JXmzna ltx+JdSvaR+3+JrL0pbWmIvpl7fVi1dIfdtTL8PdPcP+Tuj93I/KL1fdSP9d9fb1nkn/Rbon NRlcmCX0cfexPk2uiezR4md0fn91MI3KuXYw7fRbnzfu+/LUziv4pv2cEBKiHbRlp9xmUf4N kyb87K//8rwidsEphZKlJ57Ner9E7Fn1BmOjZPnWlKPSIZynWu3+zmUPniDX2xft1fdToj0g M//OAv8j5cnn5ZSnffI1ev387/ak9HOiJUIz9kjr116cbyD8ZvXJzpQw/riJq0+czFhde7c+ Uqoh8BzzHZlvz2K3F5gv9nw4yetwj2NkqxJLcUaioRZzUXEiAKrQANy1AwAA X-CMS-MailID: 20220613113213eucas1p12e42117505931c416771ae10346d1b58 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20220613111735eucas1p1f80de0b3b377c12f183721371cf8d6fc X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20220613111735eucas1p1f80de0b3b377c12f183721371cf8d6fc References: <20220504114021.33265-1-jagan@amarulasolutions.com> <20220504114021.33265-9-jagan@amarulasolutions.com> <17782795-10f1-067d-c6af-f82d64c6273e@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, Joonyoung Shim , Neil Armstrong , linux-amarula , Seung-Woo Kim , Tommaso Merciai , Frieder Schrempf , Kyungmin Park , Matteo Lisi , Robert Foss , NXP Linux Team , Fancy Fang , Michael Nazzareno Trimarchi , Adam Ford , linux-arm-kernel@lists.infradead.org, Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 13.06.2022 13:17, Jagan Teki wrote: > On Wed, May 11, 2022 at 4:01 PM Andrzej Hajda wrote: >> On 04.05.2022 13:40, Jagan Teki wrote: >>> Fixing up the mode flags is required in order to correlate the >>> correct sync flags of the surrounding components in the chain >>> to make sure the whole pipeline can work properly. >>> >>> So, handle the mode flags via bridge, atomic_check. >>> >>> v2: >>> * none >>> >>> v1: >>> * fix mode flags in atomic_check instead of mode_fixup >>> >>> Signed-off-by: Jagan Teki >>> --- >>> drivers/gpu/drm/bridge/samsung-dsim.c | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c >>> index b618e52d0ee3..bd78cef890e4 100644 >>> --- a/drivers/gpu/drm/bridge/samsung-dsim.c >>> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c >>> @@ -1340,6 +1340,19 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, >>> pm_runtime_put_sync(dsi->dev); >>> } >>> >>> +static int samsung_dsim_atomic_check(struct drm_bridge *bridge, >>> + struct drm_bridge_state *bridge_state, >>> + struct drm_crtc_state *crtc_state, >>> + struct drm_connector_state *conn_state) >>> +{ >>> + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; >>> + >>> + adjusted_mode->flags |= (DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC); >>> + adjusted_mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); >> >> 1. Shouldn't this be in mode_fixup callback? > Possible to do it on mode_fixup, yes. if we want to do the same stuff > on atomic API then atomic_check is the proper helper. > >> 2. Where this requirement comes from? As Marek says it breaks Samsung >> platforms and is against DSIM specification[1]: > At least the bridge chain starting from LCDIF+DSIM requires active high sync. Then please make this specific to the imx variant. The current version breaks DSI operation on all Exynos based boards. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5770FC43334 for ; Mon, 13 Jun 2022 11:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To:From:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gs4foHEetLWcPU9YgK8Aap7T6G/lcKD2qOGbEGAwrYM=; b=46noeAjAeWNiyc G3APX0JFZVZdB0XtsnuLrnu9fi5AqXHUIAsL2f4vMI5tkENofzmWGAHDidj3Uf1cUGTakRsAkwraV ErAH3/cIc8UVuIi0hl0BT/b3aWEr1mWHqS7kWAL5xWk9WFnQQ7bV6izQjh8or6bK56CZP9eqVBTCu ZjslMZQTOT9u0kaRG/rQB9BwZQfJt3Un9zdLeS8MTtneB72C2nez2ZXn2gqXbZZNey/Taw+NaPRfQ 9dA4kJ7GBhBfmpYFOkAUpmrqesU/lN0GkqdQVqsLH5c+QcFY9N8dRFepAvi+hafYjsWXy3hoSOX+X jXo+5UDpzkkupDba8Tyw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0iJ2-003G5G-D4; Mon, 13 Jun 2022 11:32:30 +0000 Received: from mailout1.w1.samsung.com ([210.118.77.11]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o0iIt-003G1B-LY for linux-arm-kernel@lists.infradead.org; Mon, 13 Jun 2022 11:32:22 +0000 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20220613113214euoutp01c8f07076d857da882771671f3daa5a34~4Ks_84Tms2498224982euoutp01D for ; Mon, 13 Jun 2022 11:32:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20220613113214euoutp01c8f07076d857da882771671f3daa5a34~4Ks_84Tms2498224982euoutp01D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1655119934; bh=F5jBUvtl3CxTm1UPj5cWd9sRDQMPJ296wnn2EC83cxE=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=iF6Zislin36tLFopjTin7RuUFz+GpDrDhaD1fYEVSAERqb+t6XwaImpId+UUt+Ifw 7qYMWgSLi3J952BoxjZV2uUEH1roVrWwR/myOYc04l9Hl/sItdYxeAO4QIH1CdwEfy SITIAOto4dGN7zihOP9RR+t91CPcpLpy08/Mnnu0= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20220613113214eucas1p12e92435cc0509577dc436bac9415bb19~4Ks_WMW9E1737517375eucas1p1K; Mon, 13 Jun 2022 11:32:14 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id A3.7D.10067.D3027A26; Mon, 13 Jun 2022 12:32:14 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20220613113213eucas1p12e42117505931c416771ae10346d1b58~4Ks92fYjs2250222502eucas1p1Q; Mon, 13 Jun 2022 11:32:13 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220613113213eusmtrp14416e390ede435abde4d163a7eadfa7f~4Ks91Vi-12006220062eusmtrp1U; Mon, 13 Jun 2022 11:32:13 +0000 (GMT) X-AuditID: cbfec7f4-dd7ff70000002753-34-62a7203d19a6 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 45.B3.09095.D3027A26; Mon, 13 Jun 2022 12:32:13 +0100 (BST) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220613113212eusmtip2c92cca070719582ae2a11968de3d3f1b~4Ks8peGQ50221102211eusmtip2G; Mon, 13 Jun 2022 11:32:12 +0000 (GMT) Message-ID: <8a0727e2-134f-c34e-aa32-cf828255ce8c@samsung.com> Date: Mon, 13 Jun 2022 13:32:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 08/12] drm: bridge: samsung-dsim: Add atomic_check Content-Language: en-US To: Jagan Teki , Andrzej Hajda Cc: Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , linux-samsung-soc@vger.kernel.org, Matteo Lisi , dri-devel@lists.freedesktop.org, NXP Linux Team , linux-amarula , linux-arm-kernel@lists.infradead.org From: Marek Szyprowski In-Reply-To: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnk+LIzCtJLcpLzFFi42LZduznOV07heVJBlN/MVncuX2a2eL+4s8s Fq9vr2CzuPL1PZtF79JzrBaT7k9gsfiyaQKbxYt7F1kszja9YbfonLiE3WL5hH1sFpseX2O1 6Pq1ktlixvl9TBanH61ntjjV2Mpicagv2uLTrIdA8ckv2SwunvjEbPH991lmB1GPtR/vs3q8 v9HK7jHlxBFWj3M9d9k8ds66y+4xu2Mmq8fiPS+ZPI5cXczqcefaHjaP+93HmTw2L6n32Phu B5NH35ZVjB6fN8kF8EVx2aSk5mSWpRbp2yVwZRxcsZip4LJgxdNVB5kaGP/ydjFycEgImEgs OeDbxcjJISSwglFi10zzLkYuIPsLo8S3cydYIZzPjBIrn0xlBqkCaWhZ9ZQRomM5o8T1HdUQ RR8ZJdZe3cgCkuAVsJP4tbOFDcRmEVCVeHPqEyNEXFDi5MwnYDWiAkkS87e1soLYwgKeEu+O HWAHsZkFxCVuPZnPBHKdiECYxPYD4SDzmQXWskncfHQQbCabgKFE19suNpAaToFAiSXXcyFa 5SW2v50DdWcTl8TflXoQT7pIPD5YBhEWlnh1fAs7hC0jcXpyDwtESb7E3xnGEOEKiWuv10BN sZa4c+4X2CJmAU2J9bv0IcKOEuefboPq5JO48VYQYj+fxKRt05khwrwSHW1CENVqErOOr4Pb efDCJeYJjEqzkAJkFpLHZyH5ZBbC3gWMLKsYxVNLi3PTU4uN8lLL9YoTc4tL89L1kvNzNzEC 0+rpf8e/7GBc/uqj3iFGJg7GQ4wSHMxKIryTLy5LEuJNSaysSi3Kjy8qzUktPsQozcGiJM6b nLkhUUggPbEkNTs1tSC1CCbLxMEp1cCU76D7+KSbz+tkp40x6+/77HqzLsDFY1a7b6W5YIpj w3GVFYI2Meyq2roLXtnezjKbH5UXzl2UOVnoc0ZxfNMZJjHlwxsCOOYdb3f96HpGdlaTjuLz sJS2M7vqN8+5ciVfoCAh/Un6piC2pqxfJSuiJI+srmRZziKouFq3r3bi0m+ZEx/e4XLfIKoR yBfXk9v5b4vZ4j/VMVe0Y4uilhWYh91d9+dHpv3TXf8Sp55i8hf6W7K2hW2Td+yiCze+rzj1 8ktijHZj0toZVxT2Mojdr5yc47FCc+Z/y3wurtmfpXbHV0bGLA87f5TVekHLw5myK9pr/bbt 9fR+Lf5Vvrh403cuga0X1IL3vd+TGqzEUpyRaKjFXFScCACId+c5GgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEKsWRmVeSWpSXmKPExsVy+t/xe7q2CsuTDC63yVncuX2a2eL+4s8s Fq9vr2CzuPL1PZtF79JzrBaT7k9gsfiyaQKbxYt7F1kszja9YbfonLiE3WL5hH1sFpseX2O1 6Pq1ktlixvl9TBanH61ntjjV2Mpicagv2uLTrIdA8ckv2SwunvjEbPH991lmB1GPtR/vs3q8 v9HK7jHlxBFWj3M9d9k8ds66y+4xu2Mmq8fiPS+ZPI5cXczqcefaHjaP+93HmTw2L6n32Phu B5NH35ZVjB6fN8kF8EXp2RTll5akKmTkF5fYKkUbWhjpGVpa6BmZWOoZGpvHWhmZKunb2aSk 5mSWpRbp2yXoZRxcsZip4LJgxdNVB5kaGP/ydjFyckgImEi0rHrK2MXIxSEksJRRYuq8KYwQ CRmJk9MaWCFsYYk/17rYIIreM0q8PLueDSTBK2An8WtnC5jNIqAq8ebUJ0aIuKDEyZlPWEBs UYEkiXl7V4PFhQU8Jd4dO8AOYjMLiEvcejKfCcQWEQiT6F3xhB1kAbPARjaJHTcmQJ10mEni xKOrYB1sAoYSXW9BzuDg4BQIlFhyPRdikJlE19YuRghbXmL72znMExiFZiG5YxaSfbOQtMxC 0rKAkWUVo0hqaXFuem6xoV5xYm5xaV66XnJ+7iZGYGLZduzn5h2M81591DvEyMTBeIhRgoNZ SYR38sVlSUK8KYmVValF+fFFpTmpxYcYTYGBMZFZSjQ5H5ja8kriDc0MTA1NzCwNTC3NjJXE eT0LOhKFBNITS1KzU1MLUotg+pg4OKUamDjSxb3V5Lptgve+1L16vuVOt7TCi/JAp4JXmzna ltx+JdSvaR+3+JrL0pbWmIvpl7fVi1dIfdtTL8PdPcP+Tuj93I/KL1fdSP9d9fb1nkn/Rbon NRlcmCX0cfexPk2uiezR4md0fn91MI3KuXYw7fRbnzfu+/LUziv4pv2cEBKiHbRlp9xmUf4N kyb87K//8rwidsEphZKlJ57Ner9E7Fn1BmOjZPnWlKPSIZynWu3+zmUPniDX2xft1fdToj0g M//OAv8j5cnn5ZSnffI1ev387/ak9HOiJUIz9kjr116cbyD8ZvXJzpQw/riJq0+czFhde7c+ Uqoh8BzzHZlvz2K3F5gv9nw4yetwj2NkqxJLcUaioRZzUXEiAKrQANy1AwAA X-CMS-MailID: 20220613113213eucas1p12e42117505931c416771ae10346d1b58 X-Msg-Generator: CA X-RootMTR: 20220613111735eucas1p1f80de0b3b377c12f183721371cf8d6fc X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20220613111735eucas1p1f80de0b3b377c12f183721371cf8d6fc References: <20220504114021.33265-1-jagan@amarulasolutions.com> <20220504114021.33265-9-jagan@amarulasolutions.com> <17782795-10f1-067d-c6af-f82d64c6273e@intel.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220613_043220_315232_780D8E90 X-CRM114-Status: GOOD ( 17.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13.06.2022 13:17, Jagan Teki wrote: > On Wed, May 11, 2022 at 4:01 PM Andrzej Hajda wrote: >> On 04.05.2022 13:40, Jagan Teki wrote: >>> Fixing up the mode flags is required in order to correlate the >>> correct sync flags of the surrounding components in the chain >>> to make sure the whole pipeline can work properly. >>> >>> So, handle the mode flags via bridge, atomic_check. >>> >>> v2: >>> * none >>> >>> v1: >>> * fix mode flags in atomic_check instead of mode_fixup >>> >>> Signed-off-by: Jagan Teki >>> --- >>> drivers/gpu/drm/bridge/samsung-dsim.c | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c >>> index b618e52d0ee3..bd78cef890e4 100644 >>> --- a/drivers/gpu/drm/bridge/samsung-dsim.c >>> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c >>> @@ -1340,6 +1340,19 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, >>> pm_runtime_put_sync(dsi->dev); >>> } >>> >>> +static int samsung_dsim_atomic_check(struct drm_bridge *bridge, >>> + struct drm_bridge_state *bridge_state, >>> + struct drm_crtc_state *crtc_state, >>> + struct drm_connector_state *conn_state) >>> +{ >>> + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; >>> + >>> + adjusted_mode->flags |= (DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC); >>> + adjusted_mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); >> >> 1. Shouldn't this be in mode_fixup callback? > Possible to do it on mode_fixup, yes. if we want to do the same stuff > on atomic API then atomic_check is the proper helper. > >> 2. Where this requirement comes from? As Marek says it breaks Samsung >> platforms and is against DSIM specification[1]: > At least the bridge chain starting from LCDIF+DSIM requires active high sync. Then please make this specific to the imx variant. The current version breaks DSI operation on all Exynos based boards. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A47AC433EF for ; Mon, 13 Jun 2022 13:46:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378950AbiFMNqT (ORCPT ); Mon, 13 Jun 2022 09:46:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379572AbiFMNok (ORCPT ); Mon, 13 Jun 2022 09:44:40 -0400 Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA04640E44 for ; Mon, 13 Jun 2022 04:32:18 -0700 (PDT) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20220613113214euoutp02e7514397843558bf410b974831c3bd4a~4Ks_-2jPI2705027050euoutp02i for ; Mon, 13 Jun 2022 11:32:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20220613113214euoutp02e7514397843558bf410b974831c3bd4a~4Ks_-2jPI2705027050euoutp02i DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1655119934; bh=F5jBUvtl3CxTm1UPj5cWd9sRDQMPJ296wnn2EC83cxE=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=iF6Zislin36tLFopjTin7RuUFz+GpDrDhaD1fYEVSAERqb+t6XwaImpId+UUt+Ifw 7qYMWgSLi3J952BoxjZV2uUEH1roVrWwR/myOYc04l9Hl/sItdYxeAO4QIH1CdwEfy SITIAOto4dGN7zihOP9RR+t91CPcpLpy08/Mnnu0= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20220613113214eucas1p12e92435cc0509577dc436bac9415bb19~4Ks_WMW9E1737517375eucas1p1K; Mon, 13 Jun 2022 11:32:14 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id A3.7D.10067.D3027A26; Mon, 13 Jun 2022 12:32:14 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20220613113213eucas1p12e42117505931c416771ae10346d1b58~4Ks92fYjs2250222502eucas1p1Q; Mon, 13 Jun 2022 11:32:13 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220613113213eusmtrp14416e390ede435abde4d163a7eadfa7f~4Ks91Vi-12006220062eusmtrp1U; Mon, 13 Jun 2022 11:32:13 +0000 (GMT) X-AuditID: cbfec7f4-dd7ff70000002753-34-62a7203d19a6 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 45.B3.09095.D3027A26; Mon, 13 Jun 2022 12:32:13 +0100 (BST) Received: from [106.210.134.192] (unknown [106.210.134.192]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20220613113212eusmtip2c92cca070719582ae2a11968de3d3f1b~4Ks8peGQ50221102211eusmtip2G; Mon, 13 Jun 2022 11:32:12 +0000 (GMT) Message-ID: <8a0727e2-134f-c34e-aa32-cf828255ce8c@samsung.com> Date: Mon, 13 Jun 2022 13:32:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 08/12] drm: bridge: samsung-dsim: Add atomic_check Content-Language: en-US To: Jagan Teki , Andrzej Hajda Cc: Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Fancy Fang , Tim Harvey , Michael Nazzareno Trimarchi , Adam Ford , Neil Armstrong , Robert Foss , Laurent Pinchart , Tommaso Merciai , linux-samsung-soc@vger.kernel.org, Matteo Lisi , dri-devel@lists.freedesktop.org, NXP Linux Team , linux-amarula , linux-arm-kernel@lists.infradead.org From: Marek Szyprowski In-Reply-To: Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnk+LIzCtJLcpLzFFi42LZduznOV07heVJBlN/MVncuX2a2eL+4s8s Fq9vr2CzuPL1PZtF79JzrBaT7k9gsfiyaQKbxYt7F1kszja9YbfonLiE3WL5hH1sFpseX2O1 6Pq1ktlixvl9TBanH61ntjjV2Mpicagv2uLTrIdA8ckv2SwunvjEbPH991lmB1GPtR/vs3q8 v9HK7jHlxBFWj3M9d9k8ds66y+4xu2Mmq8fiPS+ZPI5cXczqcefaHjaP+93HmTw2L6n32Phu B5NH35ZVjB6fN8kF8EVx2aSk5mSWpRbp2yVwZRxcsZip4LJgxdNVB5kaGP/ydjFycEgImEgs OeDbxcjJISSwglFi10zzLkYuIPsLo8S3cydYIZzPjBIrn0xlBqkCaWhZ9ZQRomM5o8T1HdUQ RR8ZJdZe3cgCkuAVsJP4tbOFDcRmEVCVeHPqEyNEXFDi5MwnYDWiAkkS87e1soLYwgKeEu+O HWAHsZkFxCVuPZnPBHKdiECYxPYD4SDzmQXWskncfHQQbCabgKFE19suNpAaToFAiSXXcyFa 5SW2v50DdWcTl8TflXoQT7pIPD5YBhEWlnh1fAs7hC0jcXpyDwtESb7E3xnGEOEKiWuv10BN sZa4c+4X2CJmAU2J9bv0IcKOEuefboPq5JO48VYQYj+fxKRt05khwrwSHW1CENVqErOOr4Pb efDCJeYJjEqzkAJkFpLHZyH5ZBbC3gWMLKsYxVNLi3PTU4uN8lLL9YoTc4tL89L1kvNzNzEC 0+rpf8e/7GBc/uqj3iFGJg7GQ4wSHMxKIryTLy5LEuJNSaysSi3Kjy8qzUktPsQozcGiJM6b nLkhUUggPbEkNTs1tSC1CCbLxMEp1cCU76D7+KSbz+tkp40x6+/77HqzLsDFY1a7b6W5YIpj w3GVFYI2Meyq2roLXtnezjKbH5UXzl2UOVnoc0ZxfNMZJjHlwxsCOOYdb3f96HpGdlaTjuLz sJS2M7vqN8+5ciVfoCAh/Un6piC2pqxfJSuiJI+srmRZziKouFq3r3bi0m+ZEx/e4XLfIKoR yBfXk9v5b4vZ4j/VMVe0Y4uilhWYh91d9+dHpv3TXf8Sp55i8hf6W7K2hW2Td+yiCze+rzj1 8ktijHZj0toZVxT2Mojdr5yc47FCc+Z/y3wurtmfpXbHV0bGLA87f5TVekHLw5myK9pr/bbt 9fR+Lf5Vvrh403cuga0X1IL3vd+TGqzEUpyRaKjFXFScCACId+c5GgQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEKsWRmVeSWpSXmKPExsVy+t/xe7q2CsuTDC63yVncuX2a2eL+4s8s Fq9vr2CzuPL1PZtF79JzrBaT7k9gsfiyaQKbxYt7F1kszja9YbfonLiE3WL5hH1sFpseX2O1 6Pq1ktlixvl9TBanH61ntjjV2Mpicagv2uLTrIdA8ckv2SwunvjEbPH991lmB1GPtR/vs3q8 v9HK7jHlxBFWj3M9d9k8ds66y+4xu2Mmq8fiPS+ZPI5cXczqcefaHjaP+93HmTw2L6n32Phu B5NH35ZVjB6fN8kF8EXp2RTll5akKmTkF5fYKkUbWhjpGVpa6BmZWOoZGpvHWhmZKunb2aSk 5mSWpRbp2yXoZRxcsZip4LJgxdNVB5kaGP/ydjFyckgImEi0rHrK2MXIxSEksJRRYuq8KYwQ CRmJk9MaWCFsYYk/17rYIIreM0q8PLueDSTBK2An8WtnC5jNIqAq8ebUJ0aIuKDEyZlPWEBs UYEkiXl7V4PFhQU8Jd4dO8AOYjMLiEvcejKfCcQWEQiT6F3xhB1kAbPARjaJHTcmQJ10mEni xKOrYB1sAoYSXW9BzuDg4BQIlFhyPRdikJlE19YuRghbXmL72znMExiFZiG5YxaSfbOQtMxC 0rKAkWUVo0hqaXFuem6xoV5xYm5xaV66XnJ+7iZGYGLZduzn5h2M81591DvEyMTBeIhRgoNZ SYR38sVlSUK8KYmVValF+fFFpTmpxYcYTYGBMZFZSjQ5H5ja8kriDc0MTA1NzCwNTC3NjJXE eT0LOhKFBNITS1KzU1MLUotg+pg4OKUamDjSxb3V5Lptgve+1L16vuVOt7TCi/JAp4JXmzna ltx+JdSvaR+3+JrL0pbWmIvpl7fVi1dIfdtTL8PdPcP+Tuj93I/KL1fdSP9d9fb1nkn/Rbon NRlcmCX0cfexPk2uiezR4md0fn91MI3KuXYw7fRbnzfu+/LUziv4pv2cEBKiHbRlp9xmUf4N kyb87K//8rwidsEphZKlJ57Ner9E7Fn1BmOjZPnWlKPSIZynWu3+zmUPniDX2xft1fdToj0g M//OAv8j5cnn5ZSnffI1ev387/ak9HOiJUIz9kjr116cbyD8ZvXJzpQw/riJq0+czFhde7c+ Uqoh8BzzHZlvz2K3F5gv9nw4yetwj2NkqxJLcUaioRZzUXEiAKrQANy1AwAA X-CMS-MailID: 20220613113213eucas1p12e42117505931c416771ae10346d1b58 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20220613111735eucas1p1f80de0b3b377c12f183721371cf8d6fc X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20220613111735eucas1p1f80de0b3b377c12f183721371cf8d6fc References: <20220504114021.33265-1-jagan@amarulasolutions.com> <20220504114021.33265-9-jagan@amarulasolutions.com> <17782795-10f1-067d-c6af-f82d64c6273e@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org On 13.06.2022 13:17, Jagan Teki wrote: > On Wed, May 11, 2022 at 4:01 PM Andrzej Hajda wrote: >> On 04.05.2022 13:40, Jagan Teki wrote: >>> Fixing up the mode flags is required in order to correlate the >>> correct sync flags of the surrounding components in the chain >>> to make sure the whole pipeline can work properly. >>> >>> So, handle the mode flags via bridge, atomic_check. >>> >>> v2: >>> * none >>> >>> v1: >>> * fix mode flags in atomic_check instead of mode_fixup >>> >>> Signed-off-by: Jagan Teki >>> --- >>> drivers/gpu/drm/bridge/samsung-dsim.c | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c >>> index b618e52d0ee3..bd78cef890e4 100644 >>> --- a/drivers/gpu/drm/bridge/samsung-dsim.c >>> +++ b/drivers/gpu/drm/bridge/samsung-dsim.c >>> @@ -1340,6 +1340,19 @@ static void samsung_dsim_atomic_post_disable(struct drm_bridge *bridge, >>> pm_runtime_put_sync(dsi->dev); >>> } >>> >>> +static int samsung_dsim_atomic_check(struct drm_bridge *bridge, >>> + struct drm_bridge_state *bridge_state, >>> + struct drm_crtc_state *crtc_state, >>> + struct drm_connector_state *conn_state) >>> +{ >>> + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; >>> + >>> + adjusted_mode->flags |= (DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC); >>> + adjusted_mode->flags &= ~(DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC); >> >> 1. Shouldn't this be in mode_fixup callback? > Possible to do it on mode_fixup, yes. if we want to do the same stuff > on atomic API then atomic_check is the proper helper. > >> 2. Where this requirement comes from? As Marek says it breaks Samsung >> platforms and is against DSIM specification[1]: > At least the bridge chain starting from LCDIF+DSIM requires active high sync. Then please make this specific to the imx variant. The current version breaks DSI operation on all Exynos based boards. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland