From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754602AbdCaJTR convert rfc822-to-8bit (ORCPT ); Fri, 31 Mar 2017 05:19:17 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:13851 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752295AbdCaJTP (ORCPT ); Fri, 31 Mar 2017 05:19:15 -0400 From: Patrice CHOTARD To: Hugues FRUCHET , Lee Jones CC: "linux-kernel@vger.kernel.org" , "Benjamin Gaignard" , Amelie DELAUNAY Subject: Re: [PATCH] mfd: stmpe: Fix bit clearing on STMPE1600 Thread-Topic: [PATCH] mfd: stmpe: Fix bit clearing on STMPE1600 Thread-Index: AQHSqfaWe9Q3QsSr/0qvO0Lyn0ZRCKGuikKA Date: Fri, 31 Mar 2017 09:19:11 +0000 Message-ID: <8a10fb24-3a8c-fcb1-fe5a-adcb5aef2255@st.com> References: <1490947959-19597-1-git-send-email-hugues.fruchet@st.com> In-Reply-To: <1490947959-19597-1-git-send-email-hugues.fruchet@st.com> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.44] Content-Type: text/plain; charset="Windows-1252" Content-ID: <0CF600E4B0A20549A59E0D1F04FCEF4B@st.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-03-31_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hugues On 03/31/2017 10:12 AM, Hugues Fruchet wrote: > GPIO bits clearing on pins assigned to STMPE1600 > had no effects due to missing "clear registers" > settings within stmpe1600_regs[]. > STMPE1600 does not have dedicated "clear registers", > but single "set/clear registers", hence stmpe1600_regs[] > "clear registers" (STMPE_IDX_GPCR_XXX) must be set to > same value as "set registers" (STMPE_IDX_GPSR_XXX), ie > STMPE1600_REG_GPSR_XXX. > > Signed-off-by: Hugues Fruchet > --- > drivers/mfd/stmpe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mfd/stmpe.c b/drivers/mfd/stmpe.c > index b0c7bcd..566caca 100644 > --- a/drivers/mfd/stmpe.c > +++ b/drivers/mfd/stmpe.c > @@ -568,6 +568,8 @@ static int stmpe811_get_altfunc(struct stmpe *stmpe, enum stmpe_block block) > [STMPE_IDX_GPMR_CSB] = STMPE1600_REG_GPMR_MSB, > [STMPE_IDX_GPSR_LSB] = STMPE1600_REG_GPSR_LSB, > [STMPE_IDX_GPSR_CSB] = STMPE1600_REG_GPSR_MSB, > + [STMPE_IDX_GPCR_LSB] = STMPE1600_REG_GPSR_LSB, > + [STMPE_IDX_GPCR_CSB] = STMPE1600_REG_GPSR_MSB, > [STMPE_IDX_GPDR_LSB] = STMPE1600_REG_GPDR_LSB, > [STMPE_IDX_GPDR_CSB] = STMPE1600_REG_GPDR_MSB, > [STMPE_IDX_IEGPIOR_LSB] = STMPE1600_REG_IEGPIOR_LSB, > Reviewed-by: Patrice Chotard Thanks