From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1294AC433E2 for ; Thu, 17 Sep 2020 11:36:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE69921655 for ; Thu, 17 Sep 2020 11:36:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="U4hsB4GE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726808AbgIQLgw (ORCPT ); Thu, 17 Sep 2020 07:36:52 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:35824 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726822AbgIQL3K (ORCPT ); Thu, 17 Sep 2020 07:29:10 -0400 X-Greylist: delayed 4201 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Sep 2020 07:29:03 EDT Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08HAI0qe010583; Thu, 17 Sep 2020 05:18:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1600337880; bh=nF94rj5wLkPLwYnqYDJZW1Y0SHQFeOaaaswY3EiKhnc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=U4hsB4GEEz0ISKqJEzygwcJ6aG1Qwr0mQtol8Sc1gN3bvW51sUnpsQgT3hDzFe193 YzAFiA/36TbMGOslABZw8HTU2POqsPgonKBCIiXj1z2Bsdg6CqdX87HpQvqMa6pivJ VZEUtjrLwhKNYIaWXmEthcLkXlpYbSZ8qiwCikBM= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08HAI0WH073785; Thu, 17 Sep 2020 05:18:00 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 17 Sep 2020 05:18:00 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 17 Sep 2020 05:18:00 -0500 Received: from [10.250.232.147] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08HAHuAd120951; Thu, 17 Sep 2020 05:17:57 -0500 Subject: Re: [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines To: Nishanth Menon , Peter Rosin CC: Roger Quadros , , , , , , References: <20200915112038.30219-1-rogerq@ti.com> <20200915112038.30219-2-rogerq@ti.com> <20200916154536.m552ft2jzfsaeokr@akan> From: Kishon Vijay Abraham I Message-ID: <8a27f8f3-20c4-f72c-b683-81153107d867@ti.com> Date: Thu, 17 Sep 2020 15:47:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200916154536.m552ft2jzfsaeokr@akan> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nishanth, On 16/09/20 9:15 pm, Nishanth Menon wrote: > On 06:52-20200916, Peter Rosin wrote: >> Hi, >> >> Sorry for the delay. >> >> On 2020-09-15 13:20, Roger Quadros wrote: >>> Each SERDES lane mux can select upto 4 different IPs. >>> There are 4 lanes in each J7200 SERDES. Define all >>> the possible functions in this file. >>> >>> Cc: Peter Rosin >>> Signed-off-by: Roger Quadros >>> --- >>> include/dt-bindings/mux/mux-j7200-wiz.h | 29 +++++++++++++++++++++++++ >>> 1 file changed, 29 insertions(+) >>> create mode 100644 include/dt-bindings/mux/mux-j7200-wiz.h >>> >>> diff --git a/include/dt-bindings/mux/mux-j7200-wiz.h b/include/dt-bindings/mux/mux-j7200-wiz.h >>> new file mode 100644 >>> index 000000000000..b091b1185a36 >>> --- /dev/null >>> +++ b/include/dt-bindings/mux/mux-j7200-wiz.h >>> @@ -0,0 +1,29 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +/* >>> + * This header provides constants for J7200 WIZ. >>> + */ >>> + >>> +#ifndef _DT_BINDINGS_J7200_WIZ >>> +#define _DT_BINDINGS_J7200_WIZ >>> + >>> +#define SERDES0_LANE0_QSGMII_LANE3 0x0 >>> +#define SERDES0_LANE0_PCIE1_LANE0 0x1 >>> +#define SERDES0_LANE0_IP3_UNUSED 0x2 >>> +#define SERDES0_LANE0_IP4_UNUSED 0x3 >>> + >>> +#define SERDES0_LANE1_QSGMII_LANE4 0x0 >>> +#define SERDES0_LANE1_PCIE1_LANE1 0x1 >>> +#define SERDES0_LANE1_IP3_UNUSED 0x2 >>> +#define SERDES0_LANE1_IP4_UNUSED 0x3 >>> + >>> +#define SERDES0_LANE2_QSGMII_LANE1 0x0 >>> +#define SERDES0_LANE2_PCIE1_LANE2 0x1 >>> +#define SERDES0_LANE2_IP3_UNUSED 0x2 >>> +#define SERDES0_LANE2_IP4_UNUSED 0x3 >>> + >>> +#define SERDES0_LANE3_QSGMII_LANE2 0x0 >>> +#define SERDES0_LANE3_PCIE1_LANE3 0x1 >>> +#define SERDES0_LANE3_USB 0x2 >>> +#define SERDES0_LANE3_IP4_UNUSED 0x3 >>> + >>> +#endif /* _DT_BINDINGS_J7200_WIZ */ >> >> Should not the defines start with J7200_WIZ? SERDES0 seems like a too >> generic prefix, at least to me. > > Thanks, good point. I am not sure if WIZ should even be used.. It is > a TI internal prefix for various serdes solutions, but I agree that > SERDES0 is too generic a terminology. That said, we should cleanup > include/dt-bindings/mux/mux-j721e-wiz.h as well, prior to introducing > j7200 changes. WIZ is defined in public TRM (https://www.ti.com/lit/pdf/spruiu1). " The SERDES mux (WIZ) module supports the following features: *) Multiplexes device interfaces onto a single SERDES lane (Tx and Rx) *) Provides registers to implement SERDES control and status functions and alignment delays . . " Thanks Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77194C35256 for ; Thu, 17 Sep 2020 10:20:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C70B2083B for ; Thu, 17 Sep 2020 10:20:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZYBSXOrO"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="U4hsB4GE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C70B2083B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=R0RJ7Ak6jKt7GQ18KWUXZBELuRuJbdyJKnKTdBQV0MI=; b=ZYBSXOrOnf5F45mVhFo6rU+86 39szt3kle28PIf7WJLFNvcIcm4C3GtYNe/5REibAPKole2PwAFtjwbdyMELkYrqgQQH+urIe7Ydv2 STD0VW8KZxCvH6kTuOHDBEAz1qyBS1VdenvS7m4jBnHjkLu2tJcD7MsKO77NQRG3lnS/XxD7Ld+xg 9gWQJxejvrgqu1vFXvCb+cxMN95KFE4aMaJrg/jRNajZ4ZWwjei7OTqvo/E+iNWFQm5r2FPCKtFlu riTFQoQMrwiHE8bionGLrGY1+7oNpUTmIRIE7vxFE+4jS9YoAtj75Pk2kOtQL/a1+OND8ozTxshW5 Ehy2rX46g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIr06-000436-S9; Thu, 17 Sep 2020 10:18:50 +0000 Received: from lelv0142.ext.ti.com ([198.47.23.249]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIqzx-0003jY-HK for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 10:18:48 +0000 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 08HAI0qe010583; Thu, 17 Sep 2020 05:18:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1600337880; bh=nF94rj5wLkPLwYnqYDJZW1Y0SHQFeOaaaswY3EiKhnc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=U4hsB4GEEz0ISKqJEzygwcJ6aG1Qwr0mQtol8Sc1gN3bvW51sUnpsQgT3hDzFe193 YzAFiA/36TbMGOslABZw8HTU2POqsPgonKBCIiXj1z2Bsdg6CqdX87HpQvqMa6pivJ VZEUtjrLwhKNYIaWXmEthcLkXlpYbSZ8qiwCikBM= Received: from DFLE110.ent.ti.com (dfle110.ent.ti.com [10.64.6.31]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08HAI0WH073785; Thu, 17 Sep 2020 05:18:00 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE110.ent.ti.com (10.64.6.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 17 Sep 2020 05:18:00 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 17 Sep 2020 05:18:00 -0500 Received: from [10.250.232.147] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 08HAHuAd120951; Thu, 17 Sep 2020 05:17:57 -0500 Subject: Re: [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines To: Nishanth Menon , Peter Rosin References: <20200915112038.30219-1-rogerq@ti.com> <20200915112038.30219-2-rogerq@ti.com> <20200916154536.m552ft2jzfsaeokr@akan> From: Kishon Vijay Abraham I Message-ID: <8a27f8f3-20c4-f72c-b683-81153107d867@ti.com> Date: Thu, 17 Sep 2020 15:47:56 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200916154536.m552ft2jzfsaeokr@akan> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_061841_700065_0EC92879 X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, t-kristo@ti.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Nishanth, On 16/09/20 9:15 pm, Nishanth Menon wrote: > On 06:52-20200916, Peter Rosin wrote: >> Hi, >> >> Sorry for the delay. >> >> On 2020-09-15 13:20, Roger Quadros wrote: >>> Each SERDES lane mux can select upto 4 different IPs. >>> There are 4 lanes in each J7200 SERDES. Define all >>> the possible functions in this file. >>> >>> Cc: Peter Rosin >>> Signed-off-by: Roger Quadros >>> --- >>> include/dt-bindings/mux/mux-j7200-wiz.h | 29 +++++++++++++++++++++++++ >>> 1 file changed, 29 insertions(+) >>> create mode 100644 include/dt-bindings/mux/mux-j7200-wiz.h >>> >>> diff --git a/include/dt-bindings/mux/mux-j7200-wiz.h b/include/dt-bindings/mux/mux-j7200-wiz.h >>> new file mode 100644 >>> index 000000000000..b091b1185a36 >>> --- /dev/null >>> +++ b/include/dt-bindings/mux/mux-j7200-wiz.h >>> @@ -0,0 +1,29 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >>> +/* >>> + * This header provides constants for J7200 WIZ. >>> + */ >>> + >>> +#ifndef _DT_BINDINGS_J7200_WIZ >>> +#define _DT_BINDINGS_J7200_WIZ >>> + >>> +#define SERDES0_LANE0_QSGMII_LANE3 0x0 >>> +#define SERDES0_LANE0_PCIE1_LANE0 0x1 >>> +#define SERDES0_LANE0_IP3_UNUSED 0x2 >>> +#define SERDES0_LANE0_IP4_UNUSED 0x3 >>> + >>> +#define SERDES0_LANE1_QSGMII_LANE4 0x0 >>> +#define SERDES0_LANE1_PCIE1_LANE1 0x1 >>> +#define SERDES0_LANE1_IP3_UNUSED 0x2 >>> +#define SERDES0_LANE1_IP4_UNUSED 0x3 >>> + >>> +#define SERDES0_LANE2_QSGMII_LANE1 0x0 >>> +#define SERDES0_LANE2_PCIE1_LANE2 0x1 >>> +#define SERDES0_LANE2_IP3_UNUSED 0x2 >>> +#define SERDES0_LANE2_IP4_UNUSED 0x3 >>> + >>> +#define SERDES0_LANE3_QSGMII_LANE2 0x0 >>> +#define SERDES0_LANE3_PCIE1_LANE3 0x1 >>> +#define SERDES0_LANE3_USB 0x2 >>> +#define SERDES0_LANE3_IP4_UNUSED 0x3 >>> + >>> +#endif /* _DT_BINDINGS_J7200_WIZ */ >> >> Should not the defines start with J7200_WIZ? SERDES0 seems like a too >> generic prefix, at least to me. > > Thanks, good point. I am not sure if WIZ should even be used.. It is > a TI internal prefix for various serdes solutions, but I agree that > SERDES0 is too generic a terminology. That said, we should cleanup > include/dt-bindings/mux/mux-j721e-wiz.h as well, prior to introducing > j7200 changes. WIZ is defined in public TRM (https://www.ti.com/lit/pdf/spruiu1). " The SERDES mux (WIZ) module supports the following features: *) Multiplexes device interfaces onto a single SERDES lane (Tx and Rx) *) Provides registers to implement SERDES control and status functions and alignment delays . . " Thanks Kishon _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel