From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] dmaengine: stm32-mdma: Revert "Add a check on read_u32_array" From: Pierre Yves MORDRET Message-Id: <8a28e0d8-93d6-3cb7-a53a-26017aa89e16@st.com> Date: Tue, 26 Mar 2019 09:55:00 +0100 To: Vinod Koul Cc: Dan Williams , Maxime Coquelin , Alexandre Torgue , dmaengine@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: T24gMy8yNS8xOSA1OjI4IFBNLCBWaW5vZCBLb3VsIHdyb3RlOgo+IE9uIDI1LTAzLTE5LCAxNzoy MSwgUGllcnJlLVl2ZXMgTU9SRFJFVCB3cm90ZToKPj4gVGhpcyByZXZlcnRzIGNvbW1pdCA5MDZi NDBiMjQ2YjAgKCJBZGQgYSBjaGVjayBvbiByZWFkX3UzMl9hcnJheSIpCj4gCj4gVGhpcyBhbmQg cGF0Y2ggdGl0bGUgc2hvdWxkIGNvbnRhaW46Cj4gOTA2YjQwYjI0NmIwICgiZG1hZW5naW5lOiBz dG0zMi1tZG1hOiBBZGQgYSBjaGVjayBvbiByZWFkX3UzMl9hcnJheSIpCj4gCj4gSSBoYXZlIGZp eGVkIGl0IHVwIGFuZCBhcHBsaWVkLgoKRGFybiBpdCwgc29ycnkuCk1hbnkgdGhhbmtzIGJ0dyA6 KQoKPiAKPiBUaGFua3MKPiAKPj4gQXMgc3RhdGVkIGJ5IGJpbmRpbmdzICJzdCxhaGItYWRkci1t YXNrcyIgaXMgb3B0aW9uYWwuCj4+IFRoZSBzdGF0ZW1lbnQgaW5zZXJ0ZWQgYnkgdGhpcyBjb21t aXQgbWFrZXMgdGhpcyBwcm9wZXJ0eQo+PiBtYW5kYXRvcnkgYW5kIHByZXZlbnRzIE1ETUEgdG8g YmUgcHJvYmVkIGluIGNhc2UgcHJvcGVydHkgbm90IHByZXNlbnQuCj4+Cj4+IFNpZ25lZC1vZmYt Ynk6IFBpZXJyZS1ZdmVzIE1PUkRSRVQgPHBpZXJyZS15dmVzLm1vcmRyZXRAc3QuY29tPgo+PiAt LS0KPj4gICBWZXJzaW9uIGhpc3Rvcnk6Cj4+ICAgICB2MjoKPj4gICAgICAgICogcmV2aWV3IGNv bW1pdCBtZXNzYWdlCj4+ICAgICB2MToKPj4gICAgICAgICogSW5pdGlhbAo+PiAtLS0KPj4gLS0t Cj4+ICBkcml2ZXJzL2RtYS9zdG0zMi1tZG1hLmMgfCA0ICstLS0KPj4gIDEgZmlsZSBjaGFuZ2Vk LCAxIGluc2VydGlvbigrKSwgMyBkZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZG1hL3N0bTMyLW1kbWEuYyBiL2RyaXZlcnMvZG1hL3N0bTMyLW1kbWEuYwo+PiBpbmRleCA0 ZTBlZWRlLi5hYzAzMDFiIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2RtYS9zdG0zMi1tZG1hLmMK Pj4gKysrIGIvZHJpdmVycy9kbWEvc3RtMzItbWRtYS5jCj4+IEBAIC0xNTc4LDExICsxNTc4LDkg QEAgc3RhdGljIGludCBzdG0zMl9tZG1hX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCj4+ICAKPj4gIAlkbWFkZXYtPm5yX2NoYW5uZWxzID0gbnJfY2hhbm5lbHM7Cj4+ICAJZG1h ZGV2LT5ucl9yZXF1ZXN0cyA9IG5yX3JlcXVlc3RzOwo+PiAtCXJldCA9IGRldmljZV9wcm9wZXJ0 eV9yZWFkX3UzMl9hcnJheSgmcGRldi0+ZGV2LCAic3QsYWhiLWFkZHItbWFza3MiLAo+PiArCWRl dmljZV9wcm9wZXJ0eV9yZWFkX3UzMl9hcnJheSgmcGRldi0+ZGV2LCAic3QsYWhiLWFkZHItbWFz a3MiLAo+PiAgCQkJCSAgICAgICBkbWFkZXYtPmFoYl9hZGRyX21hc2tzLAo+PiAgCQkJCSAgICAg ICBjb3VudCk7Cj4+IC0JaWYgKHJldCkKPj4gLQkJcmV0dXJuIHJldDsKPj4gIAlkbWFkZXYtPm5y X2FoYl9hZGRyX21hc2tzID0gY291bnQ7Cj4+ICAKPj4gIAlyZXMgPSBwbGF0Zm9ybV9nZXRfcmVz b3VyY2UocGRldiwgSU9SRVNPVVJDRV9NRU0sIDApOwo+PiAtLSAKPj4gMi43LjQKPgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 470EFC43381 for ; Tue, 26 Mar 2019 08:55:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14ECD20856 for ; Tue, 26 Mar 2019 08:55:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730803AbfCZIzR (ORCPT ); Tue, 26 Mar 2019 04:55:17 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:23889 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726287AbfCZIzQ (ORCPT ); Tue, 26 Mar 2019 04:55:16 -0400 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2Q8rPg3026892; Tue, 26 Mar 2019 09:55:03 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2rddht8tsa-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 26 Mar 2019 09:55:03 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3607E31; Tue, 26 Mar 2019 08:55:02 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D3E3E2691; Tue, 26 Mar 2019 08:55:01 +0000 (GMT) Received: from [10.48.1.93] (10.75.127.46) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 26 Mar 2019 09:55:01 +0100 Subject: Re: [PATCH v2] dmaengine: stm32-mdma: Revert "Add a check on read_u32_array" To: Vinod Koul CC: Dan Williams , Maxime Coquelin , Alexandre Torgue , , , , References: <1553530915-1961-1-git-send-email-pierre-yves.mordret@st.com> <20190325162849.GS5348@vkoul-mobl> From: Pierre Yves MORDRET Message-ID: <8a28e0d8-93d6-3cb7-a53a-26017aa89e16@st.com> Date: Tue, 26 Mar 2019 09:55:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190325162849.GS5348@vkoul-mobl> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-26_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/25/19 5:28 PM, Vinod Koul wrote: > On 25-03-19, 17:21, Pierre-Yves MORDRET wrote: >> This reverts commit 906b40b246b0 ("Add a check on read_u32_array") > > This and patch title should contain: > 906b40b246b0 ("dmaengine: stm32-mdma: Add a check on read_u32_array") > > I have fixed it up and applied. Darn it, sorry. Many thanks btw :) > > Thanks > >> As stated by bindings "st,ahb-addr-masks" is optional. >> The statement inserted by this commit makes this property >> mandatory and prevents MDMA to be probed in case property not present. >> >> Signed-off-by: Pierre-Yves MORDRET >> --- >> Version history: >> v2: >> * review commit message >> v1: >> * Initial >> --- >> --- >> drivers/dma/stm32-mdma.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c >> index 4e0eede..ac0301b 100644 >> --- a/drivers/dma/stm32-mdma.c >> +++ b/drivers/dma/stm32-mdma.c >> @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev) >> >> dmadev->nr_channels = nr_channels; >> dmadev->nr_requests = nr_requests; >> - ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", >> + device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", >> dmadev->ahb_addr_masks, >> count); >> - if (ret) >> - return ret; >> dmadev->nr_ahb_addr_masks = count; >> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> -- >> 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 794A4C43381 for ; Tue, 26 Mar 2019 08:55:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49CC720856 for ; Tue, 26 Mar 2019 08:55:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Gv5qGiwD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 49CC720856 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9xaAKPD8egd6NMFLzH3uLMly3nh82aB9HJSklLldAvI=; b=Gv5qGiwDrBHbaL MYKllQDCsYSD0bLVif+9uO1nsgsGAsSfeR1MsmsKYlyjAMLRT8JuVKFGwoYwQe2NO+6wUQJlB7FQl dvhdlAbuD044FfozPD91tE+OfcPLC2r+bzPUiYt0IUd+BFX6YfSP8bSsp4oxdRbHvnD0xLmYytCWi ZlKEsEujDj1QccasggPrHSaR5j6r+1uC8ce3EsY+l7ZJGQJ67Eco8RiCvZitAYSg8B9azS/Ez5fsz djyJpEQzblH0TMN/xjsRjwgy3lmiN2VzeO0vpQMJZysJ0D48HqVRC9vzzd59q4HeGHvtgmyKEVldd Wacx3LUs7TvR2gVXnQRg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8hrZ-0000BH-0f; Tue, 26 Mar 2019 08:55:17 +0000 Received: from mx08-00178001.pphosted.com ([91.207.212.93] helo=mx07-00178001.pphosted.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8hrT-0000Aw-Ms for linux-arm-kernel@lists.infradead.org; Tue, 26 Mar 2019 08:55:13 +0000 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2Q8rPg3026892; Tue, 26 Mar 2019 09:55:03 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2rddht8tsa-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Tue, 26 Mar 2019 09:55:03 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 3607E31; Tue, 26 Mar 2019 08:55:02 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id D3E3E2691; Tue, 26 Mar 2019 08:55:01 +0000 (GMT) Received: from [10.48.1.93] (10.75.127.46) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 26 Mar 2019 09:55:01 +0100 Subject: Re: [PATCH v2] dmaengine: stm32-mdma: Revert "Add a check on read_u32_array" To: Vinod Koul References: <1553530915-1961-1-git-send-email-pierre-yves.mordret@st.com> <20190325162849.GS5348@vkoul-mobl> From: Pierre Yves MORDRET Message-ID: <8a28e0d8-93d6-3cb7-a53a-26017aa89e16@st.com> Date: Tue, 26 Mar 2019 09:55:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190325162849.GS5348@vkoul-mobl> Content-Language: en-US X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-03-26_05:, , signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190326_015512_049074_1B8DF01C X-CRM114-Status: GOOD ( 15.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , linux-kernel@vger.kernel.org, Maxime Coquelin , dmaengine@vger.kernel.org, Dan Williams , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/25/19 5:28 PM, Vinod Koul wrote: > On 25-03-19, 17:21, Pierre-Yves MORDRET wrote: >> This reverts commit 906b40b246b0 ("Add a check on read_u32_array") > > This and patch title should contain: > 906b40b246b0 ("dmaengine: stm32-mdma: Add a check on read_u32_array") > > I have fixed it up and applied. Darn it, sorry. Many thanks btw :) > > Thanks > >> As stated by bindings "st,ahb-addr-masks" is optional. >> The statement inserted by this commit makes this property >> mandatory and prevents MDMA to be probed in case property not present. >> >> Signed-off-by: Pierre-Yves MORDRET >> --- >> Version history: >> v2: >> * review commit message >> v1: >> * Initial >> --- >> --- >> drivers/dma/stm32-mdma.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c >> index 4e0eede..ac0301b 100644 >> --- a/drivers/dma/stm32-mdma.c >> +++ b/drivers/dma/stm32-mdma.c >> @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev) >> >> dmadev->nr_channels = nr_channels; >> dmadev->nr_requests = nr_requests; >> - ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", >> + device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", >> dmadev->ahb_addr_masks, >> count); >> - if (ret) >> - return ret; >> dmadev->nr_ahb_addr_masks = count; >> >> res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >> -- >> 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel