From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver Date: Fri, 24 Jan 2020 07:25:08 +0300 Message-ID: <8a3259b7-6875-236a-b16c-cd8e023cc8b2@gmail.com> References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-8-git-send-email-spujar@nvidia.com> <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> <3759aa0b-9e56-0fb4-27b7-4f98898d4e22@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <3759aa0b-9e56-0fb4-27b7-4f98898d4e22@nvidia.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Sameer Pujar , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, atalambedu@nvidia.com, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com, sharadg@nvidia.com, broonie@kernel.org, thierry.reding@gmail.com, linux-tegra@vger.kernel.org, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com List-Id: linux-tegra@vger.kernel.org 24.01.2020 06:27, Sameer Pujar пишет: > > > On 1/24/2020 6:58 AM, Dmitry Osipenko wrote: >> External email: Use caution opening links or attachments >> >> >> 20.01.2020 17:23, Sameer Pujar пишет: >> [snip] >>> +static bool tegra_admaif_wr_reg(struct device *dev, unsigned int reg) >>> +{ >>> +     struct tegra_admaif *admaif = dev_get_drvdata(dev); >>> +     unsigned int ch_stride = TEGRA_ADMAIF_CHANNEL_REG_STRIDE; >>> +     unsigned int num_ch = admaif->soc_data->num_ch; >>> +     unsigned int rx_base = admaif->soc_data->rx_base; >>> +     unsigned int tx_base = admaif->soc_data->tx_base; >>> +     unsigned int global_base = admaif->soc_data->global_base; >>> +     unsigned int reg_max = >>> admaif->soc_data->regmap_conf->max_register; >>> +     unsigned int rx_max = rx_base + (num_ch * ch_stride); >>> +     unsigned int tx_max = tx_base + (num_ch * ch_stride); >>> + >>> +     if ((reg >= rx_base) && (reg < rx_max)) { >> The braces are not needed around the comparisons because they precede >> the AND. Same for all other similar occurrences in the code. > > While that is true, some prefer to use explicit braces to make it more > readable. > In the past I was told to use explicitly in such cases. At least most of code in kernel (I've seen) doesn't have superfluous parens (the curvy thingies actually should be the braces). Readability is arguable in this case, I'm finding such code a bit more difficult to read, although in some cases parens and spacing may help to read more complex constructions. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A66E6C2D0CE for ; Fri, 24 Jan 2020 04:26:11 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2FC262071A for ; Fri, 24 Jan 2020 04:26:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="ZRRgvqlo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yqgm/L6R" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2FC262071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 581DC1665; Fri, 24 Jan 2020 05:25:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 581DC1665 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579839969; bh=PyYJ6eJx5H3PwiJts/7tpOvqYnhPwkca724tjRS9VMk=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ZRRgvqlossG2xrSeUmAxXSvF0DcPfUj4r0zI2q1Zl+E4mA/Ga+XFm7kLsbMBbqVT9 IwX8nBqDjandkXF8audhiEjbFMwhX0QeoK6l/thb/C72zz89DvogfGIj7Q7mIK0Aql a1Il38JYhERZvX+/Y7/gBjI8JYgZR25EK1MIt0vA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D0156F801D8; Fri, 24 Jan 2020 05:25:18 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 865ABF8020C; Fri, 24 Jan 2020 05:25:16 +0100 (CET) Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 37CD8F800F5 for ; Fri, 24 Jan 2020 05:25:12 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 37CD8F800F5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Yqgm/L6R" Received: by mail-lf1-x144.google.com with SMTP id m30so287442lfp.8 for ; Thu, 23 Jan 2020 20:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nqvrrfgH50F3heDUQV2TPxvyGIm9jjs0IGrVe+RwimE=; b=Yqgm/L6R0clKVYrscixlwYJrmLydO6eTZXRSwbpSsJkZRcKp28C3d7HqPnhXE8vqbH 9VdqiMw/4NEz4lxzg9g1A42L97lUsDUtkTs++ZjGiv/9mjFmGPsmezm7L5YrcZ7J7zNi SNZQwMmcFdpRp9XNelnkzmBRgDQU3K10FIKouhjNx01IweB+AvH7YZGLomp67wp5V5KR V1o9EcoAUzA28Q+wzAt43MypyA3faknk8Lp9HDE0raVbiy/DqAzutS+E/Cdm5LhWucoB 5AZ2SuyKr+7/6x+uDIg6v3vszDyYk8tq1/kw86qyWf/5VrEDXmifItnWblE2nraMF4ii pkGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nqvrrfgH50F3heDUQV2TPxvyGIm9jjs0IGrVe+RwimE=; b=lBm/gnrC4+aSneGX1mnOGmc1zMaPVZDd0UZ5djcFjm/ihQ5yeNrN+FQmWINmlqEfCV 7xDOK+423WKdMZ+wFNIfRetQTn81TRltettpjdOR8Ed9I1jbYLAOL1xNSiQC7yuk8q+F 8zdOPypiKHHxYuEs8wHLqk7amVmVJWH1xoZd5+yqpqGTlflSrg0cNOHJJyEKKF0SDCwc MVd881k0bFpdiDSGj9pP1BsmiQRAy1EThzhndLaAdinqGp7gn9kj+uYCsfYoKh6rRWZq 6ROjx0P0RyvEaDN9nff5e7yRnABuIpUt2Po2u7iwP/tWgoccA98GHWDYB9eTw2QthMP1 avrQ== X-Gm-Message-State: APjAAAUl5OVQRqo8LzjnBQfDkhfFOGViXT0F00Zly8dM4AHXjKMd8FZi ve1Vo3KK5pwW3CU8oQKcPVU= X-Google-Smtp-Source: APXvYqz9HRXIowhnShk3uHeDO/07QPAIONMd8ODEb7ccArNqgO+S9/aB3Jd/HegdKDhotT/9ZK1LTw== X-Received: by 2002:ac2:523c:: with SMTP id i28mr487778lfl.104.1579839912004; Thu, 23 Jan 2020 20:25:12 -0800 (PST) Received: from [192.168.2.145] (79-139-233-37.dynamic.spd-mgts.ru. [79.139.233.37]) by smtp.googlemail.com with ESMTPSA id f30sm2282977ljp.31.2020.01.23.20.25.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Jan 2020 20:25:11 -0800 (PST) To: Sameer Pujar , perex@perex.cz, tiwai@suse.com, robh+dt@kernel.org References: <1579530198-13431-1-git-send-email-spujar@nvidia.com> <1579530198-13431-8-git-send-email-spujar@nvidia.com> <743d6d7d-f29c-191a-853b-414250ca38df@gmail.com> <3759aa0b-9e56-0fb4-27b7-4f98898d4e22@nvidia.com> From: Dmitry Osipenko Message-ID: <8a3259b7-6875-236a-b16c-cd8e023cc8b2@gmail.com> Date: Fri, 24 Jan 2020 07:25:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.0 MIME-Version: 1.0 In-Reply-To: <3759aa0b-9e56-0fb4-27b7-4f98898d4e22@nvidia.com> Content-Language: en-US Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com, jonathanh@nvidia.com, viswanathl@nvidia.com, linux-tegra@vger.kernel.org, broonie@kernel.org, atalambedu@nvidia.com, sharadg@nvidia.com, thierry.reding@gmail.com, rlokhande@nvidia.com, mkumard@nvidia.com, dramesh@nvidia.com Subject: Re: [alsa-devel] [PATCH 7/9] ASoC: tegra: add Tegra210 based ADMAIF driver X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" MjQuMDEuMjAyMCAwNjoyNywgU2FtZWVyIFB1amFyINC/0LjRiNC10YI6Cj4gCj4gCj4gT24gMS8y NC8yMDIwIDY6NTggQU0sIERtaXRyeSBPc2lwZW5rbyB3cm90ZToKPj4gRXh0ZXJuYWwgZW1haWw6 IFVzZSBjYXV0aW9uIG9wZW5pbmcgbGlua3Mgb3IgYXR0YWNobWVudHMKPj4KPj4KPj4gMjAuMDEu MjAyMCAxNzoyMywgU2FtZWVyIFB1amFyINC/0LjRiNC10YI6Cj4+IFtzbmlwXQo+Pj4gK3N0YXRp YyBib29sIHRlZ3JhX2FkbWFpZl93cl9yZWcoc3RydWN0IGRldmljZSAqZGV2LCB1bnNpZ25lZCBp bnQgcmVnKQo+Pj4gK3sKPj4+ICvCoMKgwqDCoCBzdHJ1Y3QgdGVncmFfYWRtYWlmICphZG1haWYg PSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKPj4+ICvCoMKgwqDCoCB1bnNpZ25lZCBpbnQgY2hfc3Ry aWRlID0gVEVHUkFfQURNQUlGX0NIQU5ORUxfUkVHX1NUUklERTsKPj4+ICvCoMKgwqDCoCB1bnNp Z25lZCBpbnQgbnVtX2NoID0gYWRtYWlmLT5zb2NfZGF0YS0+bnVtX2NoOwo+Pj4gK8KgwqDCoMKg IHVuc2lnbmVkIGludCByeF9iYXNlID0gYWRtYWlmLT5zb2NfZGF0YS0+cnhfYmFzZTsKPj4+ICvC oMKgwqDCoCB1bnNpZ25lZCBpbnQgdHhfYmFzZSA9IGFkbWFpZi0+c29jX2RhdGEtPnR4X2Jhc2U7 Cj4+PiArwqDCoMKgwqAgdW5zaWduZWQgaW50IGdsb2JhbF9iYXNlID0gYWRtYWlmLT5zb2NfZGF0 YS0+Z2xvYmFsX2Jhc2U7Cj4+PiArwqDCoMKgwqAgdW5zaWduZWQgaW50IHJlZ19tYXggPQo+Pj4g YWRtYWlmLT5zb2NfZGF0YS0+cmVnbWFwX2NvbmYtPm1heF9yZWdpc3RlcjsKPj4+ICvCoMKgwqDC oCB1bnNpZ25lZCBpbnQgcnhfbWF4ID0gcnhfYmFzZSArIChudW1fY2ggKiBjaF9zdHJpZGUpOwo+ Pj4gK8KgwqDCoMKgIHVuc2lnbmVkIGludCB0eF9tYXggPSB0eF9iYXNlICsgKG51bV9jaCAqIGNo X3N0cmlkZSk7Cj4+PiArCj4+PiArwqDCoMKgwqAgaWYgKChyZWcgPj0gcnhfYmFzZSkgJiYgKHJl ZyA8IHJ4X21heCkpIHsKPj4gVGhlIGJyYWNlcyBhcmUgbm90IG5lZWRlZCBhcm91bmQgdGhlIGNv bXBhcmlzb25zIGJlY2F1c2UgdGhleSBwcmVjZWRlCj4+IHRoZSBBTkQuIFNhbWUgZm9yIGFsbCBv dGhlciBzaW1pbGFyIG9jY3VycmVuY2VzIGluIHRoZSBjb2RlLgo+IAo+IFdoaWxlIHRoYXQgaXMg dHJ1ZSwgc29tZSBwcmVmZXIgdG8gdXNlIGV4cGxpY2l0IGJyYWNlcyB0byBtYWtlIGl0IG1vcmUK PiByZWFkYWJsZS4KPiBJbiB0aGUgcGFzdCBJIHdhcyB0b2xkIHRvIHVzZSBleHBsaWNpdGx5IGlu IHN1Y2ggY2FzZXMuCgpBdCBsZWFzdCBtb3N0IG9mIGNvZGUgaW4ga2VybmVsIChJJ3ZlIHNlZW4p IGRvZXNuJ3QgaGF2ZSBzdXBlcmZsdW91cwpwYXJlbnMgKHRoZSBjdXJ2eSB0aGluZ2llcyBhY3R1 YWxseSBzaG91bGQgYmUgdGhlIGJyYWNlcykuIFJlYWRhYmlsaXR5CmlzIGFyZ3VhYmxlIGluIHRo aXMgY2FzZSwgSSdtIGZpbmRpbmcgc3VjaCBjb2RlIGEgYml0IG1vcmUgZGlmZmljdWx0IHRvCnJl YWQsIGFsdGhvdWdoIGluIHNvbWUgY2FzZXMgcGFyZW5zIGFuZCBzcGFjaW5nIG1heSBoZWxwIHRv IHJlYWQgbW9yZQpjb21wbGV4IGNvbnN0cnVjdGlvbnMuCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2 ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwczovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9yZy9tYWls bWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK