From: "Christian König" <christian.koenig@amd.com>
To: Lucas Stach <l.stach@pengutronix.de>, dri-devel@lists.freedesktop.org
Cc: Robert Beckett <bob.beckett@collabora.com>,
kernel@pengutronix.de, patchwork-lst@pengutronix.de
Subject: Re: [PATCH] drm/sched: add run job trace
Date: Fri, 13 Mar 2020 11:17:52 +0100 [thread overview]
Message-ID: <8a3cd453-4351-af4a-93df-9b290fa1e582@amd.com> (raw)
In-Reply-To: <20200313095640.17967-1-l.stach@pengutronix.de>
Am 13.03.20 um 10:56 schrieb Lucas Stach:
> From: Robert Beckett <bob.beckett@collabora.com>
>
> Add a new trace event to show when jobs are run on the HW.
>
> Signed-off-by: Robert Beckett <bob.beckett@collabora.com>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
There is also the scheduled fence we could used for this, but this trace
point adds a few extra fields which might be useful.
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> .../gpu/drm/scheduler/gpu_scheduler_trace.h | 27 +++++++++++++++++++
> drivers/gpu/drm/scheduler/sched_main.c | 1 +
> 2 files changed, 28 insertions(+)
>
> diff --git a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
> index d79086498aff..877ce9b127f1 100644
> --- a/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
> +++ b/drivers/gpu/drm/scheduler/gpu_scheduler_trace.h
> @@ -59,6 +59,33 @@ TRACE_EVENT(drm_sched_job,
> __entry->job_count, __entry->hw_job_count)
> );
>
> +TRACE_EVENT(drm_run_job,
> + TP_PROTO(struct drm_sched_job *sched_job, struct drm_sched_entity *entity),
> + TP_ARGS(sched_job, entity),
> + TP_STRUCT__entry(
> + __field(struct drm_sched_entity *, entity)
> + __field(struct dma_fence *, fence)
> + __field(const char *, name)
> + __field(uint64_t, id)
> + __field(u32, job_count)
> + __field(int, hw_job_count)
> + ),
> +
> + TP_fast_assign(
> + __entry->entity = entity;
> + __entry->id = sched_job->id;
> + __entry->fence = &sched_job->s_fence->finished;
> + __entry->name = sched_job->sched->name;
> + __entry->job_count = spsc_queue_count(&entity->job_queue);
> + __entry->hw_job_count = atomic_read(
> + &sched_job->sched->hw_rq_count);
> + ),
> + TP_printk("entity=%p, id=%llu, fence=%p, ring=%s, job count:%u, hw job count:%d",
> + __entry->entity, __entry->id,
> + __entry->fence, __entry->name,
> + __entry->job_count, __entry->hw_job_count)
> +);
> +
> TRACE_EVENT(drm_sched_process_job,
> TP_PROTO(struct drm_sched_fence *fence),
> TP_ARGS(fence),
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 71ce6215956f..34231b7163cc 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -773,6 +773,7 @@ static int drm_sched_main(void *param)
> atomic_inc(&sched->hw_rq_count);
> drm_sched_job_begin(sched_job);
>
> + trace_drm_run_job(sched_job, entity);
> fence = sched->ops->run_job(sched_job);
> drm_sched_fence_scheduled(s_fence);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-13 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 9:56 [PATCH] drm/sched: add run job trace Lucas Stach
2020-03-13 10:17 ` Christian König [this message]
2020-03-13 14:25 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a3cd453-4351-af4a-93df-9b290fa1e582@amd.com \
--to=christian.koenig@amd.com \
--cc=bob.beckett@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=patchwork-lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.