From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Subject: Re: [PATCH 4/6] drm/i915/ringbuffer: Move irq seqno
 barrier to the GPU for gen7
Date: Mon, 31 Dec 2018 10:43:07 +0000
Message-ID: <8a4a057e-c784-2466-66ff-e69055200426@linux.intel.com>
References: <20181228171641.16531-1-chris@chris-wilson.co.uk>
 <20181228171641.16531-4-chris@chris-wilson.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 49CE989949
 for <intel-gfx@lists.freedesktop.org>; Mon, 31 Dec 2018 10:43:10 +0000 (UTC)
In-Reply-To: <20181228171641.16531-4-chris@chris-wilson.co.uk>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Ck9uIDI4LzEyLzIwMTggMTc6MTYsIENocmlzIFdpbHNvbiB3cm90ZToKPiBUaGUgaXJxX3NlcW5v
X2JhcnJpZXIgaXMgYSB0cmFkZW9mZiBiZXR3ZWVuIGRvaW5nIHdvcmsgb24gZXZlcnkgcmVxdWVz
dAo+IChvbiB0aGUgR1BVKSBhbmQgZG9pbmcgd29yayBhZnRlciBldmVyeSBpbnRlcnJ1cHQgKG9u
IHRoZSBDUFUpLiBXZQo+IHByZXN1bWUgd2UgaGF2ZSBtYW55IG1vcmUgcmVxdWVzdHMgdGhhbiBp
bnRlcnJ1cHRzISBIb3dldmVyLCB0aGUgY3VycmVudAo+IHcvYSBmb3IgSXZ5YnJpZGdlIGlzIGFu
IGltcGxpY2l0IGRlbGF5IHRoYXQgY3VycmVudGx5IGZhaWxzIHNwb3JhZGljYWxseQo+IGFuZCBj
b25zaXN0ZW50bHkgaWYgd2UgbW92ZSB0aGUgdy9hIGludG8gdGhlIGlycSBoYW5kbGVyIGl0c2Vs
Zi4gVGhpcwo+IG1ha2VzIHRoZSBDUFUgYmFycmllciB1bnRlbmFibGUgZm9yIHVwY29taW5nIGlu
dGVycnVwdCBoYW5kbGVyIGNoYW5nZXMKPiBhbmQgc28gd2UgbmVlZCB0byByZXBsYWNlIGl0IHdp
dGggYSBkZWxheSBvbiB0aGUgR1BVIGJlZm9yZSB3ZSBzZW5kIHRoZQo+IE1JX1VTRVJfSU5URVJS
VVBULiBBcyBpdCB0dXJucyBvdXQgdGhhdCBkZWxheSBpcyAzMnggTUlfU1RPUkVfRFdPUkRfSU1N
LAo+IG9yIGFib3V0IDAuNnVzIHBlciByZXF1ZXN0ISBRdWl0ZSBuYXN0eSwgYnV0IHRoZSBsZXNz
ZXIgb2YgdHdvIGV2aWxzCj4gbG9va2luZyB0byB0aGUgZnV0dXJlLgo+IAo+IFRlc3RjYXNlOiBp
Z3QvZ2VtX3N5bmMKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp
bHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3JpbmdidWZm
ZXIuYyB8IDgwICsrKysrKysrKysrKysrLS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0
NCBpbnNlcnRpb25zKCspLCAzNiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfcmluZ2J1ZmZlci5jCj4gaW5kZXggMmZiM2EzNjRjMzkwLi5kZDk5NjEwM2Q0OTUgMTAw
NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gKysr
IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5jCj4gQEAgLTQ0Myw2ICs0
NDMsMzQgQEAgc3RhdGljIHZvaWQgZ2VuNl94Y3NfZW1pdF9icmVhZGNydW1iKHN0cnVjdCBpOTE1
X3JlcXVlc3QgKnJxLCB1MzIgKmNzKQo+ICAgfQo+ICAgc3RhdGljIGNvbnN0IGludCBnZW42X3hj
c19lbWl0X2JyZWFkY3J1bWJfc3ogPSA0Owo+ICAgCj4gKyNkZWZpbmUgR0VON19YQ1NfV0EgMzIK
PiArc3RhdGljIHZvaWQgZ2VuN194Y3NfZW1pdF9icmVhZGNydW1iKHN0cnVjdCBpOTE1X3JlcXVl
c3QgKnJxLCB1MzIgKmNzKQo+ICt7Cj4gKwlpbnQgaTsKPiArCj4gKwkqY3MrKyA9IE1JX0ZMVVNI
X0RXIHwgTUlfRkxVU0hfRFdfT1BfU1RPUkVEVzsKPiArCSpjcysrID0gaW50ZWxfaHdzX3NlcW5v
X2FkZHJlc3MocnEtPmVuZ2luZSkgfCBNSV9GTFVTSF9EV19VU0VfR1RUOwo+ICsJKmNzKysgPSBy
cS0+Z2xvYmFsX3NlcW5vOwo+ICsKPiArCWZvciAoaSA9IDA7IGkgPCBHRU43X1hDU19XQTsgaSsr
KSB7Cj4gKwkJKmNzKysgPSBNSV9TVE9SRV9EV09SRF9JTkRFWDsKPiArCQkqY3MrKyA9IEk5MTVf
R0VNX0hXU19JTkRFWF9BRERSOwo+ICsJCSpjcysrID0gcnEtPmdsb2JhbF9zZXFubzsKPiArCX0K
PiArCj4gKwkqY3MrKyA9IE1JX0ZMVVNIX0RXOwo+ICsJKmNzKysgPSAwOwo+ICsJKmNzKysgPSAw
Owo+ICsKPiArCSpjcysrID0gTUlfVVNFUl9JTlRFUlJVUFQ7Cj4gKwkqY3MrKyA9IE1JX05PT1A7
Cj4gKwo+ICsJcnEtPnRhaWwgPSBpbnRlbF9yaW5nX29mZnNldChycSwgY3MpOwo+ICsJYXNzZXJ0
X3JpbmdfdGFpbF92YWxpZChycS0+cmluZywgcnEtPnRhaWwpOwo+ICt9Cj4gK3N0YXRpYyBjb25z
dCBpbnQgZ2VuN194Y3NfZW1pdF9icmVhZGNydW1iX3N6ID0gOCArIEdFTjdfWENTX1dBICogMzsK
CklzIGl0IHdvcnRoIG1vdmluZyB0aGlzIGJlZm9yZSB0aGUgZnVuY3Rpb24sIGFuZCB0aGVuIGlu
IHRoZSBmdW5jdGlvbiAKaGF2ZSBhIGxpdHRsZSBHRU1fQlVHX09OIHVzaW5nIGNzIHBvaW50ZXIg
YXJpdGhtZXRpYyB0byBjaGVjayB0aGUgdHdvIApzaXplcyBtYXRjaD8gT3IgZXZlbiBzaW1wbGVy
IHRoZSBmdW5jdGlvbiBjb3VsZCB1c2UgCmVuZ2luZS0+ZW1pdF9icmVhZGNydW1iX3N6IHRvIGNo
ZWNrIGFnYWluc3QuCgo+ICsjdW5kZWYgR0VON19YQ1NfV0EKPiArCj4gICBzdGF0aWMgdm9pZCBz
ZXRfaHdzdGFtKHN0cnVjdCBpbnRlbF9lbmdpbmVfY3MgKmVuZ2luZSwgdTMyIG1hc2spCj4gICB7
Cj4gICAJLyoKPiBAQCAtODc0LDMxICs5MDIsNiBAQCBnZW41X3NlcW5vX2JhcnJpZXIoc3RydWN0
IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCXVzbGVlcF9yYW5nZSgxMjUsIDI1MCk7Cj4g
ICB9Cj4gICAKPiAtc3RhdGljIHZvaWQKPiAtZ2VuNl9zZXFub19iYXJyaWVyKHN0cnVjdCBpbnRl
bF9lbmdpbmVfY3MgKmVuZ2luZSkKPiAtewo+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2ID0gZW5naW5lLT5pOTE1Owo+IC0KPiAtCS8qIFdvcmthcm91bmQgdG8gZm9yY2UgY29y
cmVjdCBvcmRlcmluZyBiZXR3ZWVuIGlycSBhbmQgc2Vxbm8gd3JpdGVzIG9uCj4gLQkgKiBpdmIg
KGFuZCBtYXliZSBhbHNvIG9uIHNuYikgYnkgcmVhZGluZyBmcm9tIGEgQ1MgcmVnaXN0ZXIgKGxp
a2UKPiAtCSAqIEFDVEhEKSBiZWZvcmUgcmVhZGluZyB0aGUgc3RhdHVzIHBhZ2UuCj4gLQkgKgo+
IC0JICogTm90ZSB0aGF0IHRoaXMgZWZmZWN0aXZlbHkgc3RhbGxzIHRoZSByZWFkIGJ5IHRoZSB0
aW1lIGl0IHRha2VzIHRvCj4gLQkgKiBkbyBhIG1lbW9yeSB0cmFuc2FjdGlvbiwgd2hpY2ggbW9y
ZSBvciBsZXNzIGVuc3VyZXMgdGhhdCB0aGUgd3JpdGUKPiAtCSAqIGZyb20gdGhlIEdQVSBoYXMg
c3VmZmljaWVudCB0aW1lIHRvIGludmFsaWRhdGUgdGhlIENQVSBjYWNoZWxpbmUuCj4gLQkgKiBB
bHRlcm5hdGl2ZWx5IHdlIGNvdWxkIGRlbGF5IHRoZSBpbnRlcnJ1cHQgZnJvbSB0aGUgQ1Mgcmlu
ZyB0byBnaXZlCj4gLQkgKiB0aGUgd3JpdGUgdGltZSB0byBsYW5kLCBidXQgdGhhdCB3b3VsZCBp
bmN1ciBhIGRlbGF5IGFmdGVyIGV2ZXJ5Cj4gLQkgKiBiYXRjaCBpLmUuIG11Y2ggbW9yZSBmcmVx
dWVudCB0aGFuIGEgZGVsYXkgd2hlbiB3YWl0aW5nIGZvciB0aGUKPiAtCSAqIGludGVycnVwdCAo
d2l0aCB0aGUgc2FtZSBuZXQgbGF0ZW5jeSkuCj4gLQkgKgo+IC0JICogQWxzbyBub3RlIHRoYXQg
dG8gcHJldmVudCB3aG9sZSBtYWNoaW5lIGhhbmdzIG9uIGdlbjcsIHdlIGhhdmUgdG8KPiAtCSAq
IHRha2UgdGhlIHNwaW5sb2NrIHRvIGd1YXJkIGFnYWluc3QgY29uY3VycmVudCBjYWNoZWxpbmUg
YWNjZXNzLgo+IC0JICovCj4gLQlzcGluX2xvY2tfaXJxKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2sp
Owo+IC0JUE9TVElOR19SRUFEX0ZXKFJJTkdfQUNUSEQoZW5naW5lLT5tbWlvX2Jhc2UpKTsKPiAt
CXNwaW5fdW5sb2NrX2lycSgmZGV2X3ByaXYtPnVuY29yZS5sb2NrKTsKPiAtfQo+IC0KPiAgIHN0
YXRpYyB2b2lkCj4gICBnZW41X2lycV9lbmFibGUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5n
aW5lKQo+ICAgewo+IEBAIC0yMjU4LDEwICsyMjYxLDEzIEBAIGludCBpbnRlbF9pbml0X2JzZF9y
aW5nX2J1ZmZlcihzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJCWVuZ2luZS0+
ZW1pdF9mbHVzaCA9IGdlbjZfYnNkX3JpbmdfZmx1c2g7Cj4gICAJCWVuZ2luZS0+aXJxX2VuYWJs
ZV9tYXNrID0gR1RfQlNEX1VTRVJfSU5URVJSVVBUOwo+ICAgCj4gLQkJZW5naW5lLT5lbWl0X2Jy
ZWFkY3J1bWIgPSBnZW42X3hjc19lbWl0X2JyZWFkY3J1bWI7Cj4gLQkJZW5naW5lLT5lbWl0X2Jy
ZWFkY3J1bWJfc3ogPSBnZW42X3hjc19lbWl0X2JyZWFkY3J1bWJfc3o7Cj4gLQkJaWYgKCFJU19H
RU4oZGV2X3ByaXYsIDYpKQo+IC0JCQllbmdpbmUtPmlycV9zZXFub19iYXJyaWVyID0gZ2VuNl9z
ZXFub19iYXJyaWVyOwo+ICsJCWlmIChJU19HRU4oZGV2X3ByaXYsIDYpKSB7Cj4gKwkJCWVuZ2lu
ZS0+ZW1pdF9icmVhZGNydW1iID0gZ2VuNl94Y3NfZW1pdF9icmVhZGNydW1iOwo+ICsJCQllbmdp
bmUtPmVtaXRfYnJlYWRjcnVtYl9zeiA9IGdlbjZfeGNzX2VtaXRfYnJlYWRjcnVtYl9zejsKPiAr
CQl9IGVsc2Ugewo+ICsJCQllbmdpbmUtPmVtaXRfYnJlYWRjcnVtYiA9IGdlbjdfeGNzX2VtaXRf
YnJlYWRjcnVtYjsKPiArCQkJZW5naW5lLT5lbWl0X2JyZWFkY3J1bWJfc3ogPSBnZW43X3hjc19l
bWl0X2JyZWFkY3J1bWJfc3o7Cj4gKwkJfQo+ICAgCX0gZWxzZSB7Cj4gICAJCWVuZ2luZS0+ZW1p
dF9mbHVzaCA9IGJzZF9yaW5nX2ZsdXNoOwo+ICAgCQlpZiAoSVNfR0VOKGRldl9wcml2LCA1KSkK
PiBAQCAtMjI4NCwxMCArMjI5MCwxMyBAQCBpbnQgaW50ZWxfaW5pdF9ibHRfcmluZ19idWZmZXIo
c3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+ICAgCWVuZ2luZS0+ZW1pdF9mbHVzaCA9
IGdlbjZfcmluZ19mbHVzaDsKPiAgIAllbmdpbmUtPmlycV9lbmFibGVfbWFzayA9IEdUX0JMVF9V
U0VSX0lOVEVSUlVQVDsKPiAgIAo+IC0JZW5naW5lLT5lbWl0X2JyZWFkY3J1bWIgPSBnZW42X3hj
c19lbWl0X2JyZWFkY3J1bWI7Cj4gLQllbmdpbmUtPmVtaXRfYnJlYWRjcnVtYl9zeiA9IGdlbjZf
eGNzX2VtaXRfYnJlYWRjcnVtYl9zejsKPiAtCWlmICghSVNfR0VOKGRldl9wcml2LCA2KSkKPiAt
CQllbmdpbmUtPmlycV9zZXFub19iYXJyaWVyID0gZ2VuNl9zZXFub19iYXJyaWVyOwo+ICsJaWYg
KElTX0dFTihkZXZfcHJpdiwgNikpIHsKPiArCQllbmdpbmUtPmVtaXRfYnJlYWRjcnVtYiA9IGdl
bjZfeGNzX2VtaXRfYnJlYWRjcnVtYjsKPiArCQllbmdpbmUtPmVtaXRfYnJlYWRjcnVtYl9zeiA9
IGdlbjZfeGNzX2VtaXRfYnJlYWRjcnVtYl9zejsKPiArCX0gZWxzZSB7Cj4gKwkJZW5naW5lLT5l
bWl0X2JyZWFkY3J1bWIgPSBnZW43X3hjc19lbWl0X2JyZWFkY3J1bWI7Cj4gKwkJZW5naW5lLT5l
bWl0X2JyZWFkY3J1bWJfc3ogPSBnZW43X3hjc19lbWl0X2JyZWFkY3J1bWJfc3o7Cj4gKwl9Cj4g
ICAKPiAgIAlyZXR1cm4gaW50ZWxfaW5pdF9yaW5nX2J1ZmZlcihlbmdpbmUpOwo+ICAgfQo+IEBA
IC0yMzA1LDkgKzIzMTQsOCBAQCBpbnQgaW50ZWxfaW5pdF92ZWJveF9yaW5nX2J1ZmZlcihzdHJ1
Y3QgaW50ZWxfZW5naW5lX2NzICplbmdpbmUpCj4gICAJZW5naW5lLT5pcnFfZW5hYmxlID0gaHN3
X3ZlYm94X2lycV9lbmFibGU7Cj4gICAJZW5naW5lLT5pcnFfZGlzYWJsZSA9IGhzd192ZWJveF9p
cnFfZGlzYWJsZTsKPiAgIAo+IC0JZW5naW5lLT5lbWl0X2JyZWFkY3J1bWIgPSBnZW42X3hjc19l
bWl0X2JyZWFkY3J1bWI7Cj4gLQllbmdpbmUtPmVtaXRfYnJlYWRjcnVtYl9zeiA9IGdlbjZfeGNz
X2VtaXRfYnJlYWRjcnVtYl9zejsKPiAtCWVuZ2luZS0+aXJxX3NlcW5vX2JhcnJpZXIgPSBnZW42
X3NlcW5vX2JhcnJpZXI7Cj4gKwllbmdpbmUtPmVtaXRfYnJlYWRjcnVtYiA9IGdlbjdfeGNzX2Vt
aXRfYnJlYWRjcnVtYjsKPiArCWVuZ2luZS0+ZW1pdF9icmVhZGNydW1iX3N6ID0gZ2VuN194Y3Nf
ZW1pdF9icmVhZGNydW1iX3N6Owo+ICAgCj4gICAJcmV0dXJuIGludGVsX2luaXRfcmluZ19idWZm
ZXIoZW5naW5lKTsKPiAgIH0KPiAKClJldmlld2VkLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtv
LnVyc3VsaW5AaW50ZWwuY29tPgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs
LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv
bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK