From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19D5C433EF for ; Sat, 19 Mar 2022 19:55:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235206AbiCST4r (ORCPT ); Sat, 19 Mar 2022 15:56:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232643AbiCST4q (ORCPT ); Sat, 19 Mar 2022 15:56:46 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A06321760C8; Sat, 19 Mar 2022 12:55:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 5FF1ACE02C8; Sat, 19 Mar 2022 19:55:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF6CAC340EC; Sat, 19 Mar 2022 19:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647719719; bh=uj4MoN7wLRxHPnrpjOAR9P4RjaXPPxcItDjnxxSh7Cw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tPONuXnoCi8KQRX7JcDsMsCgDDufn3i13p+NVHbCfqOenZmE8yBhIdEmdWdf27nth L8diqg8F46NYMxzNcVeV31yh8PIG9n8vqQ470pQ3epDL2QpmMxEbSY+D4KZIahM477 Eki96j54uA/oI5fg6IInWD+vGghADCzKf/t/nDmDiN4wJYHJGKz/vpKGeeqUI5WTm0 sIRtUkVSMWPNm8q0kCssS0MnPRBAFaV5Ro48kZOlgPWMYbF9bLMwLdpMzeMDsR7/jM M6eDKdlWxg8L1PI+z9wAPYOVtEotkeQPA1dzHeaKatR2j2wfmEzGWWMQPgbAtHn3ft dYF5rYuzFnrfg== Message-ID: <8a5fdf42-d457-7f47-b66a-8447fb297be0@kernel.org> Date: Sat, 19 Mar 2022 15:55:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2] dmaengine: qcom_hidma: Remove useless DMA-32 fallback configuration Content-Language: en-US To: Christophe JAILLET , Andy Gross , Bjorn Andersson , Vinod Koul Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org References: <4deb32b0c7838da66608022c584326eb01d0da03.1642232106.git.christophe.jaillet@wanadoo.fr> <08b7604d-f528-ecb7-a8b2-7c9c36518143@wanadoo.fr> From: Sinan Kaya In-Reply-To: <08b7604d-f528-ecb7-a8b2-7c9c36518143@wanadoo.fr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On 3/19/2022 2:24 AM, Christophe JAILLET wrote: > Le 22/01/2022 à 19:05, Sinan Kaya a écrit : >> On 1/15/2022 2:35 AM, Christophe JAILLET wrote: >>> As stated in [1], dma_set_mask() with a 64-bit mask never fails if >>> dev->dma_mask is non-NULL. >>> So, if it fails, the 32 bits case will also fail for the same reason. >>> >>> Simplify code and remove some dead code accordingly. >>> >>> [1]: >>> https://lore.kernel.org/linux-kernel/YL3vSPK5DXTNvgdx@infradead.org/#t >>> >> >> Can we please document this? > > Hi, the patch has been applied, but [1] is sometimes given as an > explanation link. > > CJ > > > [1]: > https://lists.linuxfoundation.org/pipermail/iommu/2019-February/033674.html Sounds good, please carry my Acked-By: Sinan Kaya From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7599C433F5 for ; Sat, 19 Mar 2022 19:56:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Jfe3wKgEy+wv+ENrDG4/zOn4P8YWFI3wJk/ksAOssOw=; b=xHIV7d0byyvd0X rOvFix62eZvWbS3a4z+6eJB8xFoN7sMrBby2D3vgJUWyP6F9eOl/Guv76XPx4tHzHNf3H5GgDwK2C QWVXdnbrh700IIjOMARRqL1ngotnlJSO3OLiu+MbPKcvMGji1wHEuhbqaqBKqkFrbDRJJRiIN0R0l dKFImTCwTugICI+tEEOXHH7bh8OlwR1Cjz8Hg1zBkyZW1Gw8vMqGmShecYZ4X3vP28C/I9JzX0xlw W4IzO/PqiR6KlCfl9ghMEMbfXYGTN/xxdaRV30zZ07vsxNRY2uo87MmlyzZJFsC68HLV4GSHhaGDu 8bGgGfozvLOQvtQB4PfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVfAd-004H46-Id; Sat, 19 Mar 2022 19:55:27 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVfAX-004H3g-V7 for linux-arm-kernel@lists.infradead.org; Sat, 19 Mar 2022 19:55:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5771960C32; Sat, 19 Mar 2022 19:55:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF6CAC340EC; Sat, 19 Mar 2022 19:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1647719719; bh=uj4MoN7wLRxHPnrpjOAR9P4RjaXPPxcItDjnxxSh7Cw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tPONuXnoCi8KQRX7JcDsMsCgDDufn3i13p+NVHbCfqOenZmE8yBhIdEmdWdf27nth L8diqg8F46NYMxzNcVeV31yh8PIG9n8vqQ470pQ3epDL2QpmMxEbSY+D4KZIahM477 Eki96j54uA/oI5fg6IInWD+vGghADCzKf/t/nDmDiN4wJYHJGKz/vpKGeeqUI5WTm0 sIRtUkVSMWPNm8q0kCssS0MnPRBAFaV5Ro48kZOlgPWMYbF9bLMwLdpMzeMDsR7/jM M6eDKdlWxg8L1PI+z9wAPYOVtEotkeQPA1dzHeaKatR2j2wfmEzGWWMQPgbAtHn3ft dYF5rYuzFnrfg== Message-ID: <8a5fdf42-d457-7f47-b66a-8447fb297be0@kernel.org> Date: Sat, 19 Mar 2022 15:55:18 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2] dmaengine: qcom_hidma: Remove useless DMA-32 fallback configuration Content-Language: en-US To: Christophe JAILLET , Andy Gross , Bjorn Andersson , Vinod Koul Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org References: <4deb32b0c7838da66608022c584326eb01d0da03.1642232106.git.christophe.jaillet@wanadoo.fr> <08b7604d-f528-ecb7-a8b2-7c9c36518143@wanadoo.fr> From: Sinan Kaya In-Reply-To: <08b7604d-f528-ecb7-a8b2-7c9c36518143@wanadoo.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220319_125522_091633_7FC48E2A X-CRM114-Status: UNSURE ( 9.25 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMy8xOS8yMDIyIDI6MjQgQU0sIENocmlzdG9waGUgSkFJTExFVCB3cm90ZToKPiBMZSAyMi8w MS8yMDIyIMOgIDE5OjA1LCBTaW5hbiBLYXlhIGEgw6ljcml0wqA6Cj4+IE9uIDEvMTUvMjAyMiAy OjM1IEFNLCBDaHJpc3RvcGhlIEpBSUxMRVQgd3JvdGU6Cj4+PiBBcyBzdGF0ZWQgaW4gWzFdLCBk bWFfc2V0X21hc2soKSB3aXRoIGEgNjQtYml0IG1hc2sgbmV2ZXIgZmFpbHMgaWYKPj4+IGRldi0+ ZG1hX21hc2sgaXMgbm9uLU5VTEwuCj4+PiBTbywgaWYgaXQgZmFpbHMsIHRoZSAzMiBiaXRzIGNh c2Ugd2lsbCBhbHNvIGZhaWwgZm9yIHRoZSBzYW1lIHJlYXNvbi4KPj4+Cj4+PiBTaW1wbGlmeSBj b2RlIGFuZCByZW1vdmUgc29tZSBkZWFkIGNvZGUgYWNjb3JkaW5nbHkuCj4+Pgo+Pj4gWzFdOiAK Pj4+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LWtlcm5lbC9ZTDN2U1BLNURYVE52Z2R4 QGluZnJhZGVhZC5vcmcvI3QKPj4+Cj4+Cj4+IENhbiB3ZSBwbGVhc2UgZG9jdW1lbnQgdGhpcz8K PiAKPiBIaSwgdGhlIHBhdGNoIGhhcyBiZWVuIGFwcGxpZWQsIGJ1dCBbMV0gaXMgc29tZXRpbWVz IGdpdmVuIGFzIGFuIAo+IGV4cGxhbmF0aW9uIGxpbmsuCj4gCj4gQ0oKPiAKPiAKPiBbMV06IAo+ IGh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9waXBlcm1haWwvaW9tbXUvMjAxOS1G ZWJydWFyeS8wMzM2NzQuaHRtbAoKU291bmRzIGdvb2QsIHBsZWFzZSBjYXJyeSBteQoKQWNrZWQt Qnk6IFNpbmFuIEtheWEgPG9rYXlhQGtlcm5lbC5vcmc+CgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=