From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH 17/32] net/dpaa2: dpbp based mempool hw
	offload driver
Date: Thu, 15 Dec 2016 12:07:51 +0530
Message-ID: <8a6fe787-f8e6-e326-c1b9-42b001644885@nxp.com>
References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com>
 <1480875447-23680-18-git-send-email-hemant.agrawal@nxp.com>
 <20161215060927.GB19354@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, Hemant Agrawal
 <hemant.agrawal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0062.outbound.protection.outlook.com [104.47.38.62])
 by dpdk.org (Postfix) with ESMTP id AE8FA2934
 for <dev@dpdk.org>; Thu, 15 Dec 2016 07:35:11 +0100 (CET)
In-Reply-To: <20161215060927.GB19354@localhost.localdomain>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thursday 15 December 2016 11:39 AM, Jerin Jacob wrote:
> On Sun, Dec 04, 2016 at 11:47:12PM +0530, Hemant Agrawal wrote:
>> DPBP represent a buffer pool instance in DPAA2-QBMAN
>> HW accelerator.
>>
>> All buffers needs to be programmed in the HW accelerator.
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>  config/defconfig_arm64-dpaa2-linuxapp-gcc |   5 +
>>  drivers/net/dpaa2/Makefile                |   2 +
>>  drivers/net/dpaa2/base/dpaa2_hw_dpbp.c    | 366 ++++++++++++++++++++++++++++++
>>  drivers/net/dpaa2/base/dpaa2_hw_dpbp.h    | 101 +++++++++
>>  drivers/net/dpaa2/base/dpaa2_hw_pvt.h     |   7 +
>
>
> How about moving the external mempool driver to RTE_SDK/driver/pool.
> We are planning to push our external mempool driver to driver/pool.

I really like the idea of this separation:

So,
..drivers/net/<all PMDs>
..drivers/crypto/<all crypto PMDs>
..drivers/bus/<all bus handlers/drivers>
..drivers/pool/<all Pool handlers/drivers>

only concern I see for now is resolving dependency of symbols across 
this structure. for example, DPAA2 Pool would be dependent on some DPAA2 
specific objects - which then are again used in crypto/ and net/.

It is possible to have drivers/common (which DPAA2 PMD patchset is 
already doing). How are you doing that?

>
>>  drivers/net/dpaa2/dpaa2_vfio.c            |  13 +-
>>  6 files changed, 493 insertions(+), 1 deletion(-)
>>  create mode 100644 drivers/net/dpaa2/base/dpaa2_hw_dpbp.c
>>  create mode 100644 drivers/net/dpaa2/base/dpaa2_hw_dpbp.h
>>
>